From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577BE3644B3 for ; Wed, 11 Mar 2026 14:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773240540; cv=none; b=XJP/pdZYVJUthqy52DDMd2XPOLqtANFGA9yoDrrenmTy0hDxhfZ6/Dx1q+SLfHWLIkDyM/sSwvI0gnYvdynoR1WBnsWqiXvdpXvPoR4x3/b4fPtX6GWygRsBCJseIOPhSdDHLvmOGWxte9+oJ4MeLnpAEsl0ZjvOKOoXmFR6Qh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773240540; c=relaxed/simple; bh=VjTuVrNei2TqAitiUlEfhS/9ihnYTwEg9XLL8Y1VnFk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/wLyzdt84k0rygNXRYrHI5NindlaXVxvp0OLX4TJdsGTuTTXeDL2h+0ETL3iB5fq41UXa7tvJDGltMNoHJf/yfqIV4X3WkoDkDnXIbtndnkkVhTMgaJqFkEtL6OD6ek8fA2X2l7hsizSz04NihdUggqYSIRH4XWAlD4MAxPDUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=D6tc5Y3m; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D6tc5Y3m" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-439b97a8a8cso10058935f8f.1 for ; Wed, 11 Mar 2026 07:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773240537; x=1773845337; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4lgNy5yMCcnmCSkcJzhlt2CENGm8tHrdHSldEAqpwXg=; b=D6tc5Y3mULgec3q6FioUQvnDFThWAeYveQRTqnuGR3HgWGd+txEvRfrWUdLiLOGgmh BGQglR6qaM26FfU+wqmVkAognrbie8gdUerdiKaykCumjztR24QDzZpHgdp9e7+nd8Ki mB/aSKbMvWcDsCY1pMxrhKrK9sRp/YpzLU34yFBRBDAnsH5cqXg4/WP3LFP1I2OXxDHZ UKTLiBSZm/Bgv+Z5m6dhu7L3+KSs4fYkiyqvtSKGpDl8gV+mou9QjMCnPp1FvRcxhM3Q WkyZ5QxNnuho8wMGKzPzeMTA4LAICG8L9uXT9Cy3RuPvMdr+pzUv7X7utRwnriaIqwBr i3Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773240537; x=1773845337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4lgNy5yMCcnmCSkcJzhlt2CENGm8tHrdHSldEAqpwXg=; b=v++iXuubYMf0PIiNUkewBSqPeFCFmjHBcXX3ETlhAxMWc42r33JEgf0MsRbtqzJZxM 4NARE1IixMs63DsRzUlYRQt8GghHr2tI7/pJd4q3ox9hITrRnnQZ/l5ESoD/Ox57pzOx nj4r86bd6e34cs5jUt0dNnTPlczVLiaeuw1An0nE246lClARqakhrI+wLlQn6W4bQClm yUqxB++sMg89KpgTrulXt3GR0nunARUtekdBkWzt4UyUpAuzz6yOS4ScQT2qEqqdITkx HbpBO2DinQKYAfILe+m3df3s3T+EI68CO23xKkpTFuXAMvUmmkfjFVRs17zXakUhd+yq V6ZQ== X-Forwarded-Encrypted: i=1; AJvYcCUEBvSJtv2IBwMpwUn/vytU5RevOxFM0O1HKLs54P23raU9l+Dr1KPmadsHA/9qkZlXLy+Y8RJ5KCI36IQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxLKRFrL/7BgZuWD+0gayaOlMDZGEYQ8FhPVlJdk7tdGV0sZBuz 2eMWzrzjR7tApIFt8ZWm4FzAwNduEm1F8sxPAGJ2bZ2isr79R8x74uwnodLxjS2We70= X-Gm-Gg: ATEYQzztSpcSYM5/R8r8uMZQi/NdO8FPU+Rh8BcgA1RHckCv4OUBFqkLB+iM2W0Da9J w0aD+dwrTGvrgJgmCX+ZU4D3wY6n6YMYi6yszrCGptp/5qG90D3q+FYa9sCNEKwO2Nnq9T7nyDu q6sw722mvNOEujkgIpNHAN/Figy6rYThqOh7rht7JMJbqrqos9NCOEJ/KrjO+YisBNRDsMyA5KB dYrasRBOjWnQGvnSJ4s4ejoHMd22SYemqV1rrmufaQbN/kpQFskIubRN8aWv/ig2GwqkE8VVRVZ XeidfIADF51ZmqTe6e8u8ISkferdNkC4V7HICZYJnUE7K8hH3kc+UeplqZHnkIMKdJ3nQ/dWVIt 5OO+NXc5x1g9z8wsJM9vAwDDW9omzpexuXaUrY1cHhVZOwvniDhzeeQ1HQLUF59+SxBPLxxw3f9 /G3JRNs9cf/wb+6E5iRP0CzW63GuF8 X-Received: by 2002:a05:6000:288c:b0:439:cf1f:22a7 with SMTP id ffacd0b85a97d-439f81e295amr5406937f8f.6.1773240536680; Wed, 11 Mar 2026 07:48:56 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f81a0307sm7214870f8f.11.2026.03.11.07.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 07:48:56 -0700 (PDT) Date: Wed, 11 Mar 2026 17:48:53 +0300 From: Dan Carpenter To: Anas Iqbal Cc: andy@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fb_tinylcd: replace udelay() with usleep_range() Message-ID: References: <20260311142407.35403-1-mohd.abd.6602@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311142407.35403-1-mohd.abd.6602@gmail.com> On Wed, Mar 11, 2026 at 02:24:07PM +0000, Anas Iqbal wrote: > Replace udelay() with usleep_range() for a 250 microsecond delay > as recommended by checkpatch.pl. usleep_range() avoids busy > waiting and allows the scheduler to schedule other tasks. > > Signed-off-by: Anas Iqbal > --- > drivers/staging/fbtft/fb_tinylcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c > index 9469248f2c50..51e6493b050f 100644 > --- a/drivers/staging/fbtft/fb_tinylcd.c > +++ b/drivers/staging/fbtft/fb_tinylcd.c > @@ -38,10 +38,10 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0xE5, 0x00); > write_reg(par, 0xF0, 0x36, 0xA5, 0x53); > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); Don't do this. 1) It's unrelated. 2) The previous alignment was done deliberate to make it easier to read. Checkpatch is not perfect so don't always do what it says. > write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55); > write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); > - udelay(250); > + usleep_range(250, 500); Do a search for init_display on lore https://lore.kernel.org/all/?q=init_display regards, dan carpenter