Re: [PATCH 0/5] watchdog: rzn1: Add support for direct hardware reset

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

> On think that could be missing is the way to know if we are allowed or not
> to enable this reset source.
> 
> Maybe a new "renesas,reset-type" property in the watchdog node could give
> this information. This property could take the following value:
>    - "soft":
>      On timeout, the watchdog triggers an interrupt.
> 
>    - "hard":
>      On timeout, the watchdog asserts the directly the system reset.

This would be configuration, not HW description, so not for DT. Also, I
think watchdogs are expected to reset the system. I'd see it as a quirk
if they can only raise an interrupt. So, let's go the full system reset
route, I'd say.

> Whatever resets allowed by the firmware, it is already overridden for the
> sofware reset and the watchdog resets the system.

I see.

> So my plan for the next iteration is, as you suggested, unconditionally
> allows watchdog resets in the clock driver probe(). Indeed it is the
> driver in charge of sysctrl.

Sounds totally fine to me.

Happy hacking,

   Wolfram