From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 717413DD51F for ; Wed, 11 Mar 2026 17:33:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773250398; cv=none; b=V6KzOF8X6I0Yk61aA7CNUNIXm/SSiWbnUPxr/a5xGBYiOBS+NPQImbgeSH8BUWGz8yaDeiw7apBVoEjzVqWto0sbDBqsOyVzsbeKvk5UtTv0xH05IIzEeWeXCUfhlg+BtQ9xEkXprdzzKbJXm4/wuLaiBFwMvEa7Gw50r6A6TXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773250398; c=relaxed/simple; bh=QtnOsEgCMql4VtUtkhuFdS7MZ4CmdFdpVJ4uhg5/oyA=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vGX6xA7VVB/digzCuTAqSbFIQ3wpivCV8LXvc1ue4zryw54vVMJsdw3aUXYXq50/TnnGbyjrpCUqFbuD5RGOAhI3AWPSayWLzoEl+mFcx+A2mL0a3i6LY1GrqwaiYqIuozBpRFQb8KjFeS7E8Pvg/FIW0dUocfJR3ezRiaAj/P8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U5lu3D4V; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U5lu3D4V" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-38a38ccc217so1597371fa.0 for ; Wed, 11 Mar 2026 10:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773250393; x=1773855193; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=32P43u5/pepmI+c39ykZxDjXGtV6qTvip6R4B95J07g=; b=U5lu3D4VLe9QuTVwZJ2JRQ2FlVNE1FLwM2oPoYzlUZhWThnyAS8zNr+n8o2HWM+CL5 ZUsWnGlKvtIYvvwTJrkn7dHAAXihHyWhUpi6xbWGNV4EwwaUjlNklTSpH3DJOCcCXRFn WrEy+PEoYdTAmGMyS0uMQEhQ2lj/qsnrPy7fWfEmU3Dtj5bx19fYjkWET9qWYuCCWp6O DaUFaxJnem/RlqHcxQoU8o8v3ijNcJ+I5M1N4MU6x1BWb/KrIlYSVs+byaCjLXkeOrHb a1wZWPL47D2oYB/rAa3BAzoJ7zs8qraCAEaeeXOkOQp7xHAOTDOf1V1GUQe2odUuSQfw VhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773250393; x=1773855193; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=32P43u5/pepmI+c39ykZxDjXGtV6qTvip6R4B95J07g=; b=FxoLTl53nXXNEpz/s0N0cIFMSFkh2z7wH3UIBB437TM1PHhBp1xPXhvOD144Z5zu/L kG6n9vkKcfea/HtH77h0ZL9YBgFKALuEuwYmzO0ZfYTNWQfMVigwpMEeOI6cEkU83ThF h/FTNjl7nHKroZ0kqSXevyXLkZXSgLszjlVuKtZrxY3d9Z1XtHSPw6MHo02lB9Oxs87z qF09C83tg8Pjs73v6GWIWxy/GXFty6a9EPcxtzZfZZHLNnpyM8ohE27k/YYrJVmAjYl7 ogRXhv73ExgJ2GtStgYY97dKq1OY5buXMuter1kWCVGYKvRRryixlmp6SId294CgydK/ 7cBw== X-Forwarded-Encrypted: i=1; AJvYcCVj3gXDdTJuGedyv8GlgnH4IqL2BDLzUcZ1MPCIXM3uQd8QvsSgmy60X2VkpTSvJXo7f5pn4DC0NA8J3sg=@vger.kernel.org X-Gm-Message-State: AOJu0YykhGNV1r7qOBiZ6aPSftXay8BJgRb3YJMswHzs+HOJuRSImbQ3 Ce4F9WhmLovGqLZHt7px9S59IByzSUtThvGc4XLzoN4C2WYwYMwV80Jr X-Gm-Gg: ATEYQzx5st6cNIvglHRQhPi9UJe6vNxetqrOM4rZDKVdwWszIYgCTQgMPc31j0Fbpzs zTntJmiLQF0x8xTf0a4noucZNz2ksccytL2Evy3M6gDiqCxt4HKuo6xJxys9irdGCnF/HysxG9X 400AAKv5+p1ob3QyoXiNDkBfqsgxkiKNk35d36M1/7pLGlkOlt3b4yrZskvZUsBjI/stoRXNxS0 Pvz4jGic3tujUXLTrxDctHrswcoLW9/iJYTpldyr6JpF9A7mIeycFYj9NznWWKTn756sblQ6q0K 8Ttlk4CV5t/2GNbo4RnW6PFE5Bp8rNHQUiJ5+v6BINopC9KSKWpwFPGEZx3kQsL/QT/ENJbkoRW b2mLx8Qf0pCBLMh4VOUFRRmwY3ajLnwx4ahwWHbcTNS9F19B0H4ppeDDr9xvueD94RHgx4ntz1Y c= X-Received: by 2002:a2e:bf02:0:b0:38a:3feb:d2ee with SMTP id 38308e7fff4ca-38a67e68170mr11805311fa.32.1773250393105; Wed, 11 Mar 2026 10:33:13 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d61851sm4620541fa.4.2026.03.11.10.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 10:33:12 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 11 Mar 2026 18:33:11 +0100 To: shivamkalra98@zohomail.in Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alice Ryhl , Danilo Krummrich Subject: Re: [PATCH v2 1/2] mm/vmalloc: extract vmalloc_free_pages() helper from vfree() Message-ID: References: <20260304-vmalloc-shrink-v2-0-28c291d60100@zohomail.in> <20260304-vmalloc-shrink-v2-1-28c291d60100@zohomail.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304-vmalloc-shrink-v2-1-28c291d60100@zohomail.in> On Wed, Mar 04, 2026 at 08:23:15PM +0530, Shivam Kalra via B4 Relay wrote: > From: Shivam Kalra > > Extract the page-freeing loop and NR_VMALLOC stat accounting from > vfree() into a reusable vmalloc_free_pages() helper. The helper operates > on a range [start, end) of pages from a vm_struct, making it suitable > for both full free (vfree) and partial free (upcoming vrealloc shrink). > > No functional change. > > Signed-off-by: Shivam Kalra > --- > mm/vmalloc.c | 42 ++++++++++++++++++++++++++++-------------- > 1 file changed, 28 insertions(+), 14 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index c607307c657a..e2aef0a79f2e 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3416,6 +3416,32 @@ void vfree_atomic(const void *addr) > schedule_work(&p->wq); > } > > +/* > + * vmalloc_free_pages - free a range of pages from a vmalloc allocation > + * @vm: the vm_struct containing the pages > + * @start: first page index to free (inclusive) > + * @end: last page index to free (exclusive) > + * > + * Free pages [start, end) updating NR_VMALLOC stat accounting. > + * Caller is responsible for unmapping (vunmap_range) and KASAN > + * poisoning before calling this. > + */ > +static void vmalloc_free_pages(struct vm_struct *vm, unsigned int start, > + unsigned int end) > +{ > + unsigned int i; > + > + for (i = start; i < end; i++) { > + struct page *page = vm->pages[i]; > + > + BUG_ON(!page); > + if (!(vm->flags & VM_MAP_PUT_PAGES)) > + mod_lruvec_page_state(page, NR_VMALLOC, -1); > + __free_page(page); > + cond_resched(); > + } > +} > + > /** > * vfree - Release memory allocated by vmalloc() > * @addr: Memory base address > @@ -3436,7 +3462,6 @@ void vfree_atomic(const void *addr) > void vfree(const void *addr) > { > struct vm_struct *vm; > - int i; > > if (unlikely(in_interrupt())) { > vfree_atomic(addr); > @@ -3459,19 +3484,8 @@ void vfree(const void *addr) > > if (unlikely(vm->flags & VM_FLUSH_RESET_PERMS)) > vm_reset_perms(vm); > - for (i = 0; i < vm->nr_pages; i++) { > - struct page *page = vm->pages[i]; > - > - BUG_ON(!page); > - /* > - * High-order allocs for huge vmallocs are split, so > - * can be freed as an array of order-0 allocations > - */ > - if (!(vm->flags & VM_MAP_PUT_PAGES)) > - mod_lruvec_page_state(page, NR_VMALLOC, -1); > - __free_page(page); > - cond_resched(); > - } > + if (vm->nr_pages) > + vmalloc_free_pages(vm, 0, vm->nr_pages); > kvfree(vm->pages); > probably we should move "if (vm->nr_pages)" condition inside the vmalloc_free_pages(). I think, the function name should also be renamed to something like vm_area_free_pages() so we align with vm_area_alloc_pages() helper. -- Uladzislau Rezki