From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81AE92E1F06 for ; Wed, 11 Mar 2026 17:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773250491; cv=none; b=gDL0fqJjoAUocY3zTpBfqH9qO3x8YG+Tcb9GCaK76uFcTO1vuoQ2YgKDDzSPyFg0W32sEufOyNiGU9avH5XRUi61U0gdmWFjlbVOdGl36WCs+PO2f1I6WiZXfPAI7MehYdWeSkQhTdVw+2RZxwyWobrpBjmf3CxV7MitwIiJXvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773250491; c=relaxed/simple; bh=YgrZpoM4Df1FfsXsqil7/s1ej3Yh407duFi2SQMsm18=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=omY3Osa7/FTJVTW1wanKVMDi2zkdSjtd6R0a7O9wOH8/DtS+XZ6DAna76MaEN/eXJ9dMFEO1Rr2LtPNVDHXQJIbd6P3oB2y6isctPsLatmQb6CplL4bEJfOq8MqKpiekNRAKn2rx0BeGqU72Ec9H1XLns4rAb72G36RFp9K9zno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MY2+XNtf; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MY2+XNtf" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-38a4234f91dso1652931fa.2 for ; Wed, 11 Mar 2026 10:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773250487; x=1773855287; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=bEN6rA6I2hE/dmJ6WhA4UF/cwwzcqi8Y+lZoV8+a3GQ=; b=MY2+XNtf6x3TLGZvV7dma60BHtI3shnVxm5X+u+dNneu/qzMcsg06voJdfkqL4foA7 uEkn5XHEc7j2wl08oyhw2wfLA8dr0fLxMcVtcdb6aHGad5LkufV2vh1X1cY4k5a87eqJ MrEArfXSpLm7iRhJMwITQ0gn8f+J7HPcw9Mn1IuSmrKSs75Ob+JyX3lnedep75ZClPg6 nbElSG/g30nWVWzcW6zOgfQO2aqL5dOkYX0K7eOtNbof3m+0if5N4vsLJPA+0/ekL4hg FeF04KpY248VD2GdhfleJfyuS7GCGbfHVnCfrYYP2+gRmsPmMYDMZI0QEBHksUb8vCOj pHWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773250487; x=1773855287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bEN6rA6I2hE/dmJ6WhA4UF/cwwzcqi8Y+lZoV8+a3GQ=; b=xNpJN7s++NnVKpoLDJYxG/BSjcmwUbR/SuXDiE/2YacBu5qeMt+eAA38SH0I1kpmWQ gLOD1UOFQSQOIVShA/Pu+XSebhSFiBGENBBQaQWa2uzRsaYpEaPnQvvhBuJJMS3my9rS PThuVCVIGYvM+B3xzQ4XOeuFnxxRjwFD+mJGnVJCtOfTrZjjkahKlAMHGYMtwxaTt6zu 4Cx1moSoNC9LanNbOLzOLRrytSwoVAeMEiZbm1TOWjy4GrNXAe/vL2W5VvHfTlpWFHRs Qf9+NuMZbIvU/7xpIqJiTl05OMUETfufBQrLtntvRfM9FHPJNozBDTbDVauuYRJbv16D E9JA== X-Forwarded-Encrypted: i=1; AJvYcCWli0V11A2XYq0MAq5Z6pcFCX5a/XYnzyMqwMg0609//1l5+555JQlaRpvxRglOmkDg1XjHTfF9l/1Hrtk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7I/S6+oi78TjdbyQ+53NfDEzGjNoGnOZ76JVwB/7WdCYO7UMX eJsZ003Ljr53pdGkJe3LNpiBxSGtkXJoeq0P714fpQUM08KV6n1+1nLQ X-Gm-Gg: ATEYQzx8X7vCyEzUyxBkLto63QXL9pld7ASWgdYh2Yy6XQIlVxOzpwRV1fb4jAJPxz7 6zLg9o6tnh0b288nK6QtcaH/HKg9kjP3ma5mw5ebstDwRhozzl4GA/ueKWdwGZmbDRMygbQbXm1 UQ3FRQYod6dOodp/RjdcFxg6o+crrZz8LBXPk8iHI1Crbd9iAZoimoZAZ/QS0t0rg/w9MR+xb5W KMkC+VF++BaXhdUYVzMV2sB3R/IUF2TfiKvZiEFkCiB0DGfC4BB7eINk2qrb1G+qN24g7pQn5fj h98onjycCRtnXzzWDJvnPSDF668mH+w6tRW0QwR7wLI8VrBPEzPXp9UWsR9JpX+zzW2YwHVxDmv 1JVDq4oej0EevlpYvFdhF89t34XCHOLr27dmxwPt+JFoQTgpVMYqLLQM63BK22T+K X-Received: by 2002:a05:651c:985:b0:37c:d689:7e1c with SMTP id 38308e7fff4ca-38a67e1b7c5mr13078491fa.23.1773250487356; Wed, 11 Mar 2026 10:34:47 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d5fab0sm4838941fa.8.2026.03.11.10.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 10:34:44 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 11 Mar 2026 18:34:41 +0100 To: shivamkalra98@zohomail.in Cc: Andrew Morton , Uladzislau Rezki , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alice Ryhl , Danilo Krummrich Subject: Re: [PATCH v3 1/2] mm/vmalloc: extract vmalloc_free_pages() helper from vfree() Message-ID: References: <20260309-vmalloc-shrink-v3-0-5590fd8de2eb@zohomail.in> <20260309-vmalloc-shrink-v3-1-5590fd8de2eb@zohomail.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309-vmalloc-shrink-v3-1-5590fd8de2eb@zohomail.in> On Mon, Mar 09, 2026 at 05:25:45PM +0530, Shivam Kalra via B4 Relay wrote: > From: Shivam Kalra > > Extract the page-freeing loop and NR_VMALLOC stat accounting from > vfree() into a reusable vmalloc_free_pages() helper. The helper operates > on a range [start, end) of pages from a vm_struct, making it suitable > for both full free (vfree) and partial free (upcoming vrealloc shrink). > > No functional change. > > Signed-off-by: Shivam Kalra > --- > mm/vmalloc.c | 46 ++++++++++++++++++++++++++++++++-------------- > 1 file changed, 32 insertions(+), 14 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index c607307c657a..42ae68450a90 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3416,6 +3416,36 @@ void vfree_atomic(const void *addr) > schedule_work(&p->wq); > } > > +/* > + * vmalloc_free_pages - free a range of pages from a vmalloc allocation > + * @vm: the vm_struct containing the pages > + * @start: first page index to free (inclusive) > + * @end: last page index to free (exclusive) > + * > + * Free pages [start, end) updating NR_VMALLOC stat accounting. > + * Caller is responsible for unmapping (vunmap_range) and KASAN > + * poisoning before calling this. > + */ > +static void vmalloc_free_pages(struct vm_struct *vm, unsigned int start, > + unsigned int end) > +{ > + unsigned int i; > + > + for (i = start; i < end; i++) { > + struct page *page = vm->pages[i]; > + > + BUG_ON(!page); > + /* > + * High-order allocs for huge vmallocs are split, so > + * can be freed as an array of order-0 allocations > + */ > + if (!(vm->flags & VM_MAP_PUT_PAGES)) > + mod_lruvec_page_state(page, NR_VMALLOC, -1); > + __free_page(page); > + cond_resched(); > + } > +} > + > /** > * vfree - Release memory allocated by vmalloc() > * @addr: Memory base address > @@ -3436,7 +3466,6 @@ void vfree_atomic(const void *addr) > void vfree(const void *addr) > { > struct vm_struct *vm; > - int i; > > if (unlikely(in_interrupt())) { > vfree_atomic(addr); > @@ -3459,19 +3488,8 @@ void vfree(const void *addr) > > if (unlikely(vm->flags & VM_FLUSH_RESET_PERMS)) > vm_reset_perms(vm); > - for (i = 0; i < vm->nr_pages; i++) { > - struct page *page = vm->pages[i]; > - > - BUG_ON(!page); > - /* > - * High-order allocs for huge vmallocs are split, so > - * can be freed as an array of order-0 allocations > - */ > - if (!(vm->flags & VM_MAP_PUT_PAGES)) > - mod_lruvec_page_state(page, NR_VMALLOC, -1); > - __free_page(page); > - cond_resched(); > - } > + if (vm->nr_pages) > + vmalloc_free_pages(vm, 0, vm->nr_pages); > kvfree(vm->pages); > kfree(vm); > } > > -- > 2.43.0 > > I posted my comment for the v2. Same here: probably we should move "if (vm->nr_pages)" condition inside the vmalloc_free_pages(). I think, the function name should also be renamed to something like vm_area_free_pages() so we align with vm_area_alloc_pages() helper. -- Uladzislau Rezki