From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675EC2E11C7 for ; Wed, 11 Mar 2026 17:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773251436; cv=none; b=pGhGW5cWFL3vp0Aty6nIWCQcC+IX7oQUwY16b0cFAhGsvLqWPFEmePafXMSudtWoMVaV1/tcRLD/CizwbDnkU8any9IDUCnHIzLlMy2qQBumua4SWaq/6kDgfHQLlftBNI8IWz0HvZY2U9KQOPVg8xJN9Ycf+ha5+7fuuAqePp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773251436; c=relaxed/simple; bh=AqtE7Woo2wJkk4YzUSo/ljmI6DBc2LqEBMpIQky+d6w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xj6mwRpm9fVhp432UheDKMKkO2lHK3KsqJlLJz7016VI3iMQiUkBIKsuel3IfDa62FhCAZMBnGJn1xxVrqEznq3bFQ0TxrjRmz9dT9v4Oh//ploi3eeNzq8QFNS6VavYuzxcb0k80mb/8TzbWqG5OMMq8LJNdMB+rTXY0nsGHJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CH25+LoT; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CH25+LoT" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2b4520f6b32so279272eec.0 for ; Wed, 11 Mar 2026 10:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773251434; x=1773856234; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0C7idNGphygpy7RxPPF10pjDsEO+bsMCLejih4BdrII=; b=CH25+LoTfib/KxbnVuUAHmRSaAZsDWguSCH+OoBz1DXZStyFlwyLHFjThbu1fSXVU6 w5mH6Oqm2n321jjEcdJ0V22d7wYK1SQB3p3Xczj+TXfwyIxPb9xe+ve0hrcTNRX0/Kzr DrW1u0wXcbTKBPbuH+hc43OU2St/M/YWT9BEiOI8XwsBwTF66ewOGiK3HnE5EnqvhlGM 07RkVpxSgoQwjXWHDW+jUczac894NSXHcF81eX0G5Kk0Pki4WrKaweX8LnaCs3IFnpwE RIB60mDFsBNBKkkYHHezbsZQXsPncNQtui2Hr4uYwqfd+vyP5iXR1ZPiwOP5zjMr1NAB o75A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773251434; x=1773856234; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0C7idNGphygpy7RxPPF10pjDsEO+bsMCLejih4BdrII=; b=vlSmL/4ZIJfNUkGzPqqt6L2VIKe9wwE3wRIYKgGu/E8dbvBhoRb//vwf4AHrqx+uE4 nRqQ1s9pHA6L+odTkmnLaOZLfVWLgxOKi80PwdtXKVt8sHyAAF3+p9CdgJq3LfZAgrmd f1tE3ZBwRNZkIa7+oziV9ZPIzXkRHa3lFb0qJQu+YsD4SO/+FyVtcRthg6nLiU7roHj1 TkXwFqtMHG7o+jYzdRS4C1PqZKlaD5boy0Bm2or483EJf3FZUfQ3zWG5cV6OMzxoEilQ lqBfdA4Ej6VqosxN/W4cHTRRER2trcAIMPx6P4OReDGR82M+hLAe7wWK29rAMXCoWY99 7qig== X-Forwarded-Encrypted: i=1; AJvYcCWzviwkdkAXx1xckMCILKAy7ZvlI8Au66jC2TrGge40CiFT49KfqWD/9wQtUhkl36k22E70jesP7t+G6VY=@vger.kernel.org X-Gm-Message-State: AOJu0YzDjPYzo3jwI+CRfBl7YfJbc42xH/xCl37xkETXrcWH2PSuZhrp Oo+yibd3jydvdm8tHxgCHQ/d4Gol/U79efT+MlxfZMvPPQ19nFtCa7u6 X-Gm-Gg: ATEYQzxRO5BSNXAxy+/NssXz0MkuBz9PoHbePPknXCIq27kZdOMX7WjeyF/0hEClAXb k5N1S/K1fEEX7MUVm+fdANbi8bFFI1zRPtMOmVIxDsqiaQ6gcu7O7bUQGuXk8eUPXdYdjlvdLNf ed6NazOQMRmeWYwiPYJANwwNjBReo0a2QgaskqGki22FeeDYyNJ/NicyBCY0CyBI7CJ8uE7g/he NiKGG9cgbiu9ws0nRvRn/CJCB2EDA/ipu0GZrJwoDvZEyhCGyENq3qfKrfu1B/Jr2VNq/KyLrw4 61vrUCC7pxI9zO/9PjDNZFujDom2ChCEYBelGjbkOr0Acl1JkC4P4sZ3oMeFsjKw/C7mmBw/UqA HnloiXo39eibF2WAVlP1T5fMiOsxiNKoDdsxVHiq79AHcgdofOZMn+Bv9yj2mf3/SKRywmfdtMt RYRgUcka0OT+NmawYN6oYgnWNdxDrxz7wM/xKWy5o/pJS03hol/iYNatSeHatNEV0s X-Received: by 2002:a05:7301:5795:b0:2be:969:75f3 with SMTP id 5a478bee46e88-2be8a528f33mr1232940eec.34.1773251434418; Wed, 11 Mar 2026 10:50:34 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:53e0:5b17:5211:b0f4]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be8aa4eb92sm3729992eec.22.2026.03.11.10.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 10:50:33 -0700 (PDT) Date: Wed, 11 Mar 2026 10:50:18 -0700 From: Dmitry Torokhov To: mikhail.v.gavrilov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: uinput - fix circular locking dependency with ff-core Message-ID: References: <20260228223628.472208-1-mikhail.v.gavrilov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 11, 2026 at 10:47:25PM +0500, mikhail.v.gavrilov@gmail.com wrote: > On Sun, 2026-03-01 at 03:36 +0500, Mikhail Gavrilov wrote: > > A lockdep circular locking dependency warning can be triggered > > reproducibly when using a force-feedback gamepad with uinput (for > > example, playing ELDEN RING under Wine with a Flydigi Vader 5 > > controller): > > > >   ff->mutex -> udev->mutex -> input_mutex -> dev->mutex -> ff->mutex > > > > The cycle is caused by four lock acquisition paths: > > > > 1. ff upload: input_ff_upload() holds ff->mutex and calls > >    uinput_dev_upload_effect() -> uinput_request_submit() -> > >    uinput_request_send(), which acquires udev->mutex. > > > > 2. device create: uinput_ioctl_handler() holds udev->mutex and calls > >    uinput_create_device() -> input_register_device(), which acquires > >    input_mutex. > > > > 3. device register: input_register_device() holds input_mutex and > >    calls kbd_connect() -> input_register_handle(), which acquires > >    dev->mutex. > > > > 4. evdev release: evdev_release() calls input_flush_device() under > >    dev->mutex, which calls input_ff_flush() acquiring ff->mutex. > > > > > > > Hi Dmitry, > > Friendly ping on this patch. It fixes a reproducible lockdep circular > dependency warning in uinput with force-feedback gamepads under > Wine/Proton, tested on 7.0-rc1. > > I realize I should have included: > > Fixes: ff462551235d ("Input: uinput - switch to the new FF > interface") > Cc: stable@vger.kernel.org > > Should I resend as v2 with these tags, or can you add them when > applying? Sorry I need a bit more time to evaluate the patch. I think what you proposed makes sense, just give me a couple more days. If there are no changes needed I can add necessary tags on my end. Thanks. -- Dmitry