public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Landwerlin, Lionel G" <lionel.g.landwerlin@intel.com>
Subject: Re: linux-next: build failure after merge of the drm-xe tree
Date: Wed, 11 Mar 2026 14:10:03 -0400	[thread overview]
Message-ID: <abGv-5kXSCtOTO8M@intel.com> (raw)
In-Reply-To: <ae413dfe2aa2d18c0b4c44d4bdb15bb630db177d.camel@intel.com>

On Wed, Mar 11, 2026 at 01:16:22PM -0400, Souza, Jose wrote:
> Hi Rodrigo, can you help me here?
> 
> I think this issue was because
> https://lore.kernel.org/all/49dc20448a12f3e03f5f8347540d167a281b8987.1772042022.git.jani.nikula@intel.com/
> was merged in drm-intel-next.
> 
> If it was splitted into a i915 and a Xe KMD patches and merged each to
> its own tree I think we would have avoided the issue.
> But I have not looked at that whole series to understand why that
> decision was made.
> 
> I don't know how to fix it, maybe rebase drm-xe-next on top of drm-
> intel-next and then a new commit fixing 0e07b16371b6e.
> Not sure what is the best option, can you help us here?

This explains why the patch was not applying cleanly.
This is the reason why we should never ever edit the patch directly when merging.

If this is breaking the drm-tip build as well we should immediately revert the
patch. But I'm considering this anyway.

The alternative to that is:

Jani needs to do a drm-intel-next Pull request towards drm-next.
Then Sima and Dave picks that up.
Then Brost do a backmerge fixing the build issue in the merge commit.
Once we fix it we let Mark know so the branch gets re-enabled in linux-next.

Let's revert and re-attempt after drm-intel-next and drm-xe-next are back in sync?


> 
> Thank you
> 
> 
> On Wed, 2026-03-11 at 13:08 +0000, Mark Brown wrote:
> > Hi all,
> > 
> > After merging the drm-xe tree, today's linux-next build
> > (KCONFIG_NAME)
> > failed like this:
> > 
> > /tmp/next/build/drivers/gpu/drm/xe/xe_lrc.c: In function
> > 'xe_lrc_ctx_init':
> > /tmp/next/build/drivers/gpu/drm/xe/xe_lrc.c:1554:43: error: implicit
> > declaration of function '_MASKED_BIT_ENABLE'; did you mean
> > 'REG_MASKED_FIELD_ENABLE'? [-Wimplicit-function-declaration]
> >  1554 |                 state_cache_perf_fix[2] =
> > _MASKED_BIT_ENABLE(DISABLE_STATE_CACHE_PERF_FIX);
> >       |                                           ^~~~~~~~~~~~~~~~~~
> >       |                                          
> > REG_MASKED_FIELD_ENABLE
> > 
> > Caused by commit
> > 
> >   0e07b16371b6e (drm/xe: Allow per queue programming of
> > COMMON_SLICE_CHICKEN3 bit13)
> > 
> > I have used the tree from next-20260310 instead.

  reply	other threads:[~2026-03-11 18:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 13:08 linux-next: build failure after merge of the drm-xe tree Mark Brown
2026-03-11 17:16 ` Souza, Jose
2026-03-11 18:10   ` Rodrigo Vivi [this message]
2026-03-11 18:16     ` Souza, Jose
2026-03-11 20:11       ` Rodrigo Vivi
2026-03-12  7:47         ` Lionel Landwerlin
2026-03-12 11:43           ` Mark Brown
2026-03-13  0:50             ` Rodrigo Vivi
2026-03-13  1:18               ` Souza, Jose
2026-03-13 13:25               ` Mark Brown
2026-03-13  0:46           ` Rodrigo Vivi
2026-03-13 13:57           ` Jani Nikula
2026-03-16 17:38             ` Mark Brown
2026-03-19  8:59               ` Jani Nikula
2026-03-19  9:00                 ` Jani Nikula
  -- strict thread matches above, loose matches on Subject: below --
2025-03-07  2:21 Stephen Rothwell
2025-03-11  2:15 ` Stephen Rothwell
2025-03-07  1:58 Stephen Rothwell
2025-03-11  2:13 ` Stephen Rothwell
2024-12-04 13:36 Mark Brown
2024-12-04 13:46 ` Jani Nikula
2024-12-04 14:18   ` Mark Brown
2024-10-01  1:38 Stephen Rothwell
2024-02-22  8:04 Stephen Rothwell
2024-02-22 17:09 ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abGv-5kXSCtOTO8M@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=broonie@kernel.org \
    --cc=jani.nikula@intel.com \
    --cc=jose.souza@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox