From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE4B63E6DC1 for ; Wed, 11 Mar 2026 18:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773253235; cv=none; b=DJqYwWCfbel0YuJ5HK3uWJwb+5UfkCl5ZaEUxndYREOO4SprPLwT12wA1rvQqkuelBFFHt/eKNcDhM9l57bGzjW7NHAkbf7Pem7+5ibaoZtrTl7PrWDsAqpcsx35BAkXTxc/ioRDGXf8H9YGoPNUFc22B94IVS1uRf9qn7xqccU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773253235; c=relaxed/simple; bh=45+bbImytAgdWvuTTyMtGOa0bSN7zTYqiK74Z9PPIEE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q1gj1mngCi8PrXgWOlmCE7TVYMhxUauunsow35jr37jjc+8SyK8Qr315lKVL4jDlSPUARN18TxSFK0YkysvTEPL0oT+5k3N04b6ozqSFSu1kgTdcxjjjF1Iqe+hDIuEmB/CxTIQv2c0bdePJx+60CNHcyEFRdAxfSK2gptHiwlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LXC6TICV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LXC6TICV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D3DC4CEF7; Wed, 11 Mar 2026 18:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773253235; bh=45+bbImytAgdWvuTTyMtGOa0bSN7zTYqiK74Z9PPIEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LXC6TICV9Ou/RagiAt6/WyWiX5Gtxb3pRAoIgQIz/boWqKIY18kH5JZ4936e316M4 +mvg78eq5A5LnTOKMoHGiX7EI7Zx/LTq4kiXKxuN4JqZH/5lyYT1mZ1jHzCGTFcl4b trk3sUudeNeMIvF8SJ0z4Oj1/BnXteUFlmjkMblxWPD1xVhwNKz5iXhkf+BOkd3Huk wKDY1mthrVPl+QCGurl3rCMICxphWx/Ar8R4sulsE2u8Sb7zMW99iuYbTdOCaVxVD3 Ef+MJpKA10UNiBRELY5R/xgEsxDi0mqt3UQjv5LARzhlA/LyobRh3nByhVrqOZqdJJ UNC+ek2oInPEg== Date: Wed, 11 Mar 2026 20:20:28 +0200 From: Mike Rapoport To: Andrew Morton Cc: David Hildenbrand , "Liam R. Howlett" , Lorenzo Stoakes , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] selftests/mm: pagemap_ioctl: remove hungarian notation Message-ID: References: <20260311180737.3767545-1-rppt@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311180737.3767545-1-rppt@kernel.org> (oops, used wrong David's address) On Wed, Mar 11, 2026 at 08:07:37PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Replace lpBaseAddress with addr and dwRegionSize with size. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index 2ca8a7e3c27e..7f9428d6062c 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -113,13 +113,13 @@ int init_uffd(void) > return 0; > } > > -int wp_init(void *lpBaseAddress, long dwRegionSize) > +int wp_init(void *addr, long size) > { > struct uffdio_register uffdio_register; > struct uffdio_writeprotect wp; > > - uffdio_register.range.start = (unsigned long)lpBaseAddress; > - uffdio_register.range.len = dwRegionSize; > + uffdio_register.range.start = (unsigned long)addr; > + uffdio_register.range.len = size; > uffdio_register.mode = UFFDIO_REGISTER_MODE_WP; > if (ioctl(uffd, UFFDIO_REGISTER, &uffdio_register)) > ksft_exit_fail_msg("ioctl(UFFDIO_REGISTER) %d %s\n", errno, strerror(errno)); > @@ -127,8 +127,8 @@ int wp_init(void *lpBaseAddress, long dwRegionSize) > if (!(uffdio_register.ioctls & UFFDIO_WRITEPROTECT)) > ksft_exit_fail_msg("ioctl set is incorrect\n"); > > - wp.range.start = (unsigned long)lpBaseAddress; > - wp.range.len = dwRegionSize; > + wp.range.start = (unsigned long)addr; > + wp.range.len = size; > wp.mode = UFFDIO_WRITEPROTECT_MODE_WP; > > if (ioctl(uffd, UFFDIO_WRITEPROTECT, &wp)) > @@ -137,21 +137,21 @@ int wp_init(void *lpBaseAddress, long dwRegionSize) > return 0; > } > > -int wp_free(void *lpBaseAddress, long dwRegionSize) > +int wp_free(void *addr, long size) > { > struct uffdio_register uffdio_register; > > - uffdio_register.range.start = (unsigned long)lpBaseAddress; > - uffdio_register.range.len = dwRegionSize; > + uffdio_register.range.start = (unsigned long)addr; > + uffdio_register.range.len = size; > uffdio_register.mode = UFFDIO_REGISTER_MODE_WP; > if (ioctl(uffd, UFFDIO_UNREGISTER, &uffdio_register.range)) > ksft_exit_fail_msg("ioctl unregister failure\n"); > return 0; > } > > -int wp_addr_range(void *lpBaseAddress, int dwRegionSize) > +int wp_addr_range(void *addr, int size) > { > - if (pagemap_ioctl(lpBaseAddress, dwRegionSize, NULL, 0, > + if (pagemap_ioctl(addr, size, NULL, 0, > PM_SCAN_WP_MATCHING | PM_SCAN_CHECK_WPASYNC, > 0, PAGE_IS_WRITTEN, 0, 0, PAGE_IS_WRITTEN) < 0) > ksft_exit_fail_msg("error %d %d %s\n", 1, errno, strerror(errno)); > -- > 2.51.0 > -- Sincerely yours, Mike.