From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7D43358391 for ; Wed, 11 Mar 2026 21:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773265818; cv=none; b=onq/KkXCS6JAD8wTUWXGJfgRc02WmMlk9Fsm5Cz/dB2fG/bUJXnKt6/JPZJem6dD0B047rLR4G0hnB/b2A2bAUu0EQ7Y3j36NIP4x/iP2gRLtgT82D5ShFZP+JNkNwJ1BHAY/d0DrSlG6x24v1TBwn0NF/+kSC01wBhgttntT+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773265818; c=relaxed/simple; bh=nUDluusk/uDGZ8oHjMwCbcwuRMtWi9qzMZ+YsH6si/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I7d6FCyXWixqbczNArUddFPA2fv+N6V/whfKST9zdvvZYRjepBEtyzh3GY7iB+w3t7OQx58zA9kih7JHv/hU3kt8zqUhQ1IVDhXAFVSq1YiVYa5VPULWoOKRWEpUQE5FYfi/jvLukX1l/nHUXjdzMIHhhsce1qaUuyvS/beGDAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TMsQnDPU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lhC2TzYF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TMsQnDPU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lhC2TzYF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773265815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iG1sK9K8o9dl9Vde3v0efNWoYZtYHoBdU4iIKqn1yc8=; b=TMsQnDPUXGkwszdX6a2qtL1a3wIiA7te+2ozQttn9u8bm4+G2hGGw1NHzuvRGtrAP7eC8C a93l3mGKh98gXIFLCU624yCNvweD9nhblTaECC2IxVQBvDbQiFSAsjFGywKcjImDJ4ipIs RIWXYfQzI1eazQrMyZZv5+fiW7tOU4A= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-fpPM8j_gN_OrvWq6KJUTRA-1; Wed, 11 Mar 2026 17:50:12 -0400 X-MC-Unique: fpPM8j_gN_OrvWq6KJUTRA-1 X-Mimecast-MFC-AGG-ID: fpPM8j_gN_OrvWq6KJUTRA_1773265812 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd773dd409so63382285a.1 for ; Wed, 11 Mar 2026 14:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773265812; x=1773870612; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iG1sK9K8o9dl9Vde3v0efNWoYZtYHoBdU4iIKqn1yc8=; b=lhC2TzYFzJa0Olv+maLTO7IHRURLGBtxyQwBS4Pe960fTXKOW4/6zqeXc2ITV5/o4k //jSoVsMnmxQ21SN1uwNwU3TXFDwkYNCrJ8A0YtXCKsh5e2K5jdvet11IToD1EzYPlX4 D75HwFnt+jlgD+exqsaaFkDynSlj6w+2Zo0oUC92JM+YkzL8Oyb2/nQDo6RZQFznmgu3 /9zrodZZL99umRlBKSLxL7MyAvfIx9koP4/4My7g/vUh70GiTVjQU7MVPTrOBY+3o+eB MbztcftD4uKcdW1BKc8/GW/Nd0weTKJWCCbljVb6R8nquPT/6UnTzUqhb3tw/FMWfqno Izjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773265812; x=1773870612; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iG1sK9K8o9dl9Vde3v0efNWoYZtYHoBdU4iIKqn1yc8=; b=rmEs3kDECAQsZsIHQQQuMQstxTQh0ZoPFjKILMYEQtfaa+Cx5gENGbOpIuqGTRR3pE E6cjX2E0kg9ebcH5hu/v8E1c4uKGLo3cwJKjHIrfjCpsz1Vwcr8LBLcCDHNQ/aJuCL93 kpUl6CbcokWFMRr6s35AzopAZRQRUqFEMXbv+Jow4CCJds7vruCQCs+wv1GZZ6uesvah /aUuUsgL5xp/kqMzyI1s5izXxpGkK5H8gux0ZhWtRTKNLKI3esDbjJlW5kKBtEIdcqRz GluABu0Lg670kHw0tjCIIAiTAM1ycCZniUhnYiC9hq3L1zmfMAvQ3EzC0sItx2OBvDNM rW7w== X-Forwarded-Encrypted: i=1; AJvYcCVqE/wUYR+cCewo99uTsx+VxOVC7LuJQ+8uh8vpCfIfqkJqb/THX95hINVB9PZB09IMIs/Q7LyXb4Z/N6Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9d60MLEmFEdE4VFTxdJGCPc2fmP2W0vS40D+6ITEhpb0NzR1h 8owKmT0T7Bj60pAb6UCfR5nCvjW9Do2oufuyNCFkzj0ns9lERwY5t3+50n+IqAZ9NTvkO5/R4U6 SnayiXj04nL8GCoFvqsmkeWjfOC7J8fjlFdKAmB/sqolZqECIbbu6s4bWpjxQobWMYQ== X-Gm-Gg: ATEYQzx80w1B6qZ+8budgoFOQ5XSxUJyipR2UIx9dXSVhTOhm7ORLLBHcniWlyM8Vef ApTGW918sir9SQWzgwmQL2+x6Rlwb7fPeBPmzy/SS85SyfCfi+Gtd4v5U2oQtnCm7GbeG3SbDqB Zv2RgUaw1w/bKAqBWcZGdN9VqMefALJsyhpsZa5eDVjsUTxlQvXtOXJTqVKdjbQoMp7KY3Xpbly aN6Hh29NpuIJA0w7dNmqUR7W/abAgNXuCo3K/ztiq80WByKxgL6NmuoEZWmQB2EwpIE6U35YJCP R4F5KTKap5lizdCWAUKdArSn71voawd4HUjlwyQDRvtdNuHcjUDvC3pUv+EbyYWIEGfHLTniOSc D8BLt8qd8fkoC2tWBUhw= X-Received: by 2002:a05:620a:44d1:b0:8cd:a071:9aae with SMTP id af79cd13be357-8cda1a8a3b2mr581380685a.78.1773265812361; Wed, 11 Mar 2026 14:50:12 -0700 (PDT) X-Received: by 2002:a05:620a:44d1:b0:8cd:a071:9aae with SMTP id af79cd13be357-8cda1a8a3b2mr581376885a.78.1773265811916; Wed, 11 Mar 2026 14:50:11 -0700 (PDT) Received: from redhat.com ([2600:382:7708:94f:6bbc:89e9:5b48:3a11]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cda1eab31dsm211687585a.0.2026.03.11.14.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 14:50:11 -0700 (PDT) Date: Wed, 11 Mar 2026 17:50:08 -0400 From: Brian Masney To: "Peng Fan (OSS)" Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Cristian Marussi , Sebin Francis , Sudeep Holla , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v8 4/6] clk: Add KUnit tests for assigned-clock-sscs Message-ID: References: <20260302-clk-ssc-v7-1-v8-0-2356443a7e4c@nxp.com> <20260302-clk-ssc-v7-1-v8-4-2356443a7e4c@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302-clk-ssc-v7-1-v8-4-2356443a7e4c@nxp.com> User-Agent: Mutt/2.2.14 (2025-02-20) Hi Peng, On Mon, Mar 02, 2026 at 11:01:18PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Spread spectrum configuration is part of clock frequency settings, > and its behavior can be validated similarly to assigned clock rates. > > Extend the existing KUnit tests for assigned-clock-rates to cover > assigned-clock-sscs by reusing the test framework. Add new test > device trees: > - kunit_clk_assigned_sscs_null.dtso > - kunit_clk_assigned_sscs_null_consumer.dtso > - kunit_clk_assigned_sscs_without.dtso > - kunit_clk_assigned_sscs_without_consumer.dtso > - kunit_clk_assigned_sscs_zero.dtso > - kunit_clk_assigned_sscs_zero_consumer.dtso > > These tests cover various invalid configurations of assigned-clock-sscs, > ensuring robustness and consistent error handling, similar to the coverage > provided for assigned-clock-rates. > > Co-developed-by: Brian Masney > Signed-off-by: Brian Masney > Reviewed-by: Sebin Francis > Signed-off-by: Peng Fan I'm collecting up patches for Stephen for a git pull. I wanted to include this series, however I see that the clk kunit tests fail. [17:34:44] ================= clk_assigned_sscs_skips ================= [17:34:44] [FAILED] provider missing assigned-clocks [17:34:44] # clk_assigned_sscs_skips: ASSERTION FAILED at drivers/clk/clk_test.c:3218 [17:34:44] Expected 0 == of_clk_set_defaults(consumer, false), but [17:34:44] of_clk_set_defaults(consumer, false) == -2 (0xfffffffffffffffe) [17:34:44] [FAILED] consumer missing assigned-clocks [17:34:44] [PASSED] provider assigned-clock-sscs of zero [17:34:44] [PASSED] consumer assigned-clock-sscs of zero [17:34:44] # clk_assigned_sscs_skips: ASSERTION FAILED at drivers/clk/clk_test.c:3194 [17:34:44] Expected 0 == of_clk_add_hw_provider_kunit(test, np, of_clk_hw_simple_get, &ctx->clk0.hw), but [17:34:44] of_clk_add_hw_provider_kunit(test, np, of_clk_hw_simple_get, &ctx->clk0.hw) == -2 (0xfffffffffffffffe) [17:34:44] [FAILED] provider assigned-clocks null phandle [17:34:44] # clk_assigned_sscs_skips: ASSERTION FAILED at drivers/clk/clk_test.c:3218 [17:34:44] Expected 0 == of_clk_set_defaults(consumer, false), but [17:34:44] of_clk_set_defaults(consumer, false) == -2 (0xfffffffffffffffe) [17:34:44] [FAILED] provider assigned-clocks null phandle [17:34:44] # clk_assigned_sscs_skips: ASSERTION FAILED at drivers/clk/clk_test.c:3194 [17:34:44] Expected 0 == of_clk_add_hw_provider_kunit(test, np, of_clk_hw_simple_get, &ctx->clk0.hw), but [17:34:44] of_clk_add_hw_provider_kunit(test, np, of_clk_hw_simple_get, &ctx->clk0.hw) == -2 (0xfffffffffffffffe) [17:34:44] # clk_assigned_sscs_skips: pass:2 fail:4 skip:0 total:6 [17:34:44] ============= [FAILED] clk_assigned_sscs_skips ============= [17:34:44] # module: clk_test [17:34:44] # clk_assigned_rates: pass:3 fail:1 skip:0 total:4 [17:34:44] # Totals: pass:16 fail:4 skip:0 total:20 [17:34:44] =============== [FAILED] clk_assigned_rates ================ Can you look into this? I didn't look in detail, but should the tests be updated to expect -ENOENT in some cases, such as 'consumer missing assigned-clocks'? Brian