From: Li Wang <liwang@redhat.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Muchun Song" <muchun.song@linux.dev>,
"Nhat Pham" <nphamcs@gmail.com>, "Tejun Heo" <tj@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>
Subject: Re: [PATCH 3/5] selftests/cgroup: use runtime page size for zswpin check
Date: Thu, 12 Mar 2026 10:35:12 +0800 [thread overview]
Message-ID: <abImYP8nhyzFE4VI@redhat.com> (raw)
In-Reply-To: <CAJD7tkavpHuBV0zy3mS00xpV09SEq6Tz_SaY60o+k_1=S3feFA@mail.gmail.com>
On Wed, Mar 11, 2026 at 11:56:38AM -0700, Yosry Ahmed wrote:
> On Wed, Mar 11, 2026 at 4:05 AM Li Wang <liwang@redhat.com> wrote:
> >
> > test_zswapin compares memory.stat:zswpin (counted in pages) against a
> > byte threshold converted with PAGE_SIZE. In cgroup selftests, PAGE_SIZE
> > is hardcoded to 4096, which makes the conversion wrong on systems with
> > non-4K base pages (e.g. 64K).
>
> This should be fixed in cgroup_util.h, but I see how that will be
> annoying as it's used to initialize a bunch of arrays. Looking a bit
> closer it seems like for most of these code paths it's really just a
> buffer size, not necessarily the system page size, so maybe we should
> just rename it?
Agree, maybe rename it to BUF_SIZE in anthoer seperate patch.
> For this patch, we actually need the system page size at runtime so
> this looks good:
>
> Reviewed-by: Yosry Ahmed <yosry@kernel.org>
Thanks!
--
Regards,
Li Wang
next prev parent reply other threads:[~2026-03-12 2:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 11:05 [PATCH 1/5] selftests/cgroup: detect and handle global zswap state in test_zswap Li Wang
2026-03-11 11:05 ` [PATCH 2/5] selftests/cgroup: avoid OOM in test_swapin_nozswap Li Wang
2026-03-11 18:50 ` Yosry Ahmed
2026-03-12 4:01 ` Li Wang
2026-03-12 17:09 ` Nhat Pham
2026-03-13 2:59 ` Li Wang
2026-03-11 11:05 ` [PATCH 3/5] selftests/cgroup: use runtime page size for zswpin check Li Wang
2026-03-11 18:56 ` Yosry Ahmed
2026-03-12 2:35 ` Li Wang [this message]
2026-03-11 11:05 ` [PATCH 4/5] selftest/cgroup: fix zswap test_no_invasive_cgroup_shrink on 64K pagesize system Li Wang
2026-03-11 19:01 ` Yosry Ahmed
2026-03-12 2:36 ` Li Wang
2026-03-11 11:05 ` [PATCH 5/5] selftest/cgroup: fix zswap attempt_writeback() " Li Wang
2026-03-11 18:58 ` Yosry Ahmed
2026-03-12 2:38 ` Li Wang
2026-03-11 13:20 ` [PATCH 1/5] selftests/cgroup: detect and handle global zswap state in test_zswap Michal Koutný
2026-03-11 18:41 ` Yosry Ahmed
2026-03-11 18:47 ` Yosry Ahmed
2026-03-12 1:41 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abImYP8nhyzFE4VI@redhat.com \
--to=liwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox