From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4048375AB9 for ; Thu, 12 Mar 2026 02:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773282922; cv=none; b=pl8Wfe+whmfUOF73GsEbF5GmFzmORJPBNCEvSgZUFh01kBQILseEa0FKu8XKbbSjOv1bkgkpzsABhNPVSDx+0ITXBwbl6Jn+NMDIOODJGJ4THM/S+4GH56au1nxfq9iZG+LlbHUlFW/iqLakiOHium3xQlSBCy2OqNMG+jH6xEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773282922; c=relaxed/simple; bh=r86YxBWwjO+ktjDFFhuuKmR6FJNmyO6rdwnUxtDS58E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G5Zy5cyeUoIcM4GzVhv4xcLkpOO9EgWIJLA4hVToybchFL9UFG7jx9PPwuG1Mz2vjcEsTQPAe8z2Hi7rYUnory/5qU1I20LJpdmgk6xod7HLt0MG7LGq3ovthrKZzl9D1N2ZfcISedtYBVwamgJSHxmJ7jMOPkcjt6iyN41F7fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EQSMJfnh; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=j6Dk5noj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EQSMJfnh"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="j6Dk5noj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773282919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1OS/SC+gPtS89eoPebOmFMRSactrSzl1taYeA7a3Y8s=; b=EQSMJfnhnB6Sg7Bzc7xOa6h2R40t0shBIH/nzayGYG9uk14yA/Z2sl6UiUoKG3kx19gDJI 0yAIotp/qwkfwaDSjdew60rr2gvTRtjAwKJk4F/eeCwTE+QW0UYJr+bPGKGE2v/wb6roL7 Ohs5lfsG76o+EkmxEzoEHiHhbVDcB8o= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-GTYd7AlLOFOOXjow0ZFqcQ-1; Wed, 11 Mar 2026 22:35:17 -0400 X-MC-Unique: GTYd7AlLOFOOXjow0ZFqcQ-1 X-Mimecast-MFC-AGG-ID: GTYd7AlLOFOOXjow0ZFqcQ_1773282916 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35678f99c6eso431079a91.1 for ; Wed, 11 Mar 2026 19:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773282916; x=1773887716; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1OS/SC+gPtS89eoPebOmFMRSactrSzl1taYeA7a3Y8s=; b=j6Dk5nojELr2LKvNG2bQHVmqE94dwHnthuNjWDS6aYGEAY54GFCZRkHY54mY7gFnIp DL5CkhhV+penLk42clgiQ5eWZIEVrmIChM9WIyvMShtZdhyIc5trsTaQn4+i4gFNnOcA DlYgRACnJy/V3mHE8YhEaHapn3XQoHwSIiAJvNrLyyXUBzzYYvrgeaH78aevcSxtRuqA PAlpEYYy0Ws91qE5txXBjou5aHOCDXT1HLiCkaJbWorPcNMbDLF7shEFg4beOOnTYnbP Q0DEbwILzjen8I7P3BhDPH0PlL8e5szZul4AKHVDFjLo6Ae3DhlnUmQ5HvbqWiVj7aJg GBUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773282916; x=1773887716; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1OS/SC+gPtS89eoPebOmFMRSactrSzl1taYeA7a3Y8s=; b=ozjwp1ktnxGegBAyI1RtqtHWuKssxKiRqfaiQHF3o+MmoWUlsERo/DBeoOw7loNq98 Mc2J8tvzxjXUYuuWgiOH6ReyfLsyaLNkN+jmQoZfp8V15JwTgXx35QLZIPzQCKyks+JT hxfCd9oNoCMe0p/ziriLcdrhc3Qw1WNzIK3F/Zoj5QeuUD6TQxIUxiEcSvvRpufTcGAd LR7KAM3qqKVl9zQ2MNCtoPE9jQJH0z3yM5zokxAJAYKbpFLSgAK1g9OHkbJo+bIt4/sD ijzGdANn/ppqleI8XFJvpeo2a4s0D050RXwqt0h8FDJQ787iz4W8r9IKKpqQ7uUeuiNJ sjCQ== X-Forwarded-Encrypted: i=1; AJvYcCXZ7J96TMszNrjSAA9RQMFDn1DEYeDSg2jOpZuJKch7GPtHJY7x8RilXx4sCXyzcDNhg7rvHdizSwStlc0=@vger.kernel.org X-Gm-Message-State: AOJu0YzunP+2fbEOlWdE8h4IV1gaC4zBj9fZ2Aew5pjn+0vXlbE9CRZC CZKv5vx9/L6+Q2RYIoTkl4b8aMe9o1vIqJd71gRCKh6Dr7FvI4JbdhQn89lp/Zt/d4xjhLtwg0z pGNJZsk1enP8oNCAV07si6gR8xxg9eAnaa4lZCoE50B4B4liZAALXROnQe0WoUFG5IA== X-Gm-Gg: ATEYQzwggETT4LeoYOEznz91iDl8QArKDJYJ7U2fPwgVTWivzBKG8M8ivH4p/hL0Biy h1NJU0YbIWbMRap0zJBmHsq5TwzaCBdColR5Exi+cprSnz1KZOvtVOrq4ihXCNjY+2V0rE7xw/s UPw8uPMmW80DwxKK29TW/dh6D7bJIcPJAl/67TI6g0hdnm3E1/s1xqeiVRMN8mT6H43KTDQgigu 8BHEdXs7524RTeGxBHdyGittC4DO/DU5ByIBuTRj89qsBlsHqqQJ7Lv4CdTvLIdLZsT6PwwVKY6 jk0rhPHE2oNnTXg423Z5B05ifoR7sxal5egfvQREczpVSGx9gTTVOy6M9AEE7ctB1pLAwyhsBF3 tILI6ofzIYFw+jAUzcA== X-Received: by 2002:a17:90b:4a47:b0:359:ff8a:ee55 with SMTP id 98e67ed59e1d1-35a01287083mr4289361a91.14.1773282916238; Wed, 11 Mar 2026 19:35:16 -0700 (PDT) X-Received: by 2002:a17:90b:4a47:b0:359:ff8a:ee55 with SMTP id 98e67ed59e1d1-35a01287083mr4289326a91.14.1773282915815; Wed, 11 Mar 2026 19:35:15 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359f088e4b0sm7464888a91.10.2026.03.11.19.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 19:35:15 -0700 (PDT) Date: Thu, 12 Mar 2026 10:35:12 +0800 From: Li Wang To: Yosry Ahmed Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Johannes Weiner , Michal Hocko , Michal =?utf-8?Q?Koutn=C3=BD?= , Muchun Song , Nhat Pham , Tejun Heo , Roman Gushchin , Shakeel Butt Subject: Re: [PATCH 3/5] selftests/cgroup: use runtime page size for zswpin check Message-ID: References: <20260311110523.26624-1-liwang@redhat.com> <20260311110523.26624-3-liwang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 11, 2026 at 11:56:38AM -0700, Yosry Ahmed wrote: > On Wed, Mar 11, 2026 at 4:05 AM Li Wang wrote: > > > > test_zswapin compares memory.stat:zswpin (counted in pages) against a > > byte threshold converted with PAGE_SIZE. In cgroup selftests, PAGE_SIZE > > is hardcoded to 4096, which makes the conversion wrong on systems with > > non-4K base pages (e.g. 64K). > > This should be fixed in cgroup_util.h, but I see how that will be > annoying as it's used to initialize a bunch of arrays. Looking a bit > closer it seems like for most of these code paths it's really just a > buffer size, not necessarily the system page size, so maybe we should > just rename it? Agree, maybe rename it to BUF_SIZE in anthoer seperate patch. > For this patch, we actually need the system page size at runtime so > this looks good: > > Reviewed-by: Yosry Ahmed Thanks! -- Regards, Li Wang