From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F4D23921FD for ; Thu, 12 Mar 2026 11:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773313937; cv=none; b=b9k0sSvLU881JXs5TNVXzXqaTObETu6FkbxkBk+Rlmvv1QNIKEeAdvZ0mzcc7K/BxwELvuFckA34S2JcTO16SdNzy9Sk8BHTcYbXYkZXe5fDiNHtuOudNJt+uiyfZXV2WzeEbeVSpIxdcYKRjKRZ7M6pWf7tfvUF9DK+eTUAl8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773313937; c=relaxed/simple; bh=ZJCDw3crM5A9QTWYBIpEJQUjnOrnzMaCENfSt76XRf8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TyNdftj16xHixRHRkaXD+/kt9TH4euuk1DVgVYnPbEx+f6TH7rWE8BRtXUEQ0OeBd/yZM6FuVWnpiePNwrrRhaD64EEFeO756CweGrognEQTSDYJFgjM2q/rQ+YAE8ZMcjDzPMGJpF4eBbTggv3YYnX5X9vy/1LhVcxZ8e/ZlQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=PjN9deAv; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="PjN9deAv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f6AcXBztT5Sj+QpF3YNwZU4UQU3fnhpf/t4o8/38YWo=; b=PjN9deAvJ2jmYwchkDw9K/1IDW RDvBjTzu2dy1mbJuwxKv0HZQrtfZqSFEAu7HYwU1mPcbgs1Wy7Sz7jhOgXg/EldB7YZywQi9qnXBc gI9pj6E37zd5K2g9bkLCwgqwgL2IJQun2hk81vcF3+5Q6BY9r3yF4wjhMUbg93ciB906m6k2FYfqX ilqbWKGK0kkd8/YZlNworwuz+HryM6l5ooq5hK9DH4Niqo5d+5WOP7RxHnrhbUlca8vVw6fPFcHCO B+Tk1y5dMsoGlCWft/JjWbKDsv0I3LJcESQXWtslE5bwDRZ3Zmo5IuBSNKcFQx3qk4dxtx52mZf2p LRQeitOw==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w0dxO-004VL3-S2; Thu, 12 Mar 2026 11:11:59 +0000 Date: Thu, 12 Mar 2026 04:11:54 -0700 From: Breno Leitao To: Mike Rapoport Cc: Alexander Graf , Pasha Tatashin , Pratyush Yadav , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, usamaarif642@gmail.com, SeongJae Park , kernel-team@meta.com Subject: Re: [PATCH v8 4/6] kho: fix kho_in_debugfs_init() to handle non-FDT blobs Message-ID: References: <20260309-kho-v8-0-c3abcf4ac750@debian.org> <20260309-kho-v8-4-c3abcf4ac750@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Debian-User: leitao Hello Mike, On Tue, Mar 10, 2026 at 12:36:40PM +0200, Mike Rapoport wrote: > On Mon, Mar 09, 2026 at 06:41:47AM -0700, Breno Leitao wrote: > > kho_in_debugfs_init() has two problems when displaying incoming > > sub-blobs in debugfs: > > > > 1. It uses the hardcoded property name "fdt" instead of > > KHO_SUB_TREE_PROP_NAME ("preserved-data"), so it never finds > > subtrees stored by the current kho_add_subtree(). > > > > 2. It calls fdt_totalsize() to determine blob sizes, which assumes > > all blobs are FDTs. This breaks for non-FDT blobs like struct > > kho_kexec_metadata. > > > > Fix both issues by using KHO_SUB_TREE_PROP_NAME to find subtrees > > and reading the "blob-size" property from the FDT (persisted by > > kho_add_subtree()) instead of calling fdt_totalsize(). > > > > Signed-off-by: Breno Leitao > > Reviewed-by: Mike Rapoport (Microsoft) Thank you for the review. As this is my first contribution to KHO, could you please let me know which tree these patches typically go through? Thanks, --breno