From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5794534DCD9 for ; Thu, 12 Mar 2026 14:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773325080; cv=none; b=VY8D5UWhR2bPgScw9jTC60Zd83hmHANpENIRvN3ZfhYLfAqZb/L3fiHYz5arLWaAOm0wwi0c/dfPZHw2hnGTepUY9rv8WyC09h57vE+cigbnRDsUPy+DuZ26KWFjHt3lXuWS6exO8Tvm34FC1JoAs7/BfGiA9DLebR794/tWY64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773325080; c=relaxed/simple; bh=+AEg1lwP2y/d3m63C4HIgm8EdzOSkr7DFi8Ib3goPBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FyE4DNF1s8kzvXueD6YuG27so3nI9v743C2jGZWYZwMZAqr/SEmsxurjCkz0vWPSNFTv+pgA7YKdajowjMk2tDQYgyLF1gJx3gBeIWLQsszsPAM3tS6c5TDcUqcajsxwPyveHh4aGRpwOFBECy/gSl3DL5S1kCAEx6OCdq/lAlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=I/PadtYo; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="I/PadtYo" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439c56e822eso1111708f8f.2 for ; Thu, 12 Mar 2026 07:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773325078; x=1773929878; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UTHRpT+2ecEy1LvHXfmTIFLuh5MrajO6t8cGQSlY+6U=; b=I/PadtYonaRVkEk2d4AA3/CrKYH3WkWFq7CPtGgQWyt67z0bt4vqAc8Vxz1x5E0wXe eKlhFmCkEV3cKcQPnAmEauR63K0w68jnL5LAIrxTM4lKyWuLzqphI2HNjh1rNp5sTqga ldAhLwJjFv0RD4mC3Ux5R4bKTFqPx0r9oX0+/KN5pKqlEn2EXYjDQs6YerYm+N+GYAhN hVI9PClu26z0v49x7EA6c+4z8j9PCQjkigzVLO/QQ8zaSaifjh7ql25uTNHb7GFkqnPl UpSQHoMku+gYNK/a7heCcGw3p1q74ewzT7zqXfJNLHdoLewpNco44dRfE0wyom1O0mWv zltw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773325078; x=1773929878; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UTHRpT+2ecEy1LvHXfmTIFLuh5MrajO6t8cGQSlY+6U=; b=F/NLKzPPDDvo4u8hTvXj/rwojK+Fc/CPEFdkUIMDKYGOWUTs3VcqqjsBB+RD5EqHXq jNu1xdZe+USM8pHYn8vJ6WxI3INxTwTqIpkuZ+BwFNi1JN1SigmTYtsTv5tYnHcFr41l mzTR2XPFQHnviw9sDNtZWT042akH3/WNd6dw2tvwJhXBI5rr9mDh+MNuv4zXJcELQKjI ddfXDXN+22FSM0uSB5UoG/+XBjYoMkVvm+X57VcDiZqfVaQdS4gzQPav3Fd+XZTkYenV txAsPmtspIb9Ah8M6o7W90kAXDhlFuJkH9vaNH/DZT59oKIGXBUUmrF7vYkSYRDLQt9i CBBA== X-Forwarded-Encrypted: i=1; AJvYcCVE99y5sAMVQ4KjLgrymvxWZVSjtPzhHn1v05Wo4nzbBvx0+vexnRETchzVo58m81jfkhYbG2gt8rWFayY=@vger.kernel.org X-Gm-Message-State: AOJu0YzW6H4JYeNWrSwjo1ZGO5vFIDnPkmsYXbwgQK599xox6oJBlxgT SLLhN7hJVMSSFnoEL4ZFh0YJYYWiJ+VV7e85E+El7v4X5Kb226wRVq1qlwVnqQ5Q6eQ= X-Gm-Gg: ATEYQzzMCoCvQEiSnm4iMhQcxIDsnP0E+xqlvNRN726NDr9esv4FrWCdvg1sTOHwAwB iS3MB6kWYnYne6VTt8teRCrETuWBZAb5wWUDkEjslYiZTVTX3YB1+CfGSDEbOBTr8DLRvuf5gGo UdA6iY0hTSmLm2kLNNuOFQRrdgpNqTGtVVTTkNOsiKskwz5B9MBz4uS5ZxvbLEbuuY4R2Xw0vES XkmQiYX1GcufRPagN7Ht9IyGMF29xsoiA2zKx9eUNLuugxyBgDH2KOs4OMYjs7fH6sf/rrh1iir MeS816yT+NnvSFOFjCQsgsSZ+4QQb7LSwa7/5k+Bu64YiIRTZrQaqiIxdZRy0AYYV0t0ZMk27r5 pKm+Y/x1M5sxarQMoKnerccc6/C7bQVgui/JKA5tMu3wcvEeqTC2+AM575VyHGm48WiTvBUSxY2 8Mb8a5VLj5Tb+oRcF35Iw4Yzl4Ig== X-Received: by 2002:a5d:5e01:0:b0:439:cbcb:5723 with SMTP id ffacd0b85a97d-439f821deccmr12435619f8f.42.1773325077594; Thu, 12 Mar 2026 07:17:57 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bbb2sm8366927f8f.22.2026.03.12.07.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 07:17:57 -0700 (PDT) Date: Thu, 12 Mar 2026 15:17:54 +0100 From: Petr Mladek To: Steven Rostedt Cc: Richard Weinberger , John Ogness , linux-kernel , bhe , sourabhjain , Andrew Morton , senozhatsky , Greg Kroah-Hartman , upstream+linux Subject: Re: [PATCH] ksysfs: Expose hardware name Message-ID: References: <20260223133448.411343-1-richard@nod.at> <87cy1va7k6.fsf@jogness.linutronix.de> <40046959.4372.1771856422459.JavaMail.zimbra@nod.at> <20260225040059.5a857a80@fedora> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260225040059.5a857a80@fedora> On Wed 2026-02-25 04:00:59, Steven Rostedt wrote: > On Mon, 23 Feb 2026 15:20:22 +0100 (CET) > Richard Weinberger wrote: > > > ----- Ursprüngliche Mail ----- > > > Von: "John Ogness" > > > An: "richard" , "linux-kernel" > > > > > > It seems a bit odd to make this a dependency of CONFIG_PRINTK. Perhaps > > > @dump_stack_arch_desc_str and dump_stack_set_arch_desc() should move out > > > of lib/dump_stack.c if this new sysfs attribute is accepted? > > > > Sure. I was surprised too that lib/dump_stack.c depends on CONFIG_PRINTK. > > > > Or possibly we should make dump_stack.c not depend on CONFIG_PRINTK. > I'm guessing that it was done that way because it expects to dump the > stack to the console? My guess is that dump_stack.c depends on CONFIG_PRINTK because the stack is stored using printk(). Nothing is stored when printk() is a NOP ;-) A clean solution would be to move dump_stack_arch_desc_str and dump_stack_set_arch_desc() somewhere else (ksysfs.c ?) and rename them to hardware_name and set_hardware_name(). Best Regards, Petr