From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72109345757 for ; Thu, 12 Mar 2026 18:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773341111; cv=none; b=VO3XY/f6hwR3uMZW75nrHyl+kJ0Q6iYcyYqbSpDPx8SXMz61GAcsRz+/9YJMDAoupeIA/eGMiB6dJ28ZPJlX2ATzWBi0SzyenzzLdzerzY46x77c2c5K5HejTidxd2vSu+nmWmU5SBxUMW0AZTd+WEqEsJ8GXTb08V/wpVQQoi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773341111; c=relaxed/simple; bh=T2PNtnO1Hd4N/Spt17D5qab6uby1WVby1JOo1VWQvyU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QxJLBGXTFmvEZaPxVNNrUrZSt8eKq+ZfsNHWIdc+qIoCqpbjOshJvBN7A/qF2n51hpnatzWiogPD7svhiy4FDl4bPnt+3DQMG/t0CKPgmhpJqciki4rcb5rn3gQQzacMpw48S6i07u4tKSCm/RMGmUzx0GLb89JVNTN82fA4kds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UhmWY20+; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UhmWY20+" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2a871daa98fso10849405ad.1 for ; Thu, 12 Mar 2026 11:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773341110; x=1773945910; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sFJtbHiIPHYN7z4aj/uef3SDbnRhOt2FSyOQIkrlI8Q=; b=UhmWY20+SdE89J60hV8cySap7M0ElfIZHv2SbSnkNPBX+D6x9mAKn1FE3x8n3bsd92 GoYLYLLxJ3KszhM/XBBYR+dzvpE9yKwlaqr/6y49hBUfNFANeBiddxx1erLZlj42jiBO c0734VVcOmN+Y7wogmSmEx1iJtt08vYXt6kM5vsCLwFS77RkwYWyMe/DJ3rIfwKlC6yd f35fEA+UVFiIi2pqvwb0gO4eIDk7k0pNGR7vpPmeOzEySq6ROHQDKzL/+oOP0uIcSQss Q/kfKEM4i4mTcOYmC8KaxptPT95/HoUPaVypRu9WqhwhvUd9nsEO0ZyroqSnRntfz3zO 4how== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773341110; x=1773945910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sFJtbHiIPHYN7z4aj/uef3SDbnRhOt2FSyOQIkrlI8Q=; b=dD/zd6Yhdynd911bZ9CoiE2wBujrGV7iKBINBenaEKkGf5VcI9pF75sLfw8DKtByc1 n2YIBxyG28lC33UAvspyUDol28zoeHVpNbPAM9iLKo/fnFXY7G4HdmgpUh692yBHCoeP NU+HAGq7gbIHFt3zhuDi6rU6U1BHj7Bhl0XUyOBFQUX5OBmtSW2zlv6qufY91neqK+XM eRhavoMeEXLUglY7nw1YgKHVhVG8HEXLEBQMu4biYoy4S3MVH1YES/a+Clpc/czSj9zb mZJkNipQQ+2x4xyLowLIBEkdS2IGK7n9CsLYTPn3b0vDX+Kb3UYc10HV1uNWck07K1EQ 6LMA== X-Forwarded-Encrypted: i=1; AJvYcCWaOGpbbfag9+24wvi1+Zrxk67qdPvianQ3vR0QEJbVM0cLcWlNdEOyoVwR08/0AqEsc5vptfyT2cPMHV0=@vger.kernel.org X-Gm-Message-State: AOJu0YzX17vt+PLP4KOa0TqxVtWRecU5aPKLL2MQYfWbcr4bMgpqfUJ6 OOAv7zQGHAecK0MM/kNRDBY9VVPguHQByLE1mfQpN0eZj9La+s7vN21D X-Gm-Gg: ATEYQzzgtdc7QES7UHGgFR96W0bNZ4LCjUTu/WXXPWpcDWtTV4q0aAHf7tZZhKiDaT3 GWnwPIl96pEfMd579B4GNoFplcDzJfMqtKdXsUB9sXLLByh5R9J2hHgmgdlbJ0LhpLLDydVNuM8 EEO+HrOa8QyWBIQ3m7RiQ0PhEX+HcKGeeX1TjxPShhwIEVEGqzytOJGlzeZuRH7VHn3jp/OePhH BDMVRJ0A1JaPKgy0RTEbVWkWGAJXC93OgQBKIsmYksyZHVC3VeYjObWNKhfH90R0iIniH8oYKMZ MO59Df9JAcS5NY5RslcGXI8sMhGFc06LLog1VG8VpRhV9aSPlhbyB4ks9kORFa28AfoMnxfOaGM vDg4xy/pJkaStuNcbNHyeCZNfhea0UOeiPUGfTgDGG6GVUfoNoMPBzwa2Q9WqLTaKzcHG8wj/Jo tXoxmkkIh8nHNozB3n8yrOnhUz6xkJMfJ02j1YgenChXSsP8QhMyco6iw+x50X X-Received: by 2002:a17:902:d58e:b0:2ae:4732:2859 with SMTP id d9443c01a7336-2aeca9bb13dmr4301835ad.3.1773341109758; Thu, 12 Mar 2026 11:45:09 -0700 (PDT) Received: from eric-acer (36-225-72-126.dynamic-ip.hinet.net. [36.225.72.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae34cc49sm64519825ad.52.2026.03.12.11.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 11:45:09 -0700 (PDT) Date: Fri, 13 Mar 2026 02:45:05 +0800 From: Cheng-Yang Chou To: John Hubbard Cc: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Gary Guo , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw Subject: Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention Message-ID: References: <20260310062443.2763230-1-yphbchou0911@gmail.com> <99af9d88-05a0-4dcd-85f4-9d5fe9ee6744@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99af9d88-05a0-4dcd-85f4-9d5fe9ee6744@nvidia.com> Hi John, On Tue, Mar 10, 2026 at 06:34:51PM -0700, John Hubbard wrote: > On 3/9/26 11:24 PM, Cheng-Yang Chou wrote: > > - name: c"nova", > > + name: c"nova-drm", > > desc: c"Nvidia Graphics", > > hmm, as long as we are fooling around with names here, I see that > this should be "NVIDIA Graphics and Compute", really. > > Obviously that can be done separately, though. Ok. > > > }; > > > > -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore"; > > +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core"; > > const AUXILIARY_NAME: &CStr = c"nova-drm"; > > > > kernel::auxiliary_device_table!( > > diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs > > index 8893e58ee0db..1fd454c7e0df 100644 > > --- a/drivers/gpu/drm/nova/nova.rs > > +++ b/drivers/gpu/drm/nova/nova.rs > > @@ -10,7 +10,7 @@ > > > > kernel::module_auxiliary_driver! { > > type: NovaDriver, > > - name: "Nova", > > + name: "nova-drm", > > Well, but now it is out of sync with the file name: nova.rs. > > You should change both, or neither, I'm thinking. I think renaming the file to nova_drm.rs would better reflect the driver's identity now that the module name is nova-drm, making it easier for readers to associate the source file with the driver. Would that work for you? -- Thanks, Cheng-Yang