From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A6A36308B for ; Thu, 12 Mar 2026 18:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773341972; cv=none; b=Dr9cQv4dh8tfZi/7R1xbCvyJ+5u8ur1XJ4JV9ud5bB38z75LyDhAknkUiwMU4P/XACQxze8DXqpfHwG0sIzxQ3dBHyhtjcV7JeVrOESUrPkO47GbPFG3wDOyoxbHsHSIczrpKKz0fPDQDEt3dvmURePm9yI9D3OIjQ6+P2KUobM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773341972; c=relaxed/simple; bh=RNFcj8p4rfxZ5TQh5zmhAbH49h/ztzhjJPZI9q3ZKRY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V0XMck8WqXnSaEJuCjS4Rx32UcqCQIGJX+XO+wbGBNMTuNV0Tvlcp3jtvmUdwoQ+k65sw2LWANhTIJWe1Vg6gju6qxx25+vXNQ0z4bYvF0UYW4ihpEbIK9eoRbydVudM79gjID5wnYBuTKAqcKIyWPuvVpSRHH3rKDcKiuqtH28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1EpyhPgj; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1EpyhPgj" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2aeab6ff148so14665ad.1 for ; Thu, 12 Mar 2026 11:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1773341970; x=1773946770; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fJ5QcrI8geh7d6absK8WvXfu7trgVMmlccvVoh70ilQ=; b=1EpyhPgjGxHPv2xorHiTe8O5gF0STNI3kZMYsZvHGt1I5/Jk3W359SaoBe0evvLo0R bRdtRdgQu7yTlsYxSljdBP5wBqFkqXMc5lCwL4VgMscdd3eks47R5UTMxYVVJbaJAitx jAMA4E4Q/OnG5jzu2RnbGNdFZMxRstwjq9TpoYRBH6R0nChLu0auUAb98CXT1A4STs2N 9ZfrL5c0J10zzOJyCvGhg32YlQa8rprES7bJZbuhp+ZySS9ZZlerqVHRDGoWBzHAtzjG Jgrgd/+6Z7mlrxyxJwVK8RRg7UPwMCVpQ1glroZGeF59iCj3xmVxaoZJadyBrltcSXEM s8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773341970; x=1773946770; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fJ5QcrI8geh7d6absK8WvXfu7trgVMmlccvVoh70ilQ=; b=h7CVov0kokTZcnVLR5lId1S0Cvo1pzytsc0oTpQr6URjtqDSEOxW15tinmXW5E6TXb GhnYAItxloYhE1RPBXBnGT0YFuhklPsrpirFRWSmyynNActsBRp35bYJ6qG1hWBFc0L/ ZHiV5B6XJqqkmDlIFLdbBCcM0e2p1a+sVT1LMPguQIvs17/jsc4SbdFcorFzhzo8vjDY q0VWL/gudwhyTpZg0Bv+FYlW7q8P/WV6wXe1zYC6rREbV+ntxqeIEybqGlQGDwElRXbj OHziQ82nOlOJlsKuUi6VNgaFhf3dCCHaB/5vWG8U2M6qVTrxRaP+c+LCMRjIal+fDX3O sJaQ== X-Forwarded-Encrypted: i=1; AJvYcCU8S7LXZXCtYRCgfWWqlzUL7OiS37Zd+3LkLHOm6r8fONDzdx9BSyV7RgiPi9wpX/dnuiSgVZLUwWxYFuA=@vger.kernel.org X-Gm-Message-State: AOJu0YwW0G4Ac+dBautxxYbQxUjU5MShYkHiL3aklBc+QhjSiJB8J7w7 80ZY8P0E3ZIx41Kqz3Y6C1AD3/RuF3PJb69Jzb+ZO1w034T7nFGkzmyVBXoVzE0pow== X-Gm-Gg: ATEYQzwTED0Yr7gF8/EFc4sgVKAu1TCZMxVEm4RZ3g5KiK2wqilmuMfBv3HHXi5Zoet AiIbhKlBycOSkVP4lxxxITDHt1U2Zr3GQmtaixB1TangIFvO0K8N4LqJ/1G+UquXgBviT3OQM3Z AwFmGtUIfvO23J4Zx0frwIuDoVuE3f8UTJlFxDZTcwSQKUhx/PzhAKmJsCjktZ0u81L57pbFvjp 5kG/7yXQ21+z7C/za72rxc/9eAJKKIWNQfq1Iryto9osJP6Cwp15VenSRaJ8tHrhYhhdMLzFio/ m28Sy3hND6uB/ETsZY44EK7mZ39R2aP54fu1tV2PKVg6F8xV5JIxtF7FdTQkRFEPIgWw6Kn2/ES ZghBuSHKvOtlSO/xjMHHurQuNA7sN+mmlBHVXG6tJJBLnVqnegVLO95lm4qlRJ/DFMOouskPPjN 8113cHCqRm+3CtVF3MJnAUSo/LNN7hiTwxGtCRfmEt7jPwPBaU5ZEnGQWCzA== X-Received: by 2002:a17:902:db0b:b0:2a9:5ef5:399b with SMTP id d9443c01a7336-2aecb83b96emr407445ad.19.1773341969932; Thu, 12 Mar 2026 11:59:29 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae361326sm60888155ad.70.2026.03.12.11.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 11:59:29 -0700 (PDT) Date: Thu, 12 Mar 2026 18:59:24 +0000 From: Pranjal Shrivastava To: Thorsten Blum Cc: Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Nicolin Chen , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommufd/selftest: Fix page leaks in mock_viommu_{init,destroy} Message-ID: References: <20260312164040.457293-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312164040.457293-3-thorsten.blum@linux.dev> On Thu, Mar 12, 2026 at 05:40:42PM +0100, Thorsten Blum wrote: > mock_viommu_init() allocates two pages using __get_free_pages(..., 1), > but its error path and mock_viommu_destroy() only release the first page > using free_page(), leaking the second page. Use free_pages() with the > matching order instead to avoid any page leaks. > > Fixes: 80478a2b450e ("iommufd/selftest: Add coverage for the new mmap interface") > Signed-off-by: Thorsten Blum Thanks for the fix. We indeed allocate two pages but free only the first one. I guess we missed that earlier. Reviewed-by: Pranjal Shrivastava > --- > drivers/iommu/iommufd/selftest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/iommufd/selftest.c b/drivers/iommu/iommufd/selftest.c > index 7823142097d4..83e2215e7800 100644 > --- a/drivers/iommu/iommufd/selftest.c > +++ b/drivers/iommu/iommufd/selftest.c > @@ -636,7 +636,7 @@ static void mock_viommu_destroy(struct iommufd_viommu *viommu) > if (mock_viommu->mmap_offset) > iommufd_viommu_destroy_mmap(&mock_viommu->core, > mock_viommu->mmap_offset); > - free_page((unsigned long)mock_viommu->page); > + free_pages((unsigned long)mock_viommu->page, 1); > mutex_destroy(&mock_viommu->queue_mutex); > > /* iommufd core frees mock_viommu and viommu */ > @@ -870,7 +870,7 @@ static int mock_viommu_init(struct iommufd_viommu *viommu, > iommufd_viommu_destroy_mmap(&mock_viommu->core, > mock_viommu->mmap_offset); > err_free_page: > - free_page((unsigned long)mock_viommu->page); > + free_pages((unsigned long)mock_viommu->page, 1); > return rc; > } >