From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74D3B3909AE for ; Thu, 12 Mar 2026 19:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773345331; cv=none; b=peaqkBADWZEQoCPBHqVHu5OZxmMBIrXttkomQKWcFAVDdjxuIj94tJfZiHpbSZlF7JEmaa7Dg0WD+TK4rb4EWHnccbplgZduu0If0Gcjy7CMYtl1V1nWalK/3ZQh5AwDOqGyB+tBA19bnn8q5prLReyETLt/UD3IOVSB1C0/dwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773345331; c=relaxed/simple; bh=xJZ5W+Tlnl5u86g7EdYowItOjUuecQm5CqUYrR7edVE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Vevyf55d2sR7LRJnFaGK8sXkfLWkXBCtLxFXedJTLgs+6KJAANwPuhGaLHejSidQ1jOKiwXgmfAdn5YOeSdu9rO5cVqCupgRFfpAplCj+53CEHIWxKlTjbxkdv82IYOjWBl55Blg/+sIYaYGg7pUElEZFMtsiC+BxOIK5SfjLl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=mKpp9UA+; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mKpp9UA+" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-35a0613f9bcso7608315a91.3 for ; Thu, 12 Mar 2026 12:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1773345330; x=1773950130; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hrjSa5sH7XQL3da3DJB6S0oC3QqGZXkp52qJDNxbE6Q=; b=mKpp9UA+Z1WXRQEo2fLz3qXIg4GodO/HbjY0Rb6yrj1p/IelbGr2NgECZSljFhNU9P r+e9+ik9FBRWTnxbQX3hr5qQCIAPcZnTMxhfxD8pnBXtx/e9NZuv32FTezb5Ypx7DdVS aXNcJDpFqVvIUyANBS26IPmMHNg9Omds3VbFxj//J2oT45MOM2wmOXsCRS0ig3nCLA9b aHK8pk3GrcXYD8pnsv/TX32mzEi9Z8O3h1rg2tZfBTWaMNQwcmqvx+NxtwSiloLdD+Vv vQRHYeCrhnyhEs9pWvGcvWnWczMcoNaJXJVo1FJSm11iuVfzqmrVLklPuqmuVhHwdnxD 8v0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773345330; x=1773950130; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hrjSa5sH7XQL3da3DJB6S0oC3QqGZXkp52qJDNxbE6Q=; b=mNrAGXVwjGZEx8hjd66/R/IXcXxTzBaDjSyyc2kw8XH8bW6/PWrWnGKKTxMjgA7yMn TUqU8TmRZBgMtZMLhmoXRMNDsW528kZZQBMjGEYa4v3ZtFKs31MmwK2x+bewmzijh8yu 1xm5P73jwgM+1i/XCamVYFzYinoqD3+lcXyABFWJX4pIuMdHvZTr0iJIZ3BNYyEoGG2l XyN7cGn6dcV1c5ZhP6owxaYDshEXgeXONAZs4F2Ja0eI4gTrRi0IAenaqH2C8t1Q+ndu qzKgfcgXMKFNxbvdu4t1bpeJP0BdLOSt4Jr2r57hBY2cDyMw7CQ5fJkSPWnQfwdeftiR DQpg== X-Forwarded-Encrypted: i=1; AJvYcCVpIxuFasvjBrRV0IIva23419B4m3f/BhN3y3TEqkRKveJkLuTJEfh5e21QkO2yu55VQRgHI8y1zd5IUIA=@vger.kernel.org X-Gm-Message-State: AOJu0Yym5m3bT/kzwXcIOzrvxfhXKI+l2zJVxs208Oqc6/3LWAUcochA N/Sd2bhm/HD6ywGWj7S/P493LqZCGCAhzNQ38uqBHbIo3maY3aTVczZXUxzztKKZtqIPGHdoLlF Mb6Pm8Q== X-Received: from pgbcr11.prod.google.com ([2002:a05:6a02:410b:b0:c73:9c8b:4186]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:914c:b0:398:8a92:78aa with SMTP id adf61e73a8af0-398eca38eecmr460017637.22.1773345329610; Thu, 12 Mar 2026 12:55:29 -0700 (PDT) Date: Thu, 12 Mar 2026 12:55:28 -0700 In-Reply-To: <20260303191509.1565629-2-tycho@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260303191509.1565629-1-tycho@kernel.org> <20260303191509.1565629-2-tycho@kernel.org> Message-ID: Subject: Re: [PATCH 1/5] kvm/sev: don't expose unusable VM types From: Sean Christopherson To: Tycho Andersen Cc: Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ashish Kalra , Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , Shuah Khan , Kim Phillips , Alexey Kardashevskiy , Nikunj A Dadhania , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" KVM: SEV: On Tue, Mar 03, 2026, Tycho Andersen wrote: > From: "Tycho Andersen (AMD)" > > Commit 0aa6b90ef9d7 ("KVM: SVM: Add support for allowing zero SEV ASIDs") > made it possible to make it impossible to use SEV VMs by not allocating > them any ASIDs. > > Commit 6c7c620585c6 ("KVM: SEV: Add SEV-SNP CipherTextHiding support") did > the same thing for SEV-ES. > > Do not export KVM_X86_SEV(_ES)_VM as exported types if in either of these ^^^^^^^^ supported > situations, so that userspace can use them to determine what is actually > supported by the current kernel configuration. > > Also move the buildup to a local variable so it is easier to add additional > masking in future patches. > > Link: https://lore.kernel.org/all/aZyLIWtffvEnmtYh@google.com/ > Suggested-by: Sean Christopherson > Signed-off-by: Tycho Andersen (AMD) > --- > arch/x86/kvm/svm/sev.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 3f9c1aa39a0a..f941d48626d3 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -2957,18 +2957,26 @@ void sev_vm_destroy(struct kvm *kvm) > > void __init sev_set_cpu_caps(void) > { > + int supported_vm_types = 0; This should be a u32. > + > if (sev_enabled) { > kvm_cpu_cap_set(X86_FEATURE_SEV); > - kvm_caps.supported_vm_types |= BIT(KVM_X86_SEV_VM); > + > + if (min_sev_asid <= max_sev_asid) > + supported_vm_types |= BIT(KVM_X86_SEV_VM); > } > if (sev_es_enabled) { > kvm_cpu_cap_set(X86_FEATURE_SEV_ES); > - kvm_caps.supported_vm_types |= BIT(KVM_X86_SEV_ES_VM); > + > + if (min_sev_es_asid <= max_sev_es_asid) > + supported_vm_types |= BIT(KVM_X86_SEV_ES_VM); > } > if (sev_snp_enabled) { > kvm_cpu_cap_set(X86_FEATURE_SEV_SNP); > - kvm_caps.supported_vm_types |= BIT(KVM_X86_SNP_VM); > + supported_vm_types |= BIT(KVM_X86_SNP_VM); > } > + > + kvm_caps.supported_vm_types |= supported_vm_types; > } > > static bool is_sev_snp_initialized(void) > -- > 2.53.0 >