From: Chunyu Hu <chuhu@redhat.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org,
linux-mm@kvack.org, ljs@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, surenb@google.com, mhocko@suse.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev
Subject: Re: [PATCH 0/4] selftests/mm: skip several tests when thp is not available
Date: Fri, 13 Mar 2026 08:26:02 +0800 [thread overview]
Message-ID: <abNZmiL2C7KMQM1t@gmail.com> (raw)
In-Reply-To: <abLHz2qjdeNqdFaZ@kernel.org>
On Thu, Mar 12, 2026 at 04:03:59PM +0200, Mike Rapoport wrote:
> On Thu, Mar 12, 2026 at 07:40:23PM +0800, Chunyu Hu wrote:
> > There are several tests requires transprarent hugepages, when run on thp
> > disabled kernel such as realtime kernel, there will be false positve.
>
> I presume that when THP tests run on kernels with THP disabled they fail
> and it would be a false negative rather than false positive.
This is an interesting point. I'm not naitive speaker. I just learned
from AI. It really matters what we define as 'postive'. I presume 'postive'
is we run selftest and got a failure report, that's postive, not thinking
as it's thp disabled kernel and a 'pass' is postive.
I'll add statement about 'postive' in v2 like "a test failure is
defiend as postive"
>
> > Mark those tests as skip when thp is not available.
> >
> > Chunye Hu (4):
> > selftests/mm/guard-regions: skip collapse test when thp not enabled
> > selftests/mm: soft-dirty: skip two tests when thp not available
> > selftests/mm: split_huge_page_test: skip the test when thp not
> > available
> > selftests/mm: transhuge_stress: skip the test when thp not available
> >
> > tools/testing/selftests/mm/guard-regions.c | 4 ++++
> > tools/testing/selftests/mm/soft-dirty.c | 4 +++-
> > tools/testing/selftests/mm/split_huge_page_test.c | 9 +++++++--
> > tools/testing/selftests/mm/transhuge-stress.c | 4 ++++
> > 4 files changed, 18 insertions(+), 3 deletions(-)
> >
> >
> > base-commit: 80234b5ab240f52fa45d201e899e207b9265ef91
> > --
> > 2.53.0
> >
>
> --
> Sincerely yours,
> Mike.
>
next prev parent reply other threads:[~2026-03-13 0:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:40 [PATCH 0/4] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-12 11:40 ` [RESEND PATCH 1/4] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-12 13:58 ` Zi Yan
2026-03-12 19:48 ` David Hildenbrand (Arm)
2026-03-13 15:35 ` Lorenzo Stoakes (Oracle)
2026-03-12 11:40 ` [RESEND PATCH 2/4] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-12 14:00 ` Zi Yan
2026-03-12 19:43 ` David Hildenbrand (Arm)
2026-03-13 17:37 ` Lorenzo Stoakes (Oracle)
2026-03-12 11:40 ` [RESEND PATCH 3/4] selftests/mm: split_huge_page_test: skip the test " Chunyu Hu
2026-03-12 14:11 ` Zi Yan
2026-03-13 2:29 ` Chunyu Hu
2026-03-13 15:15 ` Mike Rapoport
2026-03-13 15:27 ` Zi Yan
2026-03-13 18:00 ` Lorenzo Stoakes (Oracle)
2026-03-16 3:51 ` Chunyu Hu
2026-03-16 3:46 ` Chunyu Hu
2026-03-12 19:44 ` David Hildenbrand (Arm)
2026-03-13 2:25 ` Chunyu Hu
2026-03-12 11:40 ` [RESEND PATCH 4/4] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-12 14:11 ` Zi Yan
2026-03-12 19:46 ` David Hildenbrand (Arm)
2026-03-13 2:43 ` Chunyu Hu
2026-03-13 18:01 ` Lorenzo Stoakes (Oracle)
2026-03-12 14:03 ` [PATCH 0/4] selftests/mm: skip several tests when thp is " Mike Rapoport
2026-03-13 0:26 ` Chunyu Hu [this message]
2026-03-13 15:19 ` Mike Rapoport
2026-03-13 15:40 ` Lorenzo Stoakes (Oracle)
2026-03-14 0:22 ` Chunyu Hu
2026-03-14 0:27 ` Chunyu Hu
2026-03-12 19:39 ` David Hildenbrand (Arm)
2026-03-13 2:21 ` Chunyu Hu
-- strict thread matches above, loose matches on Subject: below --
2026-03-12 11:26 Chunyu Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abNZmiL2C7KMQM1t@gmail.com \
--to=chuhu@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox