From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 641341D6195 for ; Fri, 13 Mar 2026 02:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773367328; cv=none; b=SQMrDRX9qgtMUjOb1I7BoXuU1gOtOTz6ORe6J9PTG9ZU3jFQ3kQxOp/u3rAHPkRmaYJnExJ8FEgr5uo3Zk1g2WrlUl3BjjJ6BnbvlIa8Ngbdj1306CAWOI5n5EF8OPdJj5UWeS6ioE8u/EWlXvP7ICRoTrqyil4WGiK83vFmlw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773367328; c=relaxed/simple; bh=3iI8YKcll+/B87H17WLmZJZ1SjoiUwup1pAGRWaJyp4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M3Wy/h4IJ2+dA0+FZ3gQjzoQ6TPwPZE1PLTE04VmXwGEw/hgqrRrWli8o8bFTGDvzZOdWtaGVvxvmsmackewFQqc6xYxDiQHmTAU9wLkfW786MNiIxSnvM0YPP/TQH4ooPETHRJ228jO2W7uBeOuYA4HIdcTzV7XJRxzcrXA9DE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CIaiS/sM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CrS50L61; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CIaiS/sM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CrS50L61" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773367326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UAyhRnlNpUnX5VzPdhg0Qd00rbCwrg1BNtte72JRAqE=; b=CIaiS/sMurK3xS6/KBeNpXlHw69wQnJnVm1h2IWnyreuWN/Nt2lyT1VRqWerAgByVsSjZ0 IFxLYUFZ9PMlKf5WceOML0bF6S9bN/gShoD6Aqh+b0hpIAm7NZ6rFHMyhoUfwROai3hw7l F5pqdVhjdX+MZwFUEIRUYNKNsXh4G54= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-ZBktRejfOMmD2Ppq6SXzMg-1; Thu, 12 Mar 2026 22:02:04 -0400 X-MC-Unique: ZBktRejfOMmD2Ppq6SXzMg-1 X-Mimecast-MFC-AGG-ID: ZBktRejfOMmD2Ppq6SXzMg_1773367324 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8298150caddso1299714b3a.3 for ; Thu, 12 Mar 2026 19:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773367324; x=1773972124; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UAyhRnlNpUnX5VzPdhg0Qd00rbCwrg1BNtte72JRAqE=; b=CrS50L61clml3/pls68jPvWYH8LjBF7Tty/rgkz40Mg+qqhqJgo5aZ07c+czihWM+g 7BwP0xura67Hk/mqOVMoYUwM22HjZJoNzLTppn+tZMWLPdqPB1iWIHDrF/p9H8l4hy2P e95INCYKsu2+wxDWRv2y9wkLoGZtlk2QoZd3HYjYqBgO5AyJx9bJ70gYo0wmhv0bHsnA YTA1+2hplGCjHb/fnkSg+PLopaB/U7kydJxU34jYs9x4esrMx2z3dXXRpIFxiflBxSyE PEklufPR0u48oh53yuQ1meAp21I+kCT2wkpYKxmG9y3R9p81JL/nyZJS05HTJKFF2C5+ Y5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773367324; x=1773972124; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UAyhRnlNpUnX5VzPdhg0Qd00rbCwrg1BNtte72JRAqE=; b=ADBOZtNytPWvEkPqx1Aktjw4QVmm2rNiH921kw73AOU51QeC3fxHOCaoNjsPsTJ8Z9 wxxxTY9gAazlOl+ntlrxf48I+BLoK4IVzBM7TxCCH6GSRBhiy+ssOm4pfYQ2oBLmCQ+4 /VDVTA9xLexLNL9bPt0VWgN/eJNSgNGSiHD/ucihUVb951PFwQpWkkoj2Z3g4Ckh/HMR ER/cssLIveOBS4ecRDn5eSsB+vjzDxkB1Kgwl8LcqGeIZr4LBO7BvDGs6UtarVcBPUG3 cYMG9PkcMYWEKDbc3ujWT+fEi78RQO1VDgov5AwbNlyLt5QnfYtaRopZLOZbUvu2eecr ZUOQ== X-Forwarded-Encrypted: i=1; AJvYcCUpO14CcNuVprIsS/Um35o1EQA1qqmaDRGs+1OhKKoEJBK46+iUFXIga3bCACw+5EmpZV73ZNgl2+BtGDc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0ivd4hLexLMnfy+75Al59Ihsizrqh7hzuqwFcq8ak2Z+nf/oC Bdc+fX93y6XBCII7bertHTyyZmWSTjoXL5tqQm5se9ZpCmHMAKgBI9VojlegQNcjA8LAOYYLZXA o+zbmooTBLg7mALtWhVh3YWZP/0p/XIVQzaqibcOgLxpeqrwFTTtOBo3RquB2rfoKcQ== X-Gm-Gg: ATEYQzwaI6q9GpY96pDtVYQUrbzGVO7Ia6QG5ST7TO+rQuFuYz1BmJx/xUS56p46c75 Jza1T9/oNajQQq6cBzGBisPKoDIKZDNowbVKCJxbp0N78IKKojv456Cm1rbwe/PZn8YnqXYI08u Ke0lpMnnJ0lNDa9spW4xXKM4R6Dq7zV0v1OTemoujjmYtI7QVYmgEPPjhwlpHQLEZh8HOB1Vl2l B1yza0NeXm3TdoGEB2LXCjh64JMF78jWkCgErYMTmgziq2Zs3IEDH3QIhi0d9jTtD1r+zOjisMa bluIKjlh2uPl4wI9oIUAxkb2e2JoU++0t4/cGarNO3kLxaDCnhxjI8Hbjyvwg4XQ8sb3NVfsabP xgmgeR8cSwnVCWZL8/g== X-Received: by 2002:a05:6a00:a04:b0:829:809e:897d with SMTP id d2e1a72fcca58-82a1972f06bmr1306950b3a.26.1773367323680; Thu, 12 Mar 2026 19:02:03 -0700 (PDT) X-Received: by 2002:a05:6a00:a04:b0:829:809e:897d with SMTP id d2e1a72fcca58-82a1972f06bmr1306911b3a.26.1773367322868; Thu, 12 Mar 2026 19:02:02 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0725e0cdsm4299766b3a.16.2026.03.12.19.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 19:02:02 -0700 (PDT) Date: Fri, 13 Mar 2026 10:01:59 +0800 From: Li Wang To: Yosry Ahmed Cc: mkoutny@suse.com, yosryahmed@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Muchun Song , Nhat Pham , Tejun Heo , Roman Gushchin , Shakeel Butt Subject: Re: [PATCH v2 6/7] selftests/cgroup: replace hardcoded page size values in test_zswap Message-ID: References: <20260312040627.55257-1-liwang@redhat.com> <20260312040627.55257-6-liwang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 12, 2026 at 03:44:09PM -0700, Yosry Ahmed wrote: > On Wed, Mar 11, 2026 at 9:07 PM Li Wang wrote: > > > > test_zswap uses hardcoded values of 4095 and 4096 throughout as page > > stride and page size, which are only correct on systems with a 4K page > > size. On architectures with larger pages (e.g., 64K on arm64 or ppc64), > > these constants cause memory to be touched at sub-page granularity, > > leading to inefficient access patterns and incorrect page count > > calculations, which can cause test failures. > > > > Replace all hardcoded 4095 and 4096 values with a global pagesize > > variable initialized from sysconf(_SC_PAGESIZE) at startup, and remove > > the redundant local sysconf() calls scattered across individual > > functions. No functional change on 4K page size systems. > > > > Signed-off-by: Li Wang > > Cc: Johannes Weiner > > Cc: Michal Hocko > > Cc: Michal Koutný > > Cc: Muchun Song > > Cc: Nhat Pham > > Cc: Tejun Heo > > Cc: Roman Gushchin > > Cc: Shakeel Butt > > Cc: Yosry Ahmed > > It makes more sense to have this patch first, replacing all hardcoded > values, then patch 5 doing the necessary changes on top. Make sense. -- Regards, Li Wang