From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4347C346FB8 for ; Fri, 13 Mar 2026 03:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773372238; cv=none; b=suBX1WG8ig12wKIh9igKDy48dp/VE+feVi2gAED+gzV2xR+xXXHcxm9em7OUB0FeEg26rtVIeUlI5QgKM1RROopZ3dadrn26H3y2dVUX+Qug25s4ZmnGFyvInW2t5LMIyjcTx1ifjRJlVxlohnF54tUFzw2iAGKYyx6R1t0d/uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773372238; c=relaxed/simple; bh=CrO0Z3Kla1w0Ut7d964MhaF1H2bfH9lE/BjVQXgu3hg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tlf6e531B1ABLeTtgE+kPZte++/98D3633k2vTZpxYD3z/8kHZOr+bCQ3uQpWIypWba9Auipboz4H5jbctlxsSFPRU5o3S7kudaa2ZQfQQUAa7yiJtFYJGNkxgtrp/0lzlY8EqC5FX/3x0mGQaHma4N4PO/6MiEJkPkL5n8TPAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i0P1yAnf; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UZjjR2Kw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i0P1yAnf"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UZjjR2Kw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773372235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XyUSirNPJAnFjUFfi5pJvHSlQzaYa0PVQM56kebxuis=; b=i0P1yAnfvvt7qQ+0N1l8cyWPt1st0z1F7uizEpjSoK1UMXuOnoALvzqYBbcuMJ0n7z4cmZ eI+Xdlw0hU05Kghv4rjW84ewkmjVCM4rmx20xI/OwqkOvleat/87peydBpo+mj1yh9UU5A 9qrBTOIjjsk8ae/6IuVdHBVdd/As564= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-sPe7CcoqM2KKCslXJKNNVg-1; Thu, 12 Mar 2026 23:23:53 -0400 X-MC-Unique: sPe7CcoqM2KKCslXJKNNVg-1 X-Mimecast-MFC-AGG-ID: sPe7CcoqM2KKCslXJKNNVg_1773372233 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c6e7f45e2ddso7646456a12.1 for ; Thu, 12 Mar 2026 20:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773372233; x=1773977033; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XyUSirNPJAnFjUFfi5pJvHSlQzaYa0PVQM56kebxuis=; b=UZjjR2KwzZsd87hCoaEjxuFDibmCXAuzQ19khJ2EWHWySfVV+YZ4untWGF52Taia8s whrdCmzfO+tXX1xQ8ZP2VcvGIc87GqHzQgXcjtcFBbIu//UbnlKWkbH5r44Cy8tRlq3G gkvV3/3zZ7PvAya6dKpdvO8J22cqFchZQVJnTEV6zgbyWAQYyX8ptjsGb7PFu4OMTEtv OMu1zkQgK4xqJULYGTtwZ6/maSRnmGKg7f7acGOIPESHUIKIxknODX2G/Gdijkncw3Ku gbhYUzfTqV+W0rlvNGC8yshj9kUsBh1rpJcq++1Az2rxznx016I3i6QoScN14Ls7Luzg qRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773372233; x=1773977033; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XyUSirNPJAnFjUFfi5pJvHSlQzaYa0PVQM56kebxuis=; b=PDp9SbC3z7L4USE4W8M4+Z8nQXol8JHOWklH2i0mrKN9ZlhFsljQ1EtgIkkNhLHVgZ 63BOitWRuUKYQjN6UjbP8H14ys4GI+g+fu0pgKNdaoXIoI24F2p1BeIpv+l8rl/wpk51 UYBB03WzoT70HspEjdJ+mAOO+X31dp/ixf3zQGpbjBUQqECd5D/S/w2QsKNio0BvOM0f JqW6G8hBCgDZ+5wtAfI4e/2NSx/QS/n+6QorCSJ5BBtBlsjFXKpA6NZovpPDlYQFCVA4 aCVgaFESiawlA+ZWO86oMgKBOMuRd9lVFPybhO5FihQwtKJ/RBxz6EuU89+dI72unMah DGBQ== X-Forwarded-Encrypted: i=1; AJvYcCVJS5N6et16AjAwDBRlE8or9F+DyEvK81ovliLX1/okiHxy8SHN6AabXes6v+QzddBhlT/lmBVg5KVSPeM=@vger.kernel.org X-Gm-Message-State: AOJu0YzpoOibVnkRF96eSTdq54VXYd6V9cX56QUDCm0CH31t8IgVeM9b Pm2xlBfsZpcODZ+1KV3P/ka3/fncPr8veJdPCzDBqEEC3Szq/7qkG6r3zMnVo8mEYZkxsVHGabr sN1rUrw7OLgIw04OddHadyAoHzK5c0a5GMZni1qnjXJ/l3hPFEOBuvwC8Yn1s9f5nHw== X-Gm-Gg: ATEYQzzrOVaEBgR5gGDFy5k+7Mis4ShZCR0/qx/gQAtWY3rzVhmD70uk2BazTAbQgx7 LWLNY5YeEqms2fYqyP6vUnG9P7FBXFoSbFwCR+XjFkXOWcTBK+7KSWX/b3GU2ChmKlIFRvDvVH4 9Lw1JFLQWEGwPDzuQxm0IsY1Xks/Ql6+KMQZR4cVX+0Fh07m1u2mLkCTi7kq/+VrdNwYDVdkjCx DCmx+1rUcyazYRzjQ3junLfKfmFxJgGTmZPj/08PZaVwdpArNxYMtmdKg+CpwCaAMIWeRPD4x6S rxOSJ4dKxPr8pjghXeSLevsYx5GHehwD74Th0pyOwPWt3x1RHbk2UCfi+YxRj+c+Qqyavk4O8zg +XN9bOSrVCmiH+A5+qA== X-Received: by 2002:a05:6300:193:b0:398:9820:f6ff with SMTP id adf61e73a8af0-398ecdc67eemr1371857637.62.1773372232819; Thu, 12 Mar 2026 20:23:52 -0700 (PDT) X-Received: by 2002:a05:6300:193:b0:398:9820:f6ff with SMTP id adf61e73a8af0-398ecdc67eemr1371846637.62.1773372232455; Thu, 12 Mar 2026 20:23:52 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73ebb75624sm421173a12.24.2026.03.12.20.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 20:23:51 -0700 (PDT) Date: Fri, 13 Mar 2026 11:23:50 +0800 From: Li Wang To: Yosry Ahmed Cc: Nhat Pham , mkoutny@suse.com, yosryahmed@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Muchun Song , Tejun Heo , Roman Gushchin , Shakeel Butt Subject: Re: [PATCH v2 1/7] selftests/cgroup: skip test_zswap if zswap is globally disabled Message-ID: References: <20260312040627.55257-1-liwang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 12, 2026 at 07:58:28PM -0700, Yosry Ahmed wrote: > > Yes, this looks more tidy than open it. I'll go this helper in v3. > > > > > > > > static void check_zswap_enabled(void) > > > { > > > char value; > > > > read_text() requires string but not char. > > I was just illustrating. This should be passed in as &value. That should work? Yes, pass it as &value works well. Patchset v3 is on the way :). -- Regards, Li Wang