From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6DFB317148 for ; Fri, 13 Mar 2026 11:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773401583; cv=none; b=Q0bzKXC0PfGIwcckAe01/Ae0+kwUdsfimAoKll8OSaVfn/csfSZRjVvMmWPcTuuQZZ8AlM45mJRMd5qMSFljTPsMZ9swn44pRuPrAu+VUVArZDX7q/Z1lkkjhR7sfG+JXL0cJz06QiGAwU0pMBvPpA9OtqO9GB39RSKTG9ru1xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773401583; c=relaxed/simple; bh=iz72b53fIQgo7cNa0qc/rwFjYVHgzC3cgdc9UCyOr3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=thnxRLOrubUW53rvdMjnSHRgMyWruzFena+RMXrS+Egprcbi4agg1DjSoS1ck2oslFPpbGTDoZXsZkxTQMeqBRLF+39HZS6fHnj/2plGcgPsYyCov1K3rcDxttQ0JJ9pnIM8GnT24rNh/Dv6WUX8ynsgynSXZ8sVnKuhzJphTNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZuapIB5D; arc=none smtp.client-ip=209.85.221.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZuapIB5D" Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-5674d8be45eso797503e0c.1 for ; Fri, 13 Mar 2026 04:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773401580; x=1774006380; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=haCHU4tFbveJ6fRvm0o+9mw9xNWZ6TKNuvNCvrgL1/c=; b=ZuapIB5Dx87vaSqePbCBosUHOePQSx+LoC2KJDX9cRbS+ygnOqlVxdOnRRLZTeXt0E pcZiGdhmEJrHl7QxOAgAJNx60YXjCJdK6ij+V0AAc0oJjlC4BNux9W1NIoVT4LSgbxt4 N0sGZfTFHnSwhy+I18D+Htzv3aTJKhhW8orm96AFmw6WB10G/5285uspO6Uf9FGDdT9j 3cLZ0hEI9a+mdzYpj/2WbBIY9SLWN2Wwj8BeN9swMFhzP+y9PMMH7PwwHZbcR9Adk0ri g7bT5LK4thO7LPS0CVmt4QpjDlIHututPGlPYh7ydYC4eUkh69B9pLFJ7r3PrBuDKYWM Vr/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773401580; x=1774006380; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=haCHU4tFbveJ6fRvm0o+9mw9xNWZ6TKNuvNCvrgL1/c=; b=Y5Z8Nvvj0RGKSgrpycVsdi05MzHm7t5sEKhpC1BdDGmuyaijtEeA/BfMCVF7EnWTKy MMKvkuqhSohMHyW6gP+8i4yi9KKc+rUVd9+b+vUytFkQVourcxEdWLgJG2nXc/xlhuov G2FeYoinTcXY0mPnqYW877BkVet0zrq7/ZCsNguxPjx/3ZGzgXlNElzx0ETfP4DqAOAS o/u7xI9UYNYJqhKPU5SGo++/axZ6GrayNU6n73DfpQUJ4q2w20+WBNToeOMgCDXs+34P MbFhXEL1tH2CqdKshUg4zwy3YcQd3txsPBRbBOPJs240VGZ1qRNm/wOIjfPemJY+57Lc r9xg== X-Forwarded-Encrypted: i=1; AJvYcCU10WtCQERbchF9xsMEMcIO0aT1xfJXD1H9CDiPWXPrY9bqWYnd6y5ZlzMtMwNPl5aIjvKpW6nNi/xq7ns=@vger.kernel.org X-Gm-Message-State: AOJu0YyE2PjpUSPqfEuJljkvzmF7ghCnt6IPYew8sF2i+1POVvAjc+Rh dN5JcaOUY2IH+c0w+w0V/UfN42A+a0A0fc8NZNJ7JhPWmqbZOaNhFavUrmc13lKD X-Gm-Gg: ATEYQzzlRZr3f53zq2Ps0zgeZCg0+ritCR+4fxe4CwP3TOETvmklYJwL3DiIvWU8KzA fenVvArRmKcK62bxf2XEPpeFYfD7xogSr+NTR68876W1DXqBlaQn4XQ6Qi2245vEciE7QdaDf3L MYrtAn51pLOg0be11LErO0Xll5oxWL2C3BB5kOS0njyc1fkm7EXJ1xSJE6SHpvNvoDtOgxhwzze yWRVd7s+ptC5VhgSPvfJuJ4aDdrOsE3Q5O0ScdoIsMbuAeiNc4QIb6SPvRcQv5bz79vv/vDMNGG 5Kt2Kavj2mDndHDKrw+gI7Z06mQ6Qdm0L1pm9nZrgc1y4qPRoqEtRc1YfLXW1UMXP6VdLGP6cbN 7oTHIwbXtqIP5b4ExnHw3bhDRGYxh97qvVgIed55WXddRYQbm91m/PuD+NlarBlWKSWnq2r1Ygo OOLRSRKm+nOaK88XCIhjEWh8VumyqABsl6fzFcMjcwcrqj0AeASMw//CM= X-Received: by 2002:a05:6102:374b:b0:5f5:3638:776f with SMTP id ada2fe7eead31-6020e585d6fmr921073137.25.1773401580535; Fri, 13 Mar 2026 04:33:00 -0700 (PDT) Received: from fedora ([177.73.136.69]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-601deaa379asm3104070137.8.2026.03.13.04.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 04:32:59 -0700 (PDT) Date: Fri, 13 Mar 2026 08:32:52 -0300 From: Pedro Demarchi Gomes To: Boris Brezillon Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Loic Molinari , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/shmem-helper: Fix Map huge page mapping in fault handler Message-ID: References: <20260312155027.1682606-1-pedrodemargomes@gmail.com> <20260312173227.7e9f0389@fedora> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260312173227.7e9f0389@fedora> On Thu, Mar 12, 2026 at 05:32:27PM +0100, Boris Brezillon wrote: > Do we really need to duplicate everything? Can't we rename > drm_gem_shmem_fault() into drm_gem_shmem_any_fault() with a > `bool try_pmd` passed as an argument, and then have > drm_gem_shmem_[huge_]fault() as wrappers? > > static vm_fault_t drm_gem_shmem_huge_fault(struct vm_fault *vmf, > unsigned int order) > { > if (order != PMD_ORDER) > return VM_FAULT_FALLBACK; > > return drm_gem_shmem_any_fault(vmf, true); > } > > static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) > { > return drm_gem_shmem_any_fault(vmf, false); > } > Ack. > > @@ -643,6 +667,9 @@ static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) > > > > const struct vm_operations_struct drm_gem_shmem_vm_ops = { > > .fault = drm_gem_shmem_fault, > > + #ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP > > + .huge_fault = drm_gem_shmem_huge_fault, > > + #endif > > Let's keep the #ifdef unindented: > > #ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP > .huge_fault = drm_gem_shmem_huge_fault, > #endif > > > .open = drm_gem_shmem_vm_open, > > .close = drm_gem_shmem_vm_close, > > }; > Ack. I will send a v2 addressing these issues. Thanks.