* [PATCH] usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003)
@ 2026-03-13 2:36 zwq2226404116
2026-03-13 8:30 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: zwq2226404116 @ 2026-03-13 2:36 UTC (permalink / raw)
To: johan, gregkh; +Cc: linux-usb, linux-kernel, zwq2226404116, Wanquan Zhong
From: Wanquan Zhong <wanquan.zhong@fibocom.com>
Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
which is used in laptop debug cards with MBIM interface for
Linux/Chrome OS. The device supports mbim, diag, adb and AT command
functionalities.
Here are the outputs of usb-devices:
T: Bus=04 Lev=01 Prnt=01 Port=02 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0
D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1
P: Vendor=33f8 ProdID=1003 Rev=05.15
S: Manufacturer=Rolling Wireless S.a.r.l.
S: Product=Rolling RW135R-GL Module
S: SerialNumber=12345678
C: #Ifs= 3 Cfg#= 1 Atr=a0 MxPwr=896mA
I: If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim
E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=32ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim
E: Ad=0f(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms
E: Ad=8e(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms
I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=40 Driver=option
E: Ad=01(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms
E: Ad=82(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms
E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index e349ed66d2ac..abeeb7c66977 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2449,6 +2449,9 @@ static const struct usb_device_id option_ids[] = {
.driver_info = RSVD(4) | RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0115, 0xff), /* Rolling RW135-GL (laptop MBIM) */
.driver_info = RSVD(5) },
+ /* Rolling RW135R-GL (laptop MBIM) */
+ { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),
+ .driver_info = RSVD(5) },
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a2, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a3, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a4, 0xff), /* Rolling RW101-GL (laptop MBIM) */
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003)
2026-03-13 2:36 [PATCH] usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003) zwq2226404116
@ 2026-03-13 8:30 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2026-03-13 8:30 UTC (permalink / raw)
To: zwq2226404116; +Cc: gregkh, linux-usb, linux-kernel, Wanquan Zhong
On Fri, Mar 13, 2026 at 10:36:05AM +0800, zwq2226404116@163.com wrote:
> From: Wanquan Zhong <wanquan.zhong@fibocom.com>
>
> Add VID/PID 33f8:1003 for the Rolling Wireless RW135R-GL M.2 module,
> which is used in laptop debug cards with MBIM interface for
> Linux/Chrome OS. The device supports mbim, diag, adb and AT command
> functionalities.
>
> Here are the outputs of usb-devices:
> T: Bus=04 Lev=01 Prnt=01 Port=02 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0
> D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1
> P: Vendor=33f8 ProdID=1003 Rev=05.15
> S: Manufacturer=Rolling Wireless S.a.r.l.
> S: Product=Rolling RW135R-GL Module
> S: SerialNumber=12345678
> C: #Ifs= 3 Cfg#= 1 Atr=a0 MxPwr=896mA
> I: If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim
> E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=32ms
> I: If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim
> E: Ad=0f(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms
> E: Ad=8e(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms
> I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=40 Driver=option
> E: Ad=01(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms
> E: Ad=82(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms
> E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms
Can you include the other configurations as well? This one only as three
interfaces, which doesn't explain why you need to blacklist interface 5
(or which interfaces handle diag, adb, etc).
A few more comments below.
> Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
> ---
This is an updated patch which should be reflected in the patch summary
(Subject) (e.g. "[PATCH v2]: USB: ...").
Also include a short changelog here under the --- line when sending
updated patches.
> drivers/usb/serial/option.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e349ed66d2ac..abeeb7c66977 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2449,6 +2449,9 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(4) | RSVD(5) },
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0115, 0xff), /* Rolling RW135-GL (laptop MBIM) */
> .driver_info = RSVD(5) },
> + /* Rolling RW135R-GL (laptop MBIM) */
> + { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),
> + .driver_info = RSVD(5) },
Looks like you missed my comments about this entry not being in VID/PID
sort order, and that the comment should go after the entry (like the
other entries).
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a2, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a3, 0xff) }, /* Rolling RW101-GL (laptop MBIM) */
> { USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x01a4, 0xff), /* Rolling RW101-GL (laptop MBIM) */
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-13 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 2:36 [PATCH] usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003) zwq2226404116
2026-03-13 8:30 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox