From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B9E282F0F for ; Fri, 13 Mar 2026 11:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773400063; cv=none; b=Gcz6L6nn2qRvytsrQzKGNdNEwWf2rwkgbuYnC5KuPqRQ48Dw1IinfpvPB8Gc9jA0LvaWI9Erh4jQZTcd7NUqb4Z5WDpz8ZFowrSUE1q9fG/u7Z6ls0EGdMp5zB4aO94NRWIb0QhJHuIt8OiB9QddbPoa3DFQfMcEgInPEEU9hIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773400063; c=relaxed/simple; bh=pD3QLCiXs4+NxunzyQ9Zzrc1hNhjdRO9E2U9/Xo57Es=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FikF5RKuA2lTp+4zJr5akCYCw/NHxm/cvaF44CPGduYSnGTW1/rLJufvwMTLT7ne41qVx1uzLSLtC7kroW5M0HkB8uazOdqbfd4COr0Ea+wp2GTGtV+z8XSqvmg0gKJdIwXbmLb33cgh4r7YLSzxqb06T6gg5XteZn7dzw0mGPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tX2Cumdr; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tX2Cumdr" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so6521885e9.0 for ; Fri, 13 Mar 2026 04:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773400060; x=1774004860; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Treo8+ILHQ1M2ArKnaNpioch/szegt3Svu0aZTIh4xM=; b=tX2CumdrMj4R0aGklAJkv3Eba7Xx2zr7gP2HSFLSu9CKMppEAmpW5N5pN+x/kXE3G7 J4/6cO7KLLyoWAHO/ds96q8ILDv5pGXjmyOPF9SNEyo1ji61Sx2z1/3DtGwmcA4YJ3Sc XwzZQ1IobkC//FIxl3lCx5u7Iv2So6vmtB+FN2lgTu+R8UcAmweA1TgrwhUcS3y+Woeu KmCI2eHTk0wxQnO9Y75pPIJkhMooHpvZ7EtAqUPSNAZYF5N2aOo6GzQbCRdcQTI6ORGR xs9eXbsJgrxtmzNhwxzIWOIuAbxcXkGkuYDIcCqWSZgwefotz+P6bklAJ1oUqM0fOHu9 LXRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773400060; x=1774004860; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Treo8+ILHQ1M2ArKnaNpioch/szegt3Svu0aZTIh4xM=; b=ZCibTb0r5ZcqtQjJ2NsdBkN9bedjoaCQKXIoZcZu//8dq1h5FhYr/7kWr/ZwLA1bAz BraHu1U6JR91f91nGIvSZrPOiqKM3t/nmg39OI8arH/03laU/1xbv/+JNriuvMcnhjyN FLCtLdpBw8DtLPrBEwctBbdcqC8T2IfHnSnShJW1/q9Xm65DK269DUqyPh71V83FYjhS lEgeM389g1+l7w6xHX7iUCmPdN7LS/uOm8iki+ADceUdThipzMfKY9Xh2diIq5xv2Aje A5/cDhBucgs4IkySc5irU07rwGS6y6Br7BVW3XSljqfH2XfQlK+ilwJRgtIzoIkxYnwt /nYA== X-Forwarded-Encrypted: i=1; AJvYcCU6++cO9+79ICyBQEqC/ju1fgP6GYqPwa2DQHXYiJ1yjNWdbxcYzxQSxDq4TEOfH6GrO2a+SvCdCzUHjgk=@vger.kernel.org X-Gm-Message-State: AOJu0YwjkH23tCBpUpYdG99QRqZcNsRFGtq2W8VHcpVnQz/OEd9T1Xkg vMQr9wTaXKB36+JQF+xnmnNSsjNP1hZEX6PWJotfXgETbS/KbLgVs0a1DuDFhDyI0w== X-Gm-Gg: ATEYQzzOcxX0zeu8FJT1A+M9v+8+isb+HQaBEG5+EB0gSOoiVyzu41QBMg1WJtyAQ20 oo9JIOGz5maZWxCWWAah2NelptDOALu+mRB4DKjI4MtZ/z6Hh/aXMWHwmoul6y3Ik4A2Dr4vw2u 7ddxIyxd8FnPgNPz1inD3gdUaW6A48yb2/9BUYSpLJLsZsgkJJrtyUgRauEsZgkzBMzHiUAdOhX OaGASibDHIAFRX9ws/utby0XQDLBLhU2DSeQ4cabIHekpaHG7hkiMgJjyna9TDugdKRVJe5zRbl +eekw8krLwWcuQbIORHm2GSEnE3WdCfe956YrEdo+aNzQ5dveV1TmHxPW50AudpBb2sgOfpCMIz XMRdie1ZRQmQc+Xqa3hFPvjuOKBJO7K01yH0+T750+zpiHJ4LgUzKTyCea164XzIEV85Q3JXcu/ rt8muvNiyopYJ5Yp+1Gj0zx7uGIMkC/RGR9JZIgXRNlggQuKreuIgi1AMeORHv95iFveY= X-Received: by 2002:a05:600c:a09:b0:483:9139:4c1d with SMTP id 5b1f17b1804b1-485566e1a4cmr47428785e9.14.1773400059656; Fri, 13 Mar 2026 04:07:39 -0700 (PDT) Received: from google.com (198.115.140.34.bc.googleusercontent.com. [34.140.115.198]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557c6ece3sm18109795e9.29.2026.03.13.04.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 04:07:39 -0700 (PDT) Date: Fri, 13 Mar 2026 11:07:35 +0000 From: Vincent Donnefort To: Arnd Bergmann Cc: Marc Zyngier , Oliver Upton , Arnd Bergmann , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: avoid unused-variable warning Message-ID: References: <20260313094925.3749287-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260313094925.3749287-1-arnd@kernel.org> On Fri, Mar 13, 2026 at 10:49:16AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The 'cpu' variable is only used inside of an #ifdef block and causes > a warning if there is no user: > > arch/arm64/kvm/hyp_trace.c: In function 'kvm_hyp_trace_init': > arch/arm64/kvm/hyp_trace.c:422:13: error: unused variable 'cpu' [-Werror=unused-variable] > 422 | int cpu; > | ^~~ > > Change the #ifdef to an equivalent IS_ENABLED() check to avoid > the warning. > > Fixes: b22888917fa4 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp") > Signed-off-by: Arnd Bergmann > --- > arch/arm64/kvm/hyp_trace.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c > index c1e28f6581ab..8b7f2bf2fba8 100644 > --- a/arch/arm64/kvm/hyp_trace.c > +++ b/arch/arm64/kvm/hyp_trace.c > @@ -424,17 +424,16 @@ int __init kvm_hyp_trace_init(void) > if (is_kernel_in_hyp_mode()) > return 0; > > -#ifdef CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND > for_each_possible_cpu(cpu) { > const struct arch_timer_erratum_workaround *wa = > per_cpu(timer_unstable_counter_workaround, cpu); > > - if (wa && wa->read_cntvct_el0) { > + if (IS_ENABLED(CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND) && > + wa && wa->read_cntvct_el0) { > pr_warn("hyp trace can't handle CNTVCT workaround '%s'\n", wa->desc); > return -EOPNOTSUPP; > } > } > -#endif > > hyp_trace_init_events(); Reviewed-by: Vincent Donnefort > > -- > 2.39.5 >