Fixes tags could use some work in the mm-unstable tree

Fixes tags could use some work in the mm-unstable tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

In commit

  5bea10633ca8b ("kho: fix child node parsing for debugfs in/sub_fdts")

Fixes tag

  Fixes: "kho: adopt radix tree for preserved memory tracking"

has these problem(s):

  - No SHA1 recognised

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fixes tags could use some work in the mm-unstable tree

[Mike Rapoport]

Hi Mark,

On Fri, Mar 13, 2026 at 12:11:45PM +0000, Mark Brown wrote:
> In commit
> 
>   5bea10633ca8b ("kho: fix child node parsing for debugfs in/sub_fdts")
> 
> Fixes tag
> 
>   Fixes: "kho: adopt radix tree for preserved memory tracking"
> 
> has these problem(s):
> 
>   - No SHA1 recognised

Right, sha's in mm-unstable are, well, unstable :(

Maybe Andrew's tooling updates those when the patches move to mm-stable...

-- 
Sincerely yours,
Mike.

Re: Fixes tags could use some work in the mm-unstable tree

[Andrew Morton]

On Fri, 13 Mar 2026 17:32:20 +0200 Mike Rapoport <rppt@kernel.org> wrote:

> Hi Mark,
> 
> On Fri, Mar 13, 2026 at 12:11:45PM +0000, Mark Brown wrote:
> > In commit
> > 
> >   5bea10633ca8b ("kho: fix child node parsing for debugfs in/sub_fdts")
> > 
> > Fixes tag
> > 
> >   Fixes: "kho: adopt radix tree for preserved memory tracking"
> > 
> > has these problem(s):
> > 
> >   - No SHA1 recognised
> 
> Right, sha's in mm-unstable are, well, unstable :(
> 
> Maybe Andrew's tooling updates those when the patches move to mm-stable...

I simply remove the hash, but that gets us emails from Mark.

I actually track the same info in the filename -
kho-adopt-radix-tree-for-preserved-memory-tracking-fix.patch fixes
kho-adopt-radix-tree-for-preserved-memory-tracking.patch, so I guess
it's best for me to just remove the Fixes: line.

Re: Fixes tags could use some work in the mm-unstable tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

On Fri, Mar 13, 2026 at 09:03:40AM -0700, Andrew Morton wrote:
> On Fri, 13 Mar 2026 17:32:20 +0200 Mike Rapoport <rppt@kernel.org> wrote:
> > On Fri, Mar 13, 2026 at 12:11:45PM +0000, Mark Brown wrote:

> > >   - No SHA1 recognised

> > Right, sha's in mm-unstable are, well, unstable :(

> > Maybe Andrew's tooling updates those when the patches move to mm-stable...

> I simply remove the hash, but that gets us emails from Mark.

> I actually track the same info in the filename -
> kho-adopt-radix-tree-for-preserved-memory-tracking-fix.patch fixes
> kho-adopt-radix-tree-for-preserved-memory-tracking.patch, so I guess
> it's best for me to just remove the Fixes: line.

I'm guessing that given that it's a fix for a commit in a rebased branch
it'll get squashed down into the patch it was fixing anyway?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fixes tags could use some work in the mm-unstable tree

[Andrew Morton]

On Fri, 13 Mar 2026 16:08:19 +0000 Mark Brown <broonie@kernel.org> wrote:

> On Fri, Mar 13, 2026 at 09:03:40AM -0700, Andrew Morton wrote:
> > On Fri, 13 Mar 2026 17:32:20 +0200 Mike Rapoport <rppt@kernel.org> wrote:
> > > On Fri, Mar 13, 2026 at 12:11:45PM +0000, Mark Brown wrote:
> 
> > > >   - No SHA1 recognised
> 
> > > Right, sha's in mm-unstable are, well, unstable :(
> 
> > > Maybe Andrew's tooling updates those when the patches move to mm-stable...
> 
> > I simply remove the hash, but that gets us emails from Mark.
> 
> > I actually track the same info in the filename -
> > kho-adopt-radix-tree-for-preserved-memory-tracking-fix.patch fixes
> > kho-adopt-radix-tree-for-preserved-memory-tracking.patch, so I guess
> > it's best for me to just remove the Fixes: line.
> 
> I'm guessing that given that it's a fix for a commit in a rebased branch
> it'll get squashed down into the patch it was fixing anyway?

yup, the quilt-level foo-fix.patch gets folded into foo.patch before I
move the patch into non-rebasing git.