From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tomas Paukrt <tomaspaukrt@email.cz>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: serial: Add option to enable RS485 mode via GPIO
Date: Tue, 21 Nov 2023 08:04:05 +0100 [thread overview]
Message-ID: <abaea407-c5ea-49fe-8161-51774f0be274@kernel.org> (raw)
In-Reply-To: <3Nk.ZZrp.5w3Yn0Ecy5C.1bMzDp@seznam.cz>
On 20/11/2023 22:45, Tomas Paukrt wrote:
> Add the device tree property "rs485-mode-gpio".
>
> Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
> ---
> Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
> index 9418fd6..7a72f37 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
> @@ -47,6 +47,10 @@ properties:
> later with proper ioctl.
> $ref: /schemas/types.yaml#/definitions/flag
>
> + rs485-mode-gpio:
> + description: GPIO pin to enable RS485 mode at boot time.
> + maxItems: 1
> +
This does not look like generic RS485 property. Commit msg also does not
help to understand the context.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-21 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VY.ZZnz.2Km1cHBSh2}.1bLIJa@seznam.cz>
[not found] ` <476876ca-806f-a5ad-1eeb-435c8a3111a2@gmx.de>
[not found] ` <2cZ.ZZqF.1YADr1CLFoQ.1bMn3d@seznam.cz>
[not found] ` <5a0321ac-e1e6-45e9-9faf-153db8d34980@kernel.org>
2023-11-20 21:45 ` [PATCH v3 1/2] serial: core: Add option to enable RS485 mode via GPIO Tomas Paukrt
2023-11-21 7:02 ` Krzysztof Kozlowski
2023-11-23 14:14 ` Greg Kroah-Hartman
2023-11-20 21:45 ` [PATCH v3 2/2] dt-bindings: serial: " Tomas Paukrt
2023-11-21 7:04 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abaea407-c5ea-49fe-8161-51774f0be274@kernel.org \
--to=krzk@kernel.org \
--cc=LinoSanfilippo@gmx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomaspaukrt@email.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox