From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627AbdEQNL2 (ORCPT ); Wed, 17 May 2017 09:11:28 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34970 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbdEQNL0 (ORCPT ); Wed, 17 May 2017 09:11:26 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH] char: ipmi: remove unnecessary code References: <20170515204653.GA5317@embeddedgus> To: "Gustavo A. R. Silva" Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Corey Minyard Message-ID: Date: Wed, 17 May 2017 08:11:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170515204653.GA5317@embeddedgus> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/2017 03:46 PM, Gustavo A. R. Silva wrote: > The array field name in struct i2c_adapter is a fixed size array > so it can never be NULL. This was already caught by Colin Ian King, a patch is already queued for this. Thanks, -corey > Addresses-Coverity-ID: 1397986 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/char/ipmi/ipmi_ssif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index cca6e5b..df4fea7 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr) > list_for_each_entry(info, &ssif_infos, link) { > if (info->binfo.addr != client->addr) > continue; > - if (info->adapter_name && client->adapter->name && > + if (info->adapter_name && > strcmp_nospace(info->adapter_name, > client->adapter->name)) > continue;