From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FB4228CA9 for ; Sun, 15 Mar 2026 22:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773612843; cv=none; b=pl0XW+671vzCy/gtsWKFjuZgqzYbDZfffCVzy6whLo19W4PT2Dc2mcWmyi0FcLiufB+7ebSLYp2PVOn7T6+/GSyhlfyF4pKcRQ3tcQuEtWDdtfKKXjmzRaWBceuZpeV5gZbesS96w5v4FcSmGEzclhnUn2PMryKZRHO1yd/kKSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773612843; c=relaxed/simple; bh=rbqw4j7YKaoChzOaACXzS9R/DJO/UPR0389tookg8RE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MIJOX1ZTjedBdhulb+rV8y70UhZ2dySxmXvJb+NHm/Jpuc+XFWLuq5WZvtM5sPDEnCj1tUcYuCKc3HksGsDrtviz70wgv+xjNtALBmlaaJkjeczCU6AhJsDaVip+Q+sC+vdGkOnfZeQpy+WM9+9I4NhMuT5V+0+tdMpD8mzU4vA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nnRjtZzu; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nnRjtZzu" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48539cbb7b1so22135275e9.3 for ; Sun, 15 Mar 2026 15:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773612840; x=1774217640; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tcdSDWWl8Yxbno+lQtwlGlIW4vxAda9wkrHkc3R5BdQ=; b=nnRjtZzuReNn3qIUAIOsrKRenjVbpxnlxtsgWVrOrhdlA/LXrdsQSV1YB5a8zDbpcb UB4bLP0nWt7OnYmqx12HT8cQGkQ8DUMJSuQthebhFxtwAHI8Cqh5+7pkomY7R2+UjXGm 6a8p4H9MNBFMqKDs63RtZd5KuW4kgWw6zXhQMRAlmUvAyseT1JwmvdmcfHvAd32gtMwQ Z2OwP26/toK18vZSal2YpXSMaK2LAdLtgzdLowb/mknytw4xlz2xs528eJ+BaU0wbI93 J0T/q/hCv6y9ypR4CGQTYMq2BB4f3yk/5JwrZ73+gbCAo4Fruaozy7spbAPkFDgg3ehY KMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773612840; x=1774217640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tcdSDWWl8Yxbno+lQtwlGlIW4vxAda9wkrHkc3R5BdQ=; b=NbSgFLLF+eyV8L7SL6i5lcz+PY3Ds3kCX9cX5LOLCcdNuJCcWTBJS897TL3uxpznAM STK4222ZVlKPsbHYP8LXWS2Fi6653xXtBs8WOLvHgxK+sijs9LIkf+QBjA27RIpDbdZv uH4OcXNREK+uNtDI7D7yl1vGHqn7H+zWWGHlikPD6JvKJMNu8SrM1SLKNJDTduIXln0K pS1y2OkyGrByWNypcgwznjEMqAsdFEnAunjVb0CzoyOzVOE56+uKe/JVaic7Dce5rMK7 +b83tEZSzpOQq1NEtu9nkqip0VX11uGuyv9c6YIRKtLE60DyG8IwAAII50uwzaJecht8 qEQw== X-Forwarded-Encrypted: i=1; AJvYcCVQqVNazTlGfQ9xBh6UMQyAOXa0SspRAz9D+9SUPBXJgsdyR8yd8nhS8Xs65Sgi0Uxz4QsKiiTsjSFsSEs=@vger.kernel.org X-Gm-Message-State: AOJu0YyX74s7MVXcKoPUIxyxCf/JTFpYL6LdvTa6U7FvJzJt9zHIK71I 2KnVp5z/w18w2JHJWh5mjHDmPVFpNcXE7mx5A1usQnPRz4Hne35ZErog X-Gm-Gg: ATEYQzz1PrzFBAXzc6XMPVpkh+Lv1Ub8S87d4pr/axmqZYFkv3DiOLaGS0WucnW8yjy stQfoYNUvJHzouNzq5uiMlTQ5VMuj7pKy7vFZDPQetoKnLmSEsVdyYPVj+oeSUcKj0cZWBicdKJ 1DG+eqXSf/xgqSiOrSqM5x8ePzC62wfYhrX2DG+e0tAsNceGkTswn5p8jETmzh+eRw2xRpKTPyC tt73WHqhNHXZdsqTn0hkvjkrpCrsp0tiueBufUwQGrRWRyMTuUb9vQCIdoedPpng6Vs7coAWlqw zKKHJD+Ed8o/q5XG4gW0KFa66ZET9W8MJ3i+tjIMGaG9vmpKJaZBmkH9pYHtndSbXs94R3bDA4C +8/UXLbx5zAWRpCNumtSQj3rmhF17Iy0rf60+CLkM+GouaDLkwGqAc0odQ6nD49KRy0WfWMYxs8 GCNJxStkbWelKaeYIkkS9RT5K92+1IeDblmo64/xVdmrJvIRD1ATXG4jGRMxQpjZ2BLLikHJ7/3 BpZajIInx74kvIpXnX8EzF4/WEIsH9dAIY7+bhkra1WTNlhaWc78EOWRVnwdm9njZeC2kS40l7S jH63ZuHfXoE= X-Received: by 2002:a05:600c:4f54:b0:480:690e:f14a with SMTP id 5b1f17b1804b1-485566f9258mr184228105e9.14.1773612839629; Sun, 15 Mar 2026 15:13:59 -0700 (PDT) Received: from mail.gmail.com (2a01cb0889497e00d7c89d4a4d184346.ipv6.abo.wanadoo.fr. [2a01:cb08:8949:7e00:d7c8:9d4a:4d18:4346]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541aa73dasm1127007425e9.2.2026.03.15.15.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 15:13:58 -0700 (PDT) Date: Sun, 15 Mar 2026 23:13:56 +0100 From: Paul Chaignon To: Eric Biggers Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v3] bpf: Remove inclusions of crypto/sha1.h Message-ID: References: <20260314214555.112386-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260314214555.112386-1-ebiggers@kernel.org> On Sat, Mar 14, 2026 at 02:45:55PM -0700, Eric Biggers wrote: > Since commit 603b44162325 ("bpf: Update the bpf_prog_calc_tag to use > SHA256") made BPF program tags use SHA-256 instead of SHA-1, the header > no longer needs to be included. Remove the relevant > inclusions so that they no longer unnecessarily come up in searches for > which kernel code is still using the obsolete SHA-1 algorithm. > > Since net/ipv6/addrconf.c was relying on the transitive inclusion of > (for an unrelated purpose) via , make it > include explicitly in order to keep that file building. > > Signed-off-by: Eric Biggers > --- Acked-by: Paul Chaignon > > v3: update net/ipv6/addrconf.c to fix transitive inclusion > v2: update include/linux/filter.h too > > include/linux/filter.h | 1 - > kernel/bpf/core.c | 1 - > net/ipv6/addrconf.c | 1 + > 3 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/filter.h b/include/linux/filter.h > index 44d7ae95ddbcc..e40d4071a3455 100644 > --- a/include/linux/filter.h > +++ b/include/linux/filter.h > @@ -19,11 +19,10 @@ > #include > #include > #include > #include > #include > -#include > #include > > #include > > #include > diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c > index 3ece2da55625c..f11ab6f354e2e 100644 > --- a/kernel/bpf/core.c > +++ b/kernel/bpf/core.c > @@ -16,11 +16,10 @@ > * Andi Kleen - Fix a few bad bugs and races. > * Kris Katterjohn - Added many additional checks in bpf_check_classic() > */ > > #include > -#include > #include > #include > #include > #include > #include > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 0e55f139e05d5..04c1e856bf7fc 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -34,10 +34,11 @@ > * status etc. > */ > > #define pr_fmt(fmt) "IPv6: " fmt > > +#include > #include > #include > #include > #include > #include > > base-commit: 1c9982b4961334c1edb0745a04cabd34bc2de675 > -- > 2.53.0 > >