linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sheetal Sahasrabudhe" <sheetals@codeaurora.org>
To: "Trilok Soni" <tsoni@codeaurora.org>
Cc: "Sheetal Sahasrabudhe" <sheetals@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
	dwalker@fifo99.com, bryanh@codeaurora.org, davidb@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU
Date: Sat, 5 Mar 2011 13:18:50 -0800 (PST)	[thread overview]
Message-ID: <abd1b409d545d4a3c24e4f0dedf56c6f.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <4D71F7A0.5010101@codeaurora.org>

Hi Trilok,

>> +static int __init scorpion_pmu_init(void)
>> +{
>> +	platform_device_register(&pmu_device);
>
> platform_device_register can fail. Better do it like
>
> "return platform_device_register(&pmu_device);

Good catch, I will update it.

Thanks,
Sheetal

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.



      reply	other threads:[~2011-03-05 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 22:09 [PATCH 1/3] msm: Add support for Scorpion and ScorpionMP PMU Sheetal Sahasrabudhe
2011-03-05  8:43 ` Trilok Soni
2011-03-05 21:18   ` Sheetal Sahasrabudhe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abd1b409d545d4a3c24e4f0dedf56c6f.squirrel@www.codeaurora.org \
    --to=sheetals@codeaurora.org \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@fifo99.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tsoni@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).