From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FD983A14 for ; Mon, 16 Mar 2026 01:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773622934; cv=none; b=sEakDxa9m+BC9I1MJ5F8Vf0VKPp8lylsrzDdCao0iv5FO7zMibKq0T/vIGZbk8toYT2VlY32Nz2MfWIMRzaQZlLdLM+HqAaJlyMl6co7ST9P2iKk7pBJwRalFN/l31bn/HxDyb1tIdaokQpne/As7QeSBJzSPMxNgmO5HnPd2RI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773622934; c=relaxed/simple; bh=Eky1nMoAs0udEY/YyYt5887/RWDwMv3LBHaMdNwTh0g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s8uPKj9VuKiCv7l6TPug25bl5YvdmAEqzwZmK4VlgK3k4ULAKqeVdJF34noq6kerg5vDiD6fdqunLLureXWVoE3IEW8bLVG/LRpoXW1KJ9dRUa/VO/1WxWEmT3HCejF2exRdOy5C3mGhtcfBZVBg7rPas9tkhe0Ikb2w36uQnfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jQ78TELj; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jQ78TELj" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c736261ee8dso1304073a12.1 for ; Sun, 15 Mar 2026 18:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773622931; x=1774227731; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YLOS+CBHAqth4oLgPzOQhkefjgoFRG3KFqew2fphAF8=; b=jQ78TELjF288JW/RtJknI1X8/y8fKQhIGJuJe04ZvBM0ZudTwE/OWs46b5ptm2ipdC SOE+sjsMRK+BAzgaSzulO0/SZ98eMwJbT9dlJ+OQh46UbzNiBFIqM0UmzLJwAcYzuI25 /STGqVeQlSJhC3ZaUb7HmvV9xEWft94Y9mO7gZax2I2KCZOiijhgyJC88kBQ5283/f+q f2bmNPS5JspfMtpdf8Q0ikrluxykkZsZ9byg07DvE0GKQBk/paXe9BmAFYm3JXA8c807 Nps/aUqrBy39tGdlur3D3etiIukfd+9RhR+QnTA014vfxcbLwQD3hlFYpHoMeHH+zarS PGcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773622931; x=1774227731; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YLOS+CBHAqth4oLgPzOQhkefjgoFRG3KFqew2fphAF8=; b=X+G4EBRM8Q3927p6/Jw3Oj+LHE6qqZsDfnJM3ULVR8nrj04yR8AnOoTKcEWYd7rETT iEZlPtTZbipaALOxUlwTZnbxyBdAWESw+vboUgwkwxdApt580UdCDSl24ckalE/frsz6 LZg9H+I4WRWjvQKCs/9U6hH4Vz+u4JBFL++tWK5AdUI381ZQuakKyXLSMday0yDbPOc3 MTqK2nQexicu0z38iJFVXa8NCaxtEowGZinQsa5im0i4AenX8LFMJAD42rhd9gc0uUNo wYHWlLnslDSUDumykytSq1svdxl44cU/Ux8C/m6DqNX26ApW/h0mibl/3Fuvif5jWpZa aafQ== X-Forwarded-Encrypted: i=1; AJvYcCXxKnolO8XfU7eHYOsZ4dFQJm6u/XvI1JfRDcVAX3E9bKvRdr3LxJ6F1JEEfKqjtcs2Egthx5IiEh2MAVI=@vger.kernel.org X-Gm-Message-State: AOJu0YxZIp5CB3cZlCvtKO2FukAU3k43f/ebotckNO+ppFbmOEMeUXXY wbtkqUz8/OdpNiUM6kW/nD3kudT1pYdv7r+UyyfOJ6PigqdMjeLIozq6 X-Gm-Gg: ATEYQzxu3e+H6iiJjx2eletipOKo0YyVoRVeTpX5aDUDVips3Q97Twg/2J6fr8m3OrU RZvvtCxQ87Bpbxq31y1js/ht80gBnLBAocHQ3yEdw8JHjGCp3lnr6BKf4RbKOvXVATUPRjnTPvK AL5LxO1l4/mA3qDmJ0IaXzQ74oDM/kti1mQ4Mbd7HsVesIxdy7hVRKMKTpuur3uGXOTcGiRgvkE Zw+/gKSzWyXw86/nDE0+U1Fze6NO3qhmk6M6rr44Wlj+j69LZRUE6sSTGCC90EcV0OeISupjul+ 0Nw0orPoVVUrFYYlgrxPenyAf0bFt+ss+qvPCB7bvljdtUjGtEfy0LOqvSlzzT5EC6KcVL+St5m f4qTnqCnE0OknJcjimtBdWiGz+BqmqGsaSo3+fKRX7DvY/mMzfnUQ/XYG0VXpEuKCAdkSDTfzY6 WMF7sXpe/Dsv8umTRE6ZsubcSYR8viHlKXpZ/jKA== X-Received: by 2002:a05:6300:6713:b0:35d:6b4e:91f1 with SMTP id adf61e73a8af0-398ecca4e41mr10054657637.34.1773622931501; Sun, 15 Mar 2026 18:02:11 -0700 (PDT) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c74029fa6eesm1891891a12.20.2026.03.15.18.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 18:02:10 -0700 (PDT) Date: Mon, 16 Mar 2026 01:02:01 +0000 From: Hangbin Liu To: Simon Horman Cc: jv@jvosburgh.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, sd@queasysnail.net, andrew+netdev@lunn.ch, pabeni@redhat.com, sridhar.samudrala@intel.com, jiri@resnulli.us, bridge@lists.linux.dev, edumazet@google.com, kuba@kernel.org, razor@blackwall.org, idosch@nvidia.com Subject: Re: [net-next,v2,1/4] net: use ndo_set_features to set offload features for bonding/bridge/team Message-ID: References: <20260313-offload_compute-v2-1-ffbc8ce5d50c@gmail.com> <20260315161943.1419237-1-horms@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260315161943.1419237-1-horms@kernel.org> On Sun, Mar 15, 2026 at 04:19:43PM +0000, Simon Horman wrote: > > diff --git a/net/core/dev.c b/net/core/dev.c > > index f48dc299e4b2..16b3fc620807 100644 > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -8920,6 +8920,9 @@ static int __netdev_upper_dev_link(struct net_device *dev, > > __netdev_walk_all_upper_dev(upper_dev, __netdev_update_lower_level, > > priv); > > > > + /* re-compute all features after adding link */ > > + netdev_change_features(upper_dev); > > + > > return 0; > > > > rollback: > > Can the feature computation skip updating ancillary fields when features > don't change? > > The new architecture routes computation through netdev_change_features() -> > __netdev_update_features() -> ndo_set_features(). However, > __netdev_update_features() has this check: > > net/core/dev.c:__netdev_update_features() { > ... > if (dev->features == features) > goto sync_lower; > Ah, yes. In the RFC patch set[1], I wanted to use a new ndo_update_offloads callback to handle offload updates. But in the formal patch, I thought we could avoid introducing a new callback and use ndo_set_features directly. However, it looks like we need to fall back to ndo_update_offloads now. [1] https://lore.kernel.org/netdev/20260226114208.27774-1-liuhangbin@gmail.com/ Thanks Hangbin