[PATCH v2] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[PATCH v2] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[Joshua Gu]

Fix checkpatch.pl warnings about spaces after casts,
along with other double spaces.

Signed-off-by: Joshua Gu <joshuagu789@gmail.com>
---
Changes in v2:
  - Removed double spaces after assignment operator in rtw_security.c

 drivers/staging/rtl8723bs/core/rtw_security.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index 54e89f192b18..b98bc1aa9cbe 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -658,8 +658,8 @@ static void construct_mic_iv(u8 *mic_iv,
 		for (i = 8; i < 14; i++)
 			mic_iv[i] = pn_vector[13 - i];          /* mic_iv[8:13] = PN[5:0] */
 		#endif
-		mic_iv[14] = (unsigned char) (payload_length / 256);
-		mic_iv[15] = (unsigned char) (payload_length % 256);
+		mic_iv[14] = (unsigned char)(payload_length / 256);
+		mic_iv[15] = (unsigned char)(payload_length % 256);
 }
 
 /************************************************/
@@ -781,8 +781,8 @@ static void construct_ctr_preload(u8 *ctr_preload,
 	for (i = 8; i < 14; i++)
 		ctr_preload[i] =    pn_vector[13 - i];          /* ctr_preload[8:13] = PN[5:0] */
 #endif
-	ctr_preload[14] =  (unsigned char) (c / 256); /* Ctr */
-	ctr_preload[15] =  (unsigned char) (c % 256);
+	ctr_preload[14] = (unsigned char)(c / 256); /* Ctr */
+	ctr_preload[15] = (unsigned char)(c % 256);
 }
 
 static signed int aes_cipher(u8 *key, uint	hdrlen,
-- 
2.43.0


Sorry, I think my previous reply had the patch as an attachment instead of inline. v2 removes additional double spaces.

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[Ethan Tidmore]

On Sun Mar 15, 2026 at 9:04 PM CDT, Joshua Gu wrote:
> Fix checkpatch.pl warnings about spaces after casts,
> along with other double spaces.
>
> Signed-off-by: Joshua Gu <joshuagu789@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET

[PATCH] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[Joshua Gu]

Fix checkpatch.pl warnings about spaces after casts

Signed-off-by: Joshua Gu <joshuagu789@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_security.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index 54e89f192b18..9c580729a9eb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -658,8 +658,8 @@ static void construct_mic_iv(u8 *mic_iv,
 		for (i = 8; i < 14; i++)
 			mic_iv[i] = pn_vector[13 - i];          /* mic_iv[8:13] = PN[5:0] */
 		#endif
-		mic_iv[14] = (unsigned char) (payload_length / 256);
-		mic_iv[15] = (unsigned char) (payload_length % 256);
+		mic_iv[14] = (unsigned char)(payload_length / 256);
+		mic_iv[15] = (unsigned char)(payload_length % 256);
 }
 
 /************************************************/
@@ -781,8 +781,8 @@ static void construct_ctr_preload(u8 *ctr_preload,
 	for (i = 8; i < 14; i++)
 		ctr_preload[i] =    pn_vector[13 - i];          /* ctr_preload[8:13] = PN[5:0] */
 #endif
-	ctr_preload[14] =  (unsigned char) (c / 256); /* Ctr */
-	ctr_preload[15] =  (unsigned char) (c % 256);
+	ctr_preload[14] =  (unsigned char)(c / 256); /* Ctr */
+	ctr_preload[15] =  (unsigned char)(c % 256);
 }
 
 static signed int aes_cipher(u8 *key, uint	hdrlen,
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[Ethan Tidmore]

On Sun Mar 15, 2026 at 3:23 PM CDT, Joshua Gu wrote:
> Fix checkpatch.pl warnings about spaces after casts
>
> Signed-off-by: Joshua Gu <joshuagu789@gmail.com>
> ---

...

> -	ctr_preload[14] =  (unsigned char) (c / 256); /* Ctr */
> -	ctr_preload[15] =  (unsigned char) (c % 256);
> +	ctr_preload[14] =  (unsigned char)(c / 256); /* Ctr */
> +	ctr_preload[15] =  (unsigned char)(c % 256);

Since you're editing the line go ahead and remove that unneeded
whitespace:

	ctr_preload[14] = (unsigned char)(c / 256); /* Ctr */
	ctr_preload[15] = (unsigned char)(c % 256);

Thanks,

ET

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[Joshua Gu]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-staging-rtl8723bs-remove-unnecessary-spaces-in-rtw_s.patch --]
[-- Type: text/x-diff, Size: 1740 bytes --]

From 319ab64bc60820beedaabcd951cc9eb8f8c9bad4 Mon Sep 17 00:00:00 2001
From: Joshua Gu <joshuagu789@gmail.com>
Date: Sun, 15 Mar 2026 20:10:48 +0000
Subject: [PATCH v2] staging: rtl8723bs: remove unnecessary spaces in
 rtw_security.c

Fix checkpatch.pl warnings about spaces after casts,
along with other double spaces.

Signed-off-by: Joshua Gu <joshuagu789@gmail.com>
---
Changes in v2:
  - Removed double spaces after assignment operator in rtw_security.c

 drivers/staging/rtl8723bs/core/rtw_security.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index 54e89f192b18..b98bc1aa9cbe 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -658,8 +658,8 @@ static void construct_mic_iv(u8 *mic_iv,
 		for (i = 8; i < 14; i++)
 			mic_iv[i] = pn_vector[13 - i];          /* mic_iv[8:13] = PN[5:0] */
 		#endif
-		mic_iv[14] = (unsigned char) (payload_length / 256);
-		mic_iv[15] = (unsigned char) (payload_length % 256);
+		mic_iv[14] = (unsigned char)(payload_length / 256);
+		mic_iv[15] = (unsigned char)(payload_length % 256);
 }
 
 /************************************************/
@@ -781,8 +781,8 @@ static void construct_ctr_preload(u8 *ctr_preload,
 	for (i = 8; i < 14; i++)
 		ctr_preload[i] =    pn_vector[13 - i];          /* ctr_preload[8:13] = PN[5:0] */
 #endif
-	ctr_preload[14] =  (unsigned char) (c / 256); /* Ctr */
-	ctr_preload[15] =  (unsigned char) (c % 256);
+	ctr_preload[14] = (unsigned char)(c / 256); /* Ctr */
+	ctr_preload[15] = (unsigned char)(c % 256);
 }
 
 static signed int aes_cipher(u8 *key, uint	hdrlen,
-- 
2.43.0

Re: [PATCH v2] staging: rtl8723bs: remove unnecessary spaces in rtw_security.c

[Greg KH]

On Mon, Mar 16, 2026 at 01:46:19AM +0000, Joshua Gu wrote:

> >From 319ab64bc60820beedaabcd951cc9eb8f8c9bad4 Mon Sep 17 00:00:00 2001
> From: Joshua Gu <joshuagu789@gmail.com>
> Date: Sun, 15 Mar 2026 20:10:48 +0000
> Subject: [PATCH v2] staging: rtl8723bs: remove unnecessary spaces in
>  rtw_security.c
> 
> Fix checkpatch.pl warnings about spaces after casts,
> along with other double spaces.
> 
> Signed-off-by: Joshua Gu <joshuagu789@gmail.com>
> ---
> Changes in v2:
>   - Removed double spaces after assignment operator in rtw_security.c

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot