From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE85F366541 for ; Mon, 16 Mar 2026 08:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649481; cv=none; b=pI9j8M8y34pzfKvtLKR6I/Py3AbJcmU+xAo4MqBKpGHf4svNHzs8uWEaVqUgyPykofKr61R9MS5ta8xrdCPsO+plvCE8vjlAsbbRvZqWTYgT+1Lk0Cb9xSVxWImzSEXaRlbnSgfjiPgFJq9rb/MhylycYcYsmPs9JafBVA9/2o0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649481; c=relaxed/simple; bh=3miNijcwl8Jc3wYIr0XHhXDKC8OavmVDnnPlzDD8k7o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lkqqJnShn/IQdWj8Pj0svDq4kqAbvMGQ34xTy0HbvRTYb2bBLfeAuGYZyiRy+Ux2acPaZNY7IL5T7V8a8Auag4p1CSMQUqDBMcusk+uygKfIm5PKI6y99ZtBUbS4F+YSupTOBWRwNy4LtSLoaYjDaWlyey/Tld1uZAYNBjZBWoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zdAA2bTx; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zdAA2bTx" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-485345e1013so37570975e9.1 for ; Mon, 16 Mar 2026 01:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773649476; x=1774254276; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a3irUY7KhJqlEd3mK9i9xdShte5YmZbK2Krg9U/BlPg=; b=zdAA2bTxQPSy6atWNc1ac8c8UyfPM5/JEdw4Bl+TzBc3krGg7l5TWymSDclSrc6Lw9 nApLA39Cf9vIC8SpnNfrZHP1QsmiHcFS7f3Ld3H2wFRn+jCmdnFLxJ0IcQlsVbL4mp5/ w4YJXLPExw3HHs3hrCQKKIYT6L5u88SGRhVZ5rwlYVV1A0MIrH+vtv3KbtCDE7gKO86q wQXBZRpPkdINF1fgGmUOVn7mUvMG31qpYm2rfdG0s5FysxRayTrfUg51fG2ukjNgtNSJ edte7bnWm+SIr9mZehj3H0+2YLBJTgRPIWem2p/Yowj1aoqPDCKQBZdBg82J3Vjl6L9q TJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773649476; x=1774254276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a3irUY7KhJqlEd3mK9i9xdShte5YmZbK2Krg9U/BlPg=; b=lO1JM5VxSJuq+eikkFvXWnwAxKHCXwJ6en0mOx3+a0Z/UommiQ2pnTLlY+t/eGC7p7 PkAPwbtdYRSMGScdoGYYQDJNF8MaQY3l4UiGyWX9RN8OzhgrnbhCWZE/j+wWUdKmYDFt 6EPAHeGxLHWTJ5pY7xEGITqB6DRsy/VLf+uDTkNT7Wt2P1IAeE3N0DDKV7Qna+NiZtq/ XdLL/CGAbFpCPU0ENrNrIRNV7uAjYjtAF1Wo3r6d0UHetOOvKBlQqPCxSU0v+hFSRgsq T59hQ4XxeGsBAHw4yBrTeYbnvJXMwFf+KOnRyuF6G31rxUe9vjAQSE/qStV/+PpZvw/o 6LPQ== X-Forwarded-Encrypted: i=1; AJvYcCV3LOvurTBbE/XU40LAAy9ZCzWf7oLe1ROSXn/WzdfHjeudvs0bM2g4Py/bStA7f8QwEgQimUrHRkkkNSY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/sUOUo1/2ZV+srYB5MeWTQruhLM60Z0i/BX8dhghhdC1pyYO5 f/H0Cla/jR0a4l9L16WHfBL83wKXEkHDUT45BmMKAzNTEikSAwTAJxcl/uwLG3ezRd8= X-Gm-Gg: ATEYQzwNFeRJQ0GNqUcu1tvH9F+9jX+h0VYD7sI0v/trJYU4ZY6zjLQgrAvM/g35/e4 XjBOSITXr1d57HpF5qj4gNtNUSugRb4hnBF2g18v/Yk8VQxIY6jfk3uubWP162knAUELOh6Rzu3 apGqfLBDhj00clMpZ+j+ysq1R8glkaQbeDMyGY5SuL8Pc0zaDb/naFiuxzSVgUlYIj50BR6RvFe W2iM+EwKlEXx8SM/0Oxo+dbxfFzV9k/lGsOzRCqpTD8OE79soQWREJKR1ys3ahIUz+PUGOIzKxd qmxChy9zIT0ZUec0rxQ8+TTnBMBn69XHbREK0sHNdaBcmvcp3XRsKD+YcGQlGbJ9FaG0wlQsCRK ouog87/Ykjt7vb3wTKjSHca/n9R/SMF0W08eS+uNawqrf4F13PF0pXcewAqxD8PuwZjhjo47W8W tW+ehhXAVn3g6FRAz8U+m9E6YzOsW+ X-Received: by 2002:a05:600c:1907:b0:485:50ac:b8cf with SMTP id 5b1f17b1804b1-48555a5689amr196690125e9.0.1773649476013; Mon, 16 Mar 2026 01:24:36 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b5e92d5sm402893815e9.1.2026.03.16.01.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 01:24:35 -0700 (PDT) Date: Mon, 16 Mar 2026 11:24:32 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: media: av7110: replace C++ comments with C style comments in sp8870.c Message-ID: References: <20260313-sp8870-cleanup-v2-1-ca679e62f9b7.ref@yahoo.pl> <20260313-sp8870-cleanup-v2-1-ca679e62f9b7@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260313-sp8870-cleanup-v2-1-ca679e62f9b7@yahoo.pl> On Fri, Mar 13, 2026 at 05:32:18PM +0100, Tomasz Unger wrote: > @@ -490,7 +490,7 @@ static int sp8870_set_frontend(struct dvb_frontend *fe) > return err; > > for (check_count = 0; check_count < MAXCHECKS; check_count++) { > -// valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0); > + /* valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0); */ Delete dead code. > valid = sp8870_read_data_valid_signal(state); > if (valid) { > dprintk("delay = %i usec\n", check_count * 10);