From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 156D236C59A for ; Mon, 16 Mar 2026 08:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649521; cv=none; b=q53S6Bo1R67EQr2XrTmgM8TyVzwK/tng2gyVk2qTwUDksTGWPtzIUg1gj+QTySVWoIn5L6tCx87bRdQc7gltCCnIF5mFadYmVRshgPy9k+bOqJcrvJw+SHoGZqAwabqIcuA+PuQC2U1whUYUgu8GLz6F5OCcMR4tATmDgkkUzGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649521; c=relaxed/simple; bh=zM12fMXBkz/aGLdHAw4fO0MXnoU1d/pnk8/kCrsZuAw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SLBvJUPlnDhaUKRlgCHsdkMNVLlF/Ttg8zgc4mJ62k8UQSScxH8AkIY6cwinbpJlsLBKShM45QgpdaAHSM9Wh8Eu6Epfg+Z4UdBpJx6LrINJ5DyEoHzumhPgWrRp0H+NOT7ARyYQA79cll1th6kk4yfmxhjdpxwUckTrivy3Mgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eZnp3J9S; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eZnp3J9S" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43b3cfc38edso1553139f8f.3 for ; Mon, 16 Mar 2026 01:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773649518; x=1774254318; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KlLkAnNKGsU8T/jwAcNk/EsAb1/TAA3RavYRUsvMIn0=; b=eZnp3J9SBiQ8HtyJQMqlQiHBN3o6pyxp76y5UultNmcZcn3+TCu/XNn6bEtKYAbcPU DAG9z+dXVTSgXKufuIlTluWGVgFA5cH8IurEpsFih69H0Rn2BbqqoPLK6hVR4+KToirU PeUZgKhfidyCiFJxSnibyh9x8SQzOGtb7ZEjp10QhPIv4d7cWpdJv/Qqu92+ZThfKMJQ Z8Z/0KSoKXtQyHyxgyi8AF+qNkyam07iPSPKf7Y718gU4iGR3rRp3yFS4WYAPbDX3ZmE ZGrK41CZ004mrlVSkCcpFqXSlvFbqk5IFpLP4fAOEHpXqreas9dkxerDqB2Tc+9FbZYn w9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773649518; x=1774254318; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KlLkAnNKGsU8T/jwAcNk/EsAb1/TAA3RavYRUsvMIn0=; b=ljJxjU7uJlAx7v6I5FvihJt+a/FdX/ROIcmi5NaAsPrgr1mT3HRmKi75/2B7y8qe70 U770bNhbDTuYKThNmJBpTQTN+XQ1CcdXPrOzp3wcrCjKbfv+Vw5ih5Dg99HCbGpXNBpf fiL78pBhNq3mu0tHVR3jv7nv/MR/SMgERP+EwUPddBPRUQcZ8gAR9g5dTsuVAUYVFuCP X69hQ0dI6K3kpyuahqd73l+4bwOnvee/w6ynNog+eAlnpapVO3zBxFvzI7gtOuulxD1p rjwCqI3g/NpsqO1Wh1t61Nw9VWtDjoN5gMRUfb1T/uMB4YZBbfNZdTU06N+gVkVXjSUT OvrQ== X-Forwarded-Encrypted: i=1; AJvYcCVTt857Dk+Wu+qlGzyGApMEGeGFJ9YIUKY4ZaiEuTefcz72ctW0Eu21hhyq2Jb96HrWAgMt34f/SvujYJI=@vger.kernel.org X-Gm-Message-State: AOJu0YyQokBLXkiQEC7Hl+/K8iMYJBswx4cj0wC13RuYVamaeI1RvAs6 wWG5svV11o40QvZCncCox7PGPuEFfNZtGc7s2gcaexOv64BxnVgd8FEXVbiy40H67nk= X-Gm-Gg: ATEYQzzM7cBZDQ5CwMa5bmFhd4hYYx6q5WgdI6g080DrIAiTiacPjlUcRFl19fmXxUl hOfYuY1/GYhRd3/iZXr4ylEoCBfXlb2KGzAeRktiVmF2pFOmH/TL6I12sNtyudNdAmYs8u0caZW /90GSlscww5k4jqYiV7btR43aF7HbNI59HGpYxzgClvb1NO53SuCm8N9442pVNvqCiJ71xq80dx nbXOu/42ZRt2dp3iTUGt7ZfiG7BInUPD/FoDR8q0fTT98M8bnQfMVhPdEvs16TLm6NPIa1FTZQM WuQGNc8nNDi8TQuHdNkto2VrR6V1/DAMoY6hKTU8RI1PV5xBdOXv+a8r69ukwwwIktR2GckzfJr 4cvjUXDeeXeXSAoBHpjSQQC3enZCiNUt86YSm/YpBBYOVxDKILNLpmZUUn4Bb1rAC8Yxuskm/K/ fK1XMAU5yxbK4dxe8dfLDi+yg7uYtT X-Received: by 2002:a5d:5e01:0:b0:439:be67:a034 with SMTP id ffacd0b85a97d-43a04dc0c3fmr20758154f8f.47.1773649518277; Mon, 16 Mar 2026 01:25:18 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe19aec5sm40560973f8f.4.2026.03.16.01.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 01:25:17 -0700 (PDT) Date: Mon, 16 Mar 2026 11:25:14 +0300 From: Dan Carpenter To: Bera =?iso-8859-1?B?Wfx6bPw=?= Cc: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: Improve error handling Message-ID: References: <20260313163740.454-2-b9788213@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260313163740.454-2-b9788213@gmail.com> On Fri, Mar 13, 2026 at 07:37:41PM +0300, Bera Yüzlü wrote: > Remove unnecessary ret variable and goto exit pattern. The function now > returns immediately when an error occurs. Additionally, ensure that > intf_free_irq() is called when pm_netdev_open() fails to avoid leaving > the allocated IRQ uncleared. > > Signed-off-by: Bera Yüzlü > --- > V3: Fixed patch description. > V2: Used int_free_irq() in error condition. > V1 Link: https://lore.kernel.org/linux-staging/20260312131933.29505-2-b9788213@gmail.com/ > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 28 ++++++++------------- > 1 file changed, 10 insertions(+), 18 deletions(-) I responded to v2. Same comments here. regards, dan carpenter