From: Dan Murphy <dmurphy@ti.com>
To: Luca Weiss <luca@z3ntu.xyz>, <linux-leds@vger.kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>, Icenowy Zheng <icenowy@aosc.io>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <mripard@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH v2 2/2] leds: add sgm3140 driver
Date: Sat, 4 Apr 2020 08:56:01 -0500 [thread overview]
Message-ID: <abecc052-e432-fe4d-b2dd-eb3a35b754fb@ti.com> (raw)
In-Reply-To: <5847770.lOV4Wx5bFT@g550jk>
Luca
On 4/4/20 4:36 AM, Luca Weiss wrote:
> + fled_cdev, NULL,
<snip>
>>> + &v4l2_sd_cfg);
>>> + if (IS_ERR(priv->v4l2_flash)) {
>>> + ret = PTR_ERR(priv->v4l2_flash);
>>> + goto err;
>> Not sure why this is here you are not in a for loop and this will fall
>> through anyway to the err label.
>>
> I kept the goto in, in case more code is added below that statement so the
> author doesn't forget that this error needs to be handled.
> If wanted I can remove it of course.
>
I am ok with all the reasoning in the previous comments. This one I
would say just fall through to out.
If there is other code added after this then it can be added in.
Dan
next prev parent reply other threads:[~2020-04-04 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:47 [PATCH v2 0/2] Add sgm3140 flash led driver Luca Weiss
2020-03-30 19:47 ` [PATCH v2 1/2] dt-bindings: leds: Add binding for sgm3140 Luca Weiss
2020-04-03 17:21 ` Dan Murphy
2020-04-10 17:41 ` Rob Herring
2020-03-30 19:47 ` [PATCH v2 2/2] leds: add sgm3140 driver Luca Weiss
2020-04-03 17:31 ` Dan Murphy
2020-04-04 9:36 ` Luca Weiss
2020-04-04 13:56 ` Dan Murphy [this message]
2020-04-04 9:58 ` Andy Shevchenko
2020-04-05 18:45 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abecc052-e432-fe4d-b2dd-eb3a35b754fb@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=icenowy@aosc.io \
--cc=jacek.anaszewski@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox