From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9CF934F48A for ; Mon, 16 Mar 2026 07:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773646623; cv=none; b=iv6/5zV7fhWZkIcrMysXyjSilueCQ/J7d+6Ob0w7zgmypqHb4rsHLD940NA39AQ7JVo3wpneIgqzPhMwah4CVzcwcw+LK0JMZvQX8BVFCx9Wcd24a0j+Olh+pYIfhT03Wt+amF3UPvdr/o56/I9sLk20nZq+E8aUqJR+NiTkQbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773646623; c=relaxed/simple; bh=6I4x1JgNvcxEnh6IssrXrKnX30z6/rrdsN/hC3MomSE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OYPlzErEG/ZDelnfjWnS6LBE/1W1JaSgAfBs3SfLGczUJoj4+6qt7z6JtZgYwDnrY9gh/jWREZ0SIICu9WLuANHleSJS0/0aZzWpbuyPgsHsc6DMDBt94RazBWVr0RPQhFABRrcvRbtLRjaqwxexKAnA6ROvxS2bGkvhwlrYO9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UN8oyW7n; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UN8oyW7n" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4853fd7b59aso25267195e9.2 for ; Mon, 16 Mar 2026 00:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773646620; x=1774251420; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/8R5+6xWTjhUsYZA5f4QhM5GoODRRoehXbOY+MUE7yc=; b=UN8oyW7nA8NYQ7IUHcRy/vkwi+NYoFgeToqhjb+iRV3EZ1MKxlbOLopGGy/6zXYHxY 39HWWVJuKO25xTM405CqaBhFndl4Fz0XUHQrKFm5sRfbR/23mgdAQrBkurySYyoxVimV JC3h2bekudkvClSua4ZiWXl/+B/p3XZJsLnUmSuyvH0lpK4tI48H38LdkcDjdsTtK8zS RwGgETP/CPbPkZbqCK9nAghQVl7lRYMyYvRL6+97oMhFAVykKshla4/zGdstf+1ClOB/ r5q2rZ3J55OCEQCDCN5d4UvBl7Ipx4yj8fR6vKGhY9wavscEY9A5rCPD7dIaHs+fnTYi Fviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773646620; x=1774251420; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/8R5+6xWTjhUsYZA5f4QhM5GoODRRoehXbOY+MUE7yc=; b=Y4bJM2z40DuYGuLjLM2RYOFcay2tJrsl5dD+FAVFezmJCx63//NDliu1bMFZgsiJ8z GYuSXiVOd/LJ0dxPBRXHg0+ENbc5f94GUVfMZkLl2YMjnc86oQ15ToptrslxwrSizGMQ 9uonFKgwOVh8OTb+kRNkIEaYtVqt75r0pW/GLqs0X1+TCS40L5fpMdhgj6AqzTDPWipR olx0ApwqbhvVRIU7WVjy1SQOAzxP4ByPyv6lqnX1sT5hgYXXSwiFxqL9NywkXCxmKxAw 3mQaP4+XgpoUlv3WZmvzQcqgnHqs1r3kQ8bp4HM82Cj3QXOq25zbuvSg+SLcgBB/q55+ yDzg== X-Gm-Message-State: AOJu0Yzy3v5F1WvmjXLjQePvoH9b2148ahDoOt3+nyPrebgiuyTKlu6N C8GsqUdABHPkbjIY3UODxp8XZBeLpnU4QRJgvU7j18kstiG0E3w+bAQTiaHrQ8dXJGQ= X-Gm-Gg: ATEYQzxgFFSwICzVPz9QgBnATgvseXgJxtR9ooYyOPusNJIGnU55DCvNx6tRQfUM4RI xEW+qX0PdcmcZD3fOaRjQ9frVOv54vN4OwGeTOid2PQiMyz0ng7CpQwfjPJ5aSc2CnIFqsWb8ln q7hw4nVt3jdpSD7HWIi50Q4BD93dE6Z12rg0Mkn3A6W133tORvEkfINbpY32ucEuZsbPhuPJtfn 6TCzwMVBV62By7sijAbCUGD4SbftAnL1qlEQg3pSMcr2584DmozbOOVEQdIO3oyR19ZHPH64pCl WJYaDZ+vB4h0Bu3okwVJxzCeSucqUChznUxPKGHeTU9GD0bE0K0cRVN/Y2brRGc9RfxBgYE1/iX B5TDqb6sbaPnUw+3uzGQvAOieyUyBNIFrU/dUXk6N37qjb40XY35AVC/ZzFMYfnApZJjdqWCXWd +g7gV/shf3FyI7g083clGqzNCJ9IYQ X-Received: by 2002:a05:600c:4fc6:b0:485:3fc8:de9c with SMTP id 5b1f17b1804b1-485566d520cmr183873595e9.12.1773646619872; Mon, 16 Mar 2026 00:36:59 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b5f6c24sm373669035e9.5.2026.03.16.00.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 00:36:59 -0700 (PDT) Date: Mon, 16 Mar 2026 10:36:56 +0300 From: Dan Carpenter To: Damien =?iso-8859-1?Q?Ri=E9gel?= Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, Greg Kroah-Hartman , Alex Elder , Johan Hovold Subject: Re: [PATCH 2/2 RESEND] greybus: raw: fix use-after-free if write is called after disconnect Message-ID: References: <20260311212511.82563-1-damien.riegel@silabs.com> <20260311212511.82563-2-damien.riegel@silabs.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260311212511.82563-2-damien.riegel@silabs.com> On Wed, Mar 11, 2026 at 05:25:11PM -0400, Damien Riégel wrote: > If a user writes to the chardev after disconnect has been called, the > kernel panics with the following trace (with > CONFIG_INIT_ON_FREE_DEFAULT_ON=y): > > [ 83.828726] BUG: kernel NULL pointer dereference, address: 0000000000000218 > [ 83.829288] #PF: supervisor read access in kernel mode > [ 83.829528] #PF: error_code(0x0000) - not-present page > [ 83.829828] PGD 0 P4D 0 > [ 83.830126] Oops: Oops: 0000 [#1] SMP NOPTI > [ 83.830753] CPU: 0 UID: 0 PID: 140 Comm: raw_chardev_tes Tainted: G C 6.18.0-rc4 #212 PREEMPT(voluntary) > [ 83.831260] Tainted: [C]=CRAP > [ 83.831426] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.17.0-0-gb52ca86e094d-prebuilt.qemu.org 04/01/2014 > [ 83.831912] RIP: 0010:gb_operation_message_alloc+0x14/0xc0 > [ 83.832366] Code: 00 00 00 00 66 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 41 56 4c 8d 72 08 41 55 41 89 cd1 > [ 83.832979] RSP: 0018:ffffb73f0027bd58 EFLAGS: 00010286 > [ 83.833247] RAX: ffffa44741f72300 RBX: ffffa44741f72300 RCX: 0000000000000cc0 > [ 83.833513] RDX: 000000000000000a RSI: 0000000000000002 RDI: 0000000000000000 > [ 83.833732] RBP: 0000000000000cc0 R08: 0000000000000000 R09: 0000000000000000 > [ 83.834044] R10: ffffa44741f72300 R11: 0000000000000000 R12: 0000000000000002 > [ 83.834267] R13: 0000000000000cc0 R14: 0000000000000012 R15: 0000000000000000 > [ 83.834533] FS: 00007fead7859740(0000) GS:ffffa447a31bc000(0000) knlGS:0000000000000000 > [ 83.834776] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 83.834974] CR2: 0000000000000218 CR3: 000000000216b000 CR4: 00000000000006f0 > [ 83.835259] Call Trace: > [ 83.835983] > [ 83.836362] gb_operation_create_common+0x61/0x180 > [ 83.836653] gb_operation_create_flags+0x28/0xa0 > [ 83.836912] gb_operation_sync_timeout+0x6f/0x100 > [ 83.837162] raw_write+0x7b/0xc7 [gb_raw] > [ 83.837460] vfs_write+0xcf/0x420 > [ 83.837615] ? task_mm_cid_work+0x136/0x220 > [ 83.837784] ksys_write+0x63/0xe0 > [ 83.837946] do_syscall_64+0xa4/0x290 > [ 83.838097] entry_SYSCALL_64_after_hwframe+0x77/0x7f > [ 83.838359] RIP: 0033:0x7fead78e9cc7 > [ 83.838712] Code: 48 89 fa 4c 89 df e8 08 ae 00 00 8b 93 08 03 00 00 59 5e 48 83 f8 fc 74 1a 5b c3 0f 1f 84 00 00 00 00 00 48 8b 44f > [ 83.839190] RSP: 002b:00007ffece5c3de0 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 > [ 83.839489] RAX: ffffffffffffffda RBX: 00007fead7859740 RCX: 00007fead78e9cc7 > [ 83.839675] RDX: 0000000000000006 RSI: 0000563d13f96326 RDI: 0000000000000003 > [ 83.839892] RBP: 00007ffece5c3e38 R08: 0000000000000000 R09: 0000000000000000 > [ 83.840112] R10: 0000000000000000 R11: 0000000000000202 R12: 0000563cf8925128 > [ 83.840350] R13: 00007fead78596d0 R14: 0000563d13f96320 R15: 0000563d13f96326 > [ 83.840635] > [ 83.840824] Modules linked in: gb_raw(C) > [ 83.841311] CR2: 0000000000000218 > [ 83.842009] ---[ end trace 0000000000000000 ]--- > > Disconnect calls gb_connection_destroy, which ends up freeing the > connection object. When gb_operation_sync is called in the write file > operations, its gets a freed connection as parameter and the kernel > panics. > > The gb_connection_destroy cannot be moved out of the disconnect > function, as the Greybus subsystem expect all connections belonging to a > bundle to be destroyed when disconnect returns. > > To prevent this bug, use a lock to synchronize access between write and > disconnect. This guarantees that in the write function raw->connection > is either a valid object or a NULL pointer. > > Fixes: e806c7fb8e9b ("greybus: raw: add raw greybus kernel driver") > Signed-off-by: Damien Riégel > --- > resend: added linux-staging as Cc, this list was not part of the first > submission. > > drivers/staging/greybus/raw.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/greybus/raw.c b/drivers/staging/greybus/raw.c > index b92214f97e3..aa4086ff397 100644 > --- a/drivers/staging/greybus/raw.c > +++ b/drivers/staging/greybus/raw.c > @@ -21,6 +21,7 @@ struct gb_raw { > struct list_head list; > int list_data; > struct mutex list_lock; > + struct mutex write_lock; /* Synchronize access to connection */ > struct cdev cdev; > struct device dev; > }; > @@ -124,8 +125,8 @@ static int gb_raw_request_handler(struct gb_operation *op) > > static int gb_raw_send(struct gb_raw *raw, u32 len, const char __user *data) > { > - struct gb_connection *connection = raw->connection; > struct gb_raw_send_request *request; > + struct gb_connection *connection; > int retval; > > request = kmalloc(len + sizeof(*request), GFP_KERNEL); > @@ -139,9 +140,15 @@ static int gb_raw_send(struct gb_raw *raw, u32 len, const char __user *data) > > request->len = cpu_to_le32(len); > > - retval = gb_operation_sync(connection, GB_RAW_TYPE_SEND, > - request, len + sizeof(*request), > - NULL, 0); > + mutex_lock(&raw->write_lock); > + retval = -ENODEV; > + > + connection = raw->connection; > + if (connection) > + retval = gb_operation_sync(connection, GB_RAW_TYPE_SEND, > + request, len + sizeof(*request), > + NULL, 0); > + mutex_unlock(&raw->write_lock); ^^^^^^^^^^^^^^^^ I feel like we need to do a get_device() here as well otherwise the put_device(&raw->dev) in gb_raw_disconnect() could delete the last reference and free raw. I have looked at this and I feel like what I'm saying is reasonable but I don't necessarily know how the reference couting works for cdev. Please feel free to correct me. :) regards, dan carpenter > > kfree(request); > return retval; > @@ -186,6 +193,7 @@ static int gb_raw_probe(struct gb_bundle *bundle, > > INIT_LIST_HEAD(&raw->list); > mutex_init(&raw->list_lock); > + mutex_init(&raw->write_lock); > > raw->connection = connection; > greybus_set_drvdata(bundle, raw); > @@ -238,9 +246,9 @@ static void gb_raw_disconnect(struct gb_bundle *bundle) > struct raw_data *temp; > > cdev_device_del(&raw->cdev, &raw->dev); > - gb_connection_disable(connection); > ida_free(&minors, MINOR(raw->dev.devt)); > - gb_connection_destroy(connection); > + > + gb_connection_disable(connection); > > mutex_lock(&raw->list_lock); > list_for_each_entry_safe(raw_data, temp, &raw->list, entry) { > @@ -248,6 +256,12 @@ static void gb_raw_disconnect(struct gb_bundle *bundle) > kfree(raw_data); > } > mutex_unlock(&raw->list_lock); > + > + mutex_lock(&raw->write_lock); > + raw->connection = NULL; > + gb_connection_destroy(connection); > + mutex_unlock(&raw->write_lock); > + > put_device(&raw->dev); > } > > -- > 2.52.0 >