From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9341720FAAB for ; Mon, 16 Mar 2026 08:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650347; cv=none; b=IhS58wdoCbEl7ThOwVI7MjxPbDSjf7NigjDUj8VW8ujnD+5inbB8Aj7X/AuPo80+cAXGgvOjRt+GXiGqZnGs6jaJrGjhz8pZ0PE+BRh94AJ9twGhLeL69cpHIedlR4f+AfKONFMDBYBdMjqQDoKfzY88svWEIga+0TBvdCjX5BY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650347; c=relaxed/simple; bh=WmACGjpJUyrlIhAuLH3s37LBu5hERSx4CXAxIyHWZtQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QBWMpE/tdMM3lPvmBJ3HFGnBH77VZIskIUx2uGr8KdASgs9A/AZtfCHDYjkAnM5KDgzCHGrgo1vlVR8QNtQXlITgWkWlEL6wLlyehX76rmFMINXju3hWppUS+dVtXfMDMQ/TsuEq3WhASCYG1uUBj3KPe9zGoJySJmnLFqDY4hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dYWB+fsW; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dYWB+fsW" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43b44c0bcdbso561083f8f.1 for ; Mon, 16 Mar 2026 01:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773650344; x=1774255144; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yEABYwNdY6HId95UN7nvcrERhrxtkbIlOTy8nffmn4E=; b=dYWB+fsWgXTNRat2LulcGP+VUaMFlIfW87vxNXm3WAPntLe6SItNUs3HuJ8RRaVypU U9TzeHoqOiVuz/lqK6pEvS/e1nUxl+W8akSjQNCgs9TcnDe/nSxVO7EgxB2LXgaXLKjm b9X8Gnq5CbHhrcznmBdSWbPJcRFAUS60sjcHrsYfzVqSbV6vhE7dMiWmI7wF+blqMyCC cQZuFZRvHQ3yPZETZ4yT92B5d6LeLam85dJ0a9dTHBBTYGrZgG4g3jtDzU4DIbOXYJmV O2788m20xgFgUAJfj7FeYJ79JsWKKLLvdk6T8THffRyhNs/cLY+75uuBTV3LOJQHKu/E pO5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773650344; x=1774255144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yEABYwNdY6HId95UN7nvcrERhrxtkbIlOTy8nffmn4E=; b=NGlLq7g9S2/ACN4VaEEvLxWMtONkShQKqNKRQQKpYMz0AaRck/7Ol/u7mBoWfHs5Rc /pu5Wiykfki06omKbqup6SicPwb+tvm1Uk4Sp7y10hReG2ofDcwXdM25Sna+TSQYSmB8 dY59o4LofHY+l+VXptYJx/Lcrk7kDlXngpTl+E3rKX2402g/jqgVSJA+9/MrWMHZm4E+ V9i6vWIudvgAB/HC+KHQhYRxnQuM1kftPeIOX3BjOWO/TRl2hASoL3oWU7YZoygUVRyh P4fEmR23sRaB/UmWvTfBoNXPka7pHYGwer3atU1eRk/eU8t0VOXFLJRcdrct4m/4wBfJ lEuA== X-Forwarded-Encrypted: i=1; AJvYcCXLWo1orjwguQZPfQsuQ/xsoRriP/ciBE4VukXtNGR0vhvs0TvjGpuPsjYCqt9l8wMu9Ndcxz+qa214eXA=@vger.kernel.org X-Gm-Message-State: AOJu0YyIJXGw5WJygwUFO+mq+LABoDT0tqkLxnlXAsEhcMRZJC93TZWd dD9CweCUz6BdVlCsFVAhNMcVezYjIWtFU6PnpA7Skd23OqLqW8ZIDGjQnnnsppvryzWh6o78Y57 cDkut X-Gm-Gg: ATEYQzzHiIZCzU81BAbHbX/VWYFH17zqG9sB6TIVfzoyImK9uIaTaChqqpUO+sQ0Gfm LWhQ0Bg4evIQtrIrS0ojFD9v0RbhTvCNy2GOVUDGmKqTeGRCvRahX9qoYmcRNYR+ejuE28NmVt1 e5/qfTrq+eqo/XI47Rh1I1h9/Uh7TNYwc8AIXp10Q5vPF9WPlYymOc1naXqQEtX7PVBbtWpd/rh lNOwo7CuIuOue+/P7shUHrIhHlPQzEu/IoktyAHNigdhryMOcTmXz7N67yGo/5tXGpz1ZMkATpc zDnGRmaoqDxo5uo7KfajndoSDOe5xvUmPfCfRRfTEbKjGna9hL+QiO2r0ICdKHjRfYz2J1ebgjh yMYqQ5512+xtGAZUet4XogtjKmZfj39n7UDidrBT4jP+cLLWDScJVwZwWnmTLl8viyDnmVV2iO0 fc7tX3UY6o+zw76Zi+QaVJyNOKAM8q X-Received: by 2002:a05:6000:4312:b0:43b:436d:782c with SMTP id ffacd0b85a97d-43b436d7ab2mr5103239f8f.4.1773650341793; Mon, 16 Mar 2026 01:39:01 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1abf84sm36422187f8f.14.2026.03.16.01.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 01:39:01 -0700 (PDT) Date: Mon, 16 Mar 2026 11:38:58 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: rename 'status' variable to 'ret' for consistency Message-ID: References: <20260314165600.17146-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260314165600.17146-1-omer.e.idrissi@gmail.com> On Sat, Mar 14, 2026 at 05:56:00PM +0100, Omer El Idrissi wrote: > The kernel commonly uses 'ret', 'retval', 'err' etc. for return value > tracking. No functional change intended beyond style and error handling > improvement. > > Signed-off-by: Omer El Idrissi > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index d664e254912c..dbcde683789d 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -345,7 +345,7 @@ static int rtw_drv_init( > struct sdio_func *func, > const struct sdio_device_id *id) > { > - int status = _FAIL; > + int ret = _FAIL; status is actually better because these are non-standard error codes. First fix that, then rename the variables to ret. regards, dan carpenter