From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FADC38237E for ; Mon, 16 Mar 2026 08:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773651536; cv=none; b=t1p/es9YlBhmbNA+qBpTLK5DCgbKFTV1UQ3zIzDBYs+1vsjhn/2dq5Yk00mXl8NJX7kA81tnFd0mmNgL12RIGS58U1OiOyhuNRPO5wr5gBpltM4aD7TAG8D2qhNR83tzVEc8qsnCQ+Ix9BQ309h3R7IzyLKnJoPqnSxmsCaCj0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773651536; c=relaxed/simple; bh=1BYliLq2TTPEeDtry+DsopBfwW0/Cn/6nX0TqfQlMh4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XQxm1NUWytB98rzEe+LS4/QOydgTtyV0EWbU/1XLIMh3V9ZF815yBsFiT4rL6uI6vDI3DMVb2Zh9UnbAhCSDA4vA/QHNY3AM2SmM1wO9q2iWi6Q3cOgcB+vqX/gDiXk81iFkCd6OZWWCHt5Inl0y6yodeECERu0pslaGo4Sq3cU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jIsUVOAM; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jIsUVOAM" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4855dbfc129so19130475e9.0 for ; Mon, 16 Mar 2026 01:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773651534; x=1774256334; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QBu0+9wxUCwZKF4FY2ZZBfYgZz2RjayUk/bVzSL+weA=; b=jIsUVOAM8EhJ8rBBtIOVhlUgMnl5ygnKpSpbzJrROjkatNzIga5sM4WsQim8Bdqp4q b4xuNpIb0tqPGCou+ik+YS6VornnHkR3wIfOpmWlPZCeFWCGkpWhTqF3l52OdPYZhZUR dmoRXeYM7rPXCMunbfMQFI1JkPPNyK+1j83YKjNHdjn+klvUsWyjOinomO58y4SU34rg qVgpZcFVX8DoatuCF45JkQ3ZyBMrEH2tZLzcEvRwY0mUc/aW3+Gn+BiU+yF/+uptW6YI mbjNZ1jbw4EYpejvZtZjfzKYsQlQgGC3XwBjfpxX3q+S5sTZQrm+v5SHlPY7FT+hZiFw h1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773651534; x=1774256334; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QBu0+9wxUCwZKF4FY2ZZBfYgZz2RjayUk/bVzSL+weA=; b=VsSYMlzE+LhdTC1j3nxEsGaKrU0GjpH4w+/C6aV1cV16y5Zw347MMo9os8FzZWERBJ QuCm7m/3HrUkgybGhgo4V79LtsvSFTtFEAxRjvnT0YXVOtbXor00C4dqZgIQhkvBMNmX KV3tfOy2iQB1mHIz1hWRGVa60J0L8afBktcAPDOT6yqTH566UYV5J65fnhCWKElefMy/ OYZvbTAQPlfaxZX5G4Xc7a1EFD8bWnH0REzw/BCOk3UpK/bMNjJb/uIhvIrLujub5DNh 0q66ucmvfolv9EylEqw4D5MfcvCxczKIQOkY8J0KXEJGnlZuaKZQX9fGko94eCqrPhnK LAFg== X-Forwarded-Encrypted: i=1; AJvYcCWYlJDV7bIgnYd+0Te5bQfaXlZsxJ1Cpk99IfhI19kdXtxf+9UPJF2uot8W/EhkZZ9kIgc6BKWmEnd0+2M=@vger.kernel.org X-Gm-Message-State: AOJu0YzzrKhDw9u5X55INsMzW51Mhk5RclzvgeNaQjpKAHWKYnkqf/lV cuolxrQYAiFzr4IF7eemzyOEUkjIcXNl9OFb0hezdP7IAN6dpW8hdIZTNXS14FCx6ac= X-Gm-Gg: ATEYQzx4lC1zfMirWQFyXxWjmtp+W5P1r0J+9PnvG1hzfFxsofdAzm33gR4blMTFwXz skFFPcr28vwMEHTpeqwSja4jvELFFC1jGHXDp4FLXgfJB+qJiJMQprksY7vuLDlnG2gpb5QwVN9 UVWmv6FwXyBeDtcjXw7GrIZWOVMcybS3DgItu1wEBWPeNSb2gbbZ5pljTbiEF/QXeoUFGFNtYSY zIJl0fd765/rLJaBEy8/Wus14D5nmYMxSuKCw1k23CbUcSgtqZAxN7OSSQapJFAYY83h0mZGru3 VZvlViJuiSeBP2urNaXFUkC1swYOx4s+FLPAaJjHDym+qC63RxVbrcy8sMn+ZY8i91V/4ZBVumr 28Tfm1pJlqy2wLE90IJ6A+lEWkfefoAH8snw3awugk2d7ph0E7Nh8nnwbDmp1GSn+ZQQ35JRovh Cx4LBYKacxslnoFNQ+IgD/PLM/wK6Z X-Received: by 2002:a05:600c:4592:b0:485:3dfc:57a with SMTP id 5b1f17b1804b1-4855671044fmr204098785e9.32.1773651533830; Mon, 16 Mar 2026 01:58:53 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe1affe9sm42587929f8f.15.2026.03.16.01.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 01:58:53 -0700 (PDT) Date: Mon, 16 Mar 2026 11:58:50 +0300 From: Dan Carpenter To: Oarora Etimis Cc: vireshk@kernel.org, gregkh@linuxfoundation.org, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: bootrom: fix potential null pointer dereference Message-ID: References: <20260315182028.133028-1-OaroraEtimis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260315182028.133028-1-OaroraEtimis@gmail.com> On Mon, Mar 16, 2026 at 02:20:28AM +0800, Oarora Etimis wrote: > In gb_bootrom_get_firmware(), the 'fw' pointer could be NULL if the > function jumps to the 'unlock' label. The execution flow continues > into the 'queue_work' block where 'fw->size' is accessed, leading to > a null pointer dereference. > > Fix this by adding a NULL check for 'fw' before accessing its members. > > Signed-off-by: Oarora Etimis > --- > drivers/staging/greybus/bootrom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c > index 83921d90c322..50c80475d241 100644 > --- a/drivers/staging/greybus/bootrom.c > +++ b/drivers/staging/greybus/bootrom.c > @@ -298,7 +298,7 @@ static int gb_bootrom_get_firmware(struct gb_operation *op) > > queue_work: > /* Refresh timeout */ > - if (!ret && (offset + size == fw->size)) > + if (!ret && fw && (offset + size == fw->size)) Was this a static checker false positive? Which checker are you using? If fw is NULL then "ret" is a negative error code so the original code is fine. regards, dan carpenter > next_request = NEXT_REQ_READY_TO_BOOT; > else > next_request = NEXT_REQ_GET_FIRMWARE; > -- > 2.47.3 >