From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C503632E12E for ; Mon, 16 Mar 2026 09:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773651888; cv=none; b=eQIGVs34EAFeutiOsWf6zQQdVvDX2PEvMa8fHberDkmZJ/UWDIQQ0E7kpvKb/uH04ctawZmJD5YPlZ3e+TK7isLMDxYmm6qN+ufFh+FqpkH7oTrZ8mSVms6B+3zDiKufmWiyFasmdUSp4RjNnckcvOYvBc7PCF51S7fISzhSdT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773651888; c=relaxed/simple; bh=KFauTBZtNOFOdh/LTMfQ28QxZM2lPegNKN7FD0C1VdA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j9Wp0CzZ7iOQxwqXGhqYESHSzclNXfPuQXvTdkEMprb/bnHLX2/qfspp0nORZ+LpSnT9yGlfCIRK03aXEzBONAj1yx2mbJF01pfEV5x4Wkkiz2sVCzaIj1MkAEnaSeHF6+sc9Mu8X/ytfskhmqdSvRLv2MO3OjUolDkmSsIAgmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=RA/FJmcS; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="RA/FJmcS" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wzVH+mgg+RyKGijb/s7Me41iZY77U7jrrt4yLKzYAp8=; b=RA/FJmcSflnBFEaUMhfXhR2sQ4 9bjl8iG7c1boAaFfw2ZB/oNmJSXiBhq5qIp5OZ+69AoW6gPM8OvNirDQq8WALpJDOFIFoMfG9U+nx NZK0QocA+I7hoCxiQZuYK9FrNvTSV5B8vnXy8YNOflo+M8OXj62CmW3yrEcrd6lCLFifDYjpQNyXi PTagsI9nN11TqK3pqC+n0f8XbxeOo29qcMETOm+FAv0+ixHyq+6Un0zq+nd4w8a1coEBZ9v4jjUxn iN50wqWQOWyBwBIjC+gT+JC9HSO7ljoiKeEN7wwEZyO8J6/urRxfbxpO5ZD8Ns7DAUMRtObs6LY4a bAA8CtWA==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w23ra-00208L-Dp; Mon, 16 Mar 2026 09:03:49 +0000 Date: Mon, 16 Mar 2026 02:03:42 -0700 From: Breno Leitao To: Rui Qi Cc: rafael@kernel.org, tony.luck@intel.com, bp@alien8.de, guohanjun@huawei.com, mchehab@kernel.org, xueshuai@linux.alibaba.com, lenb@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, jonathan.cameron@huawei.com, fabio.m.de.francesco@linux.intel.com, jason@os.amperecomputing.com, inux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, inux-riscv@lists.infradead.org Subject: Re: [PATCH] ACPI: APEI: ghes: mark ghes_in_nmi_spool_from_list maybe unused Message-ID: References: <20260316082842.84356-1-qirui.001@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316082842.84356-1-qirui.001@bytedance.com> X-Debian-User: leitao On Mon, Mar 16, 2026 at 04:28:42PM +0800, Rui Qi wrote: > When CONFIG_ACPI_APEI_SEA and CONFIG_HAVE_ACPI_APEI_NMI are both > disabled, ghes_in_nmi_spool_from_list() becomes an unused static > function and triggers -Werror=unused-function in some configs (e.g. > riscv defconfig with APEI disabled). > > Mark it as __maybe_unused to silence the warning while keeping the > code available for configurations that use SEA or APEI NMI. Isn't it better to move it to the "#ifdef CONFIG_ACPI_APEI_SEA" below? Similarly to ghes_sea_add() and ghes_sea_remove()?