Re: [PATCH v3 1/6] dt-bindings: iio: light: vcnl4000: add regulators

Krzysztof Kozlowski
2026-03-15T08:49:44Z

On Sat, Mar 14, 2026 at 06:06:30PM +0200, Erikas Bitovtas wrote:
> This commit adds supply properties for the sensor, I2C bus and IR LED

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> anode supplies [1], which can be found in vcnl4000 ambient light and

So other devices do not have these supplies? Or have only some?

You already received that question, so I assume you checked. Then check
again because 4040 has VDD.

thus in
that case

> proximity sensors, to ensure the sensor is powered on before proceeding
> with setup.
>
> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..a1b4c02db246 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + vdd-supply: true
> + vddio-supply: true

VCNL4000 does not have VDDIO and VLED pins.

Best regards,
Krzysztof