From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A8538D019 for ; Mon, 16 Mar 2026 10:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658359; cv=none; b=pCynKRuqey79ZR2DMaf3o+aNJwTpA0inwLeIXqfyUXq/xTPrRguWdEPBusUfDeteEoFWu9DoQW1lK0IqEIyaeKzmEecfuhJw+vO01DPg7fw+PVjpAnemY/ORSNISmzhFYt6KxIACGN4DCSJWTke7lrxJ8aKZNexRLifzJfgXRbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658359; c=relaxed/simple; bh=L26jm5jX24iJ3KU18ihZvHPzNtD1XydWhsRzUBY1WTE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=q/ObdTcIJ8RiLk93v/67nhXBHnS0Rgfk71gc3XwQuw208HhDJXTSxJaJ4hFff1N0xizIs/R+oameG3OROkJOIwLuo9iPE3Ept3vYOTHQVQQO12F4Cv59YmfQujH+ZL4W4TsApsyVbs/xU+cnHB4GJ5rKVwxz8hfvSY6CoLmDgR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=n0mYfS2R; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n0mYfS2R" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b9360e9f43bso143448866b.3 for ; Mon, 16 Mar 2026 03:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773658356; x=1774263156; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=W2E+qOfGop+QubRQ5BjqIf2g5ptnhpPI53+IOJpnWpE=; b=n0mYfS2RCtrEsy9SwWQwLvPwLry19aIbQS++V/6FquchFRX0DMV94ZzYDwM/+GeSAL 5tIvCHA9AL2Phab61tuF9GlYDbPlmBL53J4PrpUTSywBmY9sS6md7T8jx+RH0RfVjXtg nUjgjzpuefqlEd5NYh8dOlQFFk61ShcoIp2Aq+c1zNjnVpHAoc5KwDJtD7D/p7L8xzH/ sRnq5tgAkZ2t1zXirJ1x17Di23CjcBr/rv2M6rhtvlURllmRReQJRp4etYIz6NgQddPY 1D2xtSRjYJt2GrCHn60iADvXonRCDAPFkSEqJVHbSHTYYuLGh4X6M9KKY7I8xKQw9sh8 lyyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773658356; x=1774263156; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W2E+qOfGop+QubRQ5BjqIf2g5ptnhpPI53+IOJpnWpE=; b=LIFZkC3tkFQM4qTrpT5sYE4XESNFDNnsfeqi8Zxz04LKvjyq+VK/VbJvH8qRYbjfqG +5e8NwcQwiWexfZu1oAJlEftHuscSlxrM7ykj06BaHMHYpnD5dK0BdUNRIW9r/3+xS/O KfAUc0ykIZVm5fbHFfvcTVQKqecv5CW/HkY/xiZbNOwDxCQCLbVu6LWfO8dhBqWcdyyu OTFBtVeFm8Y0kalc4VnOvXGExfj7JFpjTHaC/9El3pxJvsfXkjFOYtViZ6qd8tqWopGW FzmN/lq4obr8nRI9Plojvc7f9iohebog8nu+H8XzK23MicZKbV4GhK1o9lkyx3gyL7AB qAkw== X-Forwarded-Encrypted: i=1; AJvYcCVN06ULhKBXZSsqs1QKg5e6HMYeLqrl3KfbyHw7mmGj7tVtGVlMYodoZpONWohmF8d6tmbNWGJ2fgMsNNY=@vger.kernel.org X-Gm-Message-State: AOJu0YwnEFIpmE1ZzzfnxiolntXfhZkwD4hTYOJcaw5C6L8P2mYFE8Fd x0y3XixkyFdM2818OktLVPV3SUrqX77hsPhToMnV2CvYmPFO2TQCNyfY8+g3JSi1SgVlIaVSrNy 70KaKL9QWNk/pSF4Ppg== X-Received: from ejcuc33.prod.google.com ([2002:a17:907:c8a1:b0:b93:4f5f:7d88]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:1c0a:b0:b97:a39d:ae3d with SMTP id a640c23a62f3a-b97a39dc4c4mr350209766b.44.1773658355573; Mon, 16 Mar 2026 03:52:35 -0700 (PDT) Date: Mon, 16 Mar 2026 10:52:34 +0000 In-Reply-To: <20260216-rnull-v6-19-rc5-send-v1-20-de9a7af4b469@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260216-rnull-v6-19-rc5-send-v1-0-de9a7af4b469@kernel.org> <20260216-rnull-v6-19-rc5-send-v1-20-de9a7af4b469@kernel.org> Message-ID: Subject: Re: [PATCH 20/79] block: rnull: add discard support From: Alice Ryhl To: Andreas Hindborg Cc: Boqun Feng , Jens Axboe , Miguel Ojeda , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Trevor Gross , Danilo Krummrich , FUJITA Tomonori , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="utf-8" On Mon, Feb 16, 2026 at 12:35:07AM +0100, Andreas Hindborg wrote: > +configfs_attribute!(DeviceConfig, 10, > + show: |this, page| show_field(this.data.lock().discard, page), > + store: |this, page| store_with_power_check(this, page, |this, page| { > + if !this.data.lock().memory_backed { > + return Err(EINVAL); > + } > + this.data.lock().discard = kstrtobool_bytes(page)?; Similar to the race I mentioned earlier with store_with_power_check(), this is also a TOCTOU race. > + discard: u8 { > + default: 0, > + description: > + "Support discard operations (requires memory-backed null_blk device). Default: false", > + }, kstrtobool again here... > -type TreeNode = Owned; > +const _CHEKC_STATUS_WIDTH: () = build_assert!((PAGE_SIZE >> SECTOR_SHIFT) <= 64); Use static_assert! or assert! here. Alice