From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9B71DF723 for ; Mon, 16 Mar 2026 11:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659101; cv=none; b=MTolJ9G2+M48Fbuu1FjINn3S0YZKJ19ygDIwrz5L+aXK/mTktGsJwZxYDP7koFYNWuRBZoKD2b1We1CG8bXVPwAKQXNIrOEdrv80U8DogdDPTFlaTR/ZvD6rT5Zv3rHqmUKSg/g3/UPwSRajj92rsQ6zRLFicIVcJ8FPOSSqnC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659101; c=relaxed/simple; bh=TnLlXCOEwB+F51krmexkeVovZ5TzhMYqfqPBDnMdWqc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NtqquBl89SCBZCMzw0mcmCLhSpJfV9QyLISSZb2QCYe8xWZzfyK/KODEmxKUul1uXLrFQZNk+bXw981yvqypp8zOtzYJoYpRenDLXrG1KiioRHfmSXs4wDr1qy4h7mT4d0R/OxhBdvFdP1IJIzgHq6G5WlEZHaMA+JsN184cd24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VAX7nOJB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=q18AhQqn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VAX7nOJB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="q18AhQqn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773659099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0dYerS74j221fuo3Jw2PY9y8EQKWVdbS7rEMHtWNq8=; b=VAX7nOJBgN+hroQySovJN0QZ8QHk4/nhz1ZHjVKPFrCDgy9fpZeTIdZiwOwLzw5sEaLaFO R1do0Y9tinVCistxO3OdQYoe3aXymb7gMx6LXSrR4/peu3GRU4JJem0yt6SB0KDk1TEzSC u5ppDy3YIZJtyrVXeERy2JbsPi47WUE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-PatvdQEqN8-ZRSJ2KED8bQ-1; Mon, 16 Mar 2026 07:04:57 -0400 X-MC-Unique: PatvdQEqN8-ZRSJ2KED8bQ-1 X-Mimecast-MFC-AGG-ID: PatvdQEqN8-ZRSJ2KED8bQ_1773659097 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89c517e405dso52265486d6.1 for ; Mon, 16 Mar 2026 04:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773659097; x=1774263897; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Q0dYerS74j221fuo3Jw2PY9y8EQKWVdbS7rEMHtWNq8=; b=q18AhQqnhauqllnhnU+sJHvRvlTTdQq2N56DSZVlJsPm7i3n/ImOk34f8RUEsYtwIU E5LYKLh10EAdOaNlhn5VNJty4GA9xwYMgTu1i+2Fb/8arNtZ1eica6U4lcSzNbHYFmGW kTe6tfbR4wT49UNV3mBqGs+AuYvNiRh0p7jg0Jg5kWj8I1twyzuICqpMOtQfG1gRf0Cj h+bUHDbTPlvMBcP6ngJTb/fI+N52grqiQ5zeo0lR1uNCl3CxRHQf2vdp/blqP5x4zF5b tykRGVChqr0hs1zD2qTuvki3OYBNA0RY58nOk1kIfE+hgIwTiYUAoBA6VtpkdlexRlcP 2OzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773659097; x=1774263897; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q0dYerS74j221fuo3Jw2PY9y8EQKWVdbS7rEMHtWNq8=; b=tFRzw6Cqw+Z2pdvL4hXtD+bjCx3Z4Dbv/k8EdbEcxSDuIUFt1WDjqW4CRms+R1P3SA /Y76hYDRZw4cWg2StgHaSJ4xNOGdlqCLG26ms8iJjWmaGpbbTg+jw3fptm+5zpV3H6ew 2sah7VbvEP85efSu1M3SUUYZdDiodWmSO832uWsq7ah+cU59NqU+G7IH+O8d2lHmd4ga XrXSx7cHzhAip+HYHsyvm1q8IiQYSP6UidKyfuTzfbXEfQIqlm2IWBBOkkN1TNk8A+Ku 9ve7EpBxLa7vWXv1Hlt0ovt/kUb6vy9NWw759PbwfO1ruA7aiVHVmTYDP5i2nkKvzbA4 DYNQ== X-Forwarded-Encrypted: i=1; AJvYcCWSmR/rk67jTJpJ2KnxlsXJsNX/WCGe2xGpIGISzRcPWar3QZRSvskwx5BxwqBLecdGimFALqLvRbtPtXY=@vger.kernel.org X-Gm-Message-State: AOJu0YxUtn0dAn2PRJ4bQqiQqG3r0N6JA6FDE5TL8+eYj8JGKnww0YUu J8ZBCH4E3oAnGcw0AlrFKMY7hH8ud7jrKeH0G4SnROKRwc8UVza0S3D2dPx4/d5A0O6OINYllmi 8bK/UOI4ZZBsnNdIT+0WjltLbw3YoC2LW3ilXCh5WQt9AGDdc5/JGihHGZ34+6eOj/g== X-Gm-Gg: ATEYQzx8mVapnVjz+uWNUSFXHCrPwSgjtW9oaxsBJ7mePxG/DvnG70bBo+7bVFO3mCj 5M6mO8hfYEwMw5YloTrxhqR6Uex1m/2nl2ycvQhoG9fFn0UM9BNWP6gRdT2C1RwEyrHIc+E8xmh HcRYkjSsaUO9wD1+K2QOdJYM5YKzgCn/1w0u4j9IsI6J2zJ8WBHR16uGW8sgvbtlkQ6hOf4qvcz K4E8HtixhbjpcI3HLBdhBb90FTzZtvkWu0KJbz053qfGwX2iEDP9hIfbcxAKb0IuzujGqpA/LcP pOzFoKUH9P5vu/ZwFo4a7ZZVF1FfznEFGO68F+RWSElI8Jp4OqFbV7/hSqIJsbR4kZP6cqB8Ty8 bV46RmDCMSLsD+MRiwFyYsXpYd86jY50Y0SXMvhnp3GTyE3T4LKpDcRNt X-Received: by 2002:a05:6214:2482:b0:899:ac2b:6ddc with SMTP id 6a1803df08f44-89a820c9ea5mr179578856d6.62.1773659095395; Mon, 16 Mar 2026 04:04:55 -0700 (PDT) X-Received: by 2002:a05:6214:2482:b0:899:ac2b:6ddc with SMTP id 6a1803df08f44-89a820c9ea5mr179574986d6.62.1773659092023; Mon, 16 Mar 2026 04:04:52 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c463af405sm45050026d6.48.2026.03.16.04.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 04:04:51 -0700 (PDT) Date: Mon, 16 Mar 2026 07:04:49 -0400 From: Brian Masney To: Gabriele Paoloni Cc: mani@kernel.org, jassisinghbrar@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mpapini@redhat.com, dnita@qti.qualcomm.com, rballati@qti.qualcomm.com, bijothom@qti.qualcomm.com, wchadwic@redhat.com Subject: Re: [PATCH 1/2] mailbox: qcom-ipcc: amend qcom_ipcc_domain_map() to report errors Message-ID: References: <20260316102618.7953-1-gpaoloni@redhat.com> <20260316102618.7953-2-gpaoloni@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316102618.7953-2-gpaoloni@redhat.com> User-Agent: Mutt/2.3.0 (2026-01-25) On Mon, Mar 16, 2026 at 11:26:17AM +0100, Gabriele Paoloni wrote: > Currently qcom_ipcc_domain_map() ignores errors returned by > irq_set_chip_data() and invokes irq_set_chip_and_handler() > that in turn ignores errors returned by irq_set_chip(). > This patch fixes both issues; no other functional changes > are implemented. > > Signed-off-by: Gabriele Paoloni > --- > drivers/mailbox/qcom-ipcc.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index d957d989c0ce..c23efaaa64a1 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -116,12 +116,20 @@ static struct irq_chip qcom_ipcc_irq_chip = { > static int qcom_ipcc_domain_map(struct irq_domain *d, unsigned int irq, > irq_hw_number_t hw) > { > + int ret; > struct qcom_ipcc *ipcc = d->host_data; Put variables in reverse Christmas tree order. > > - irq_set_chip_and_handler(irq, &qcom_ipcc_irq_chip, handle_level_irq); Should irq_set_chip_and_handler() and irq_set_chip_and_handler_name() be updated to return an int to reduce boiler plate code? > - irq_set_chip_data(irq, ipcc); > - irq_set_noprobe(irq); > + ret = irq_set_chip(irq, &qcom_ipcc_irq_chip); > + if (ret) > + return ret; > + > + irq_set_handler(irq, handle_level_irq); > > + ret = irq_set_chip_data(irq, ipcc); > + if (ret) > + return ret; > + > + irq_set_noprobe(irq); > return 0; The newline before the return 0 is removed. That should also remove the irq_set_noprobe() change from the diffstat. Brian