From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E35F225403 for ; Mon, 16 Mar 2026 11:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659143; cv=none; b=VzujsVZBZKPxQp6D2860Hg5Gw6+7GMAS1daCDtywayWiY0Szel7qZRKbHVz6OjZkabMoiOJ6FcFPO7hgIhISNyB8h0++PsqAY8EcTbZI6SXiGzcW78LbSfTPHlLcvs2/6y2uVvZ7exxHWS89wOnfznZHWlltbr1vlQgjf/j0ze8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773659143; c=relaxed/simple; bh=Ad453GyO/zo6v2miyh1zTsFX+JblatB8NS4t5mLlf4A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bprtbvX7yLXBA7a2nBtIp5dvMU1KuKBS4LdIi5VGv4Qyd/TOXyPcpPKVwW3bJ+ysDtTLbhn9MPg7DRfOG6lN19SveK4Yu5a09m0FjOWPof5o1yjvTeC1xzTRRJ+eQSOjduI2qO+LIti38aVi02Q3uR/jLL1FtDsOX9Puhq5cz6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TmZDZCCd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tAHROEEh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TmZDZCCd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tAHROEEh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773659141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=35G1xZGf0uqjk0dykU1nJVs0B6K9SxHlDxmUBHf6ahQ=; b=TmZDZCCdc8je/3bwcYCe/YVWToPHsGLE7f4eAwtXfFCIsF86b9czFzfT3eBkBOGpO2lFQq L0arwpVkqGjJz73P/WEtCVUGEjykDXqNYNgrkPAutn/qAWOS0zqqzx8qgFYNFyP4N6Aemd hIYVv+RdDFSTvgCyUx/0aRcMb9D4LjY= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-Y-e25ef_O-mMbjWd36luNA-1; Mon, 16 Mar 2026 07:05:39 -0400 X-MC-Unique: Y-e25ef_O-mMbjWd36luNA-1 X-Mimecast-MFC-AGG-ID: Y-e25ef_O-mMbjWd36luNA_1773659139 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-509011403a7so246263731cf.1 for ; Mon, 16 Mar 2026 04:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773659139; x=1774263939; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=35G1xZGf0uqjk0dykU1nJVs0B6K9SxHlDxmUBHf6ahQ=; b=tAHROEEhgHw50qcYusB2vUaMI4r4cQqp4MeLY0lOe/xUNRMLm32tkAQK1EHx5JMFIR KMj8mtq5LOQ0LiCmrjT4D+ZZ4gULeZAJe1l/uBYGU9zGLkFF3aa9OawW9h3z0fDnkYvw LUBteXZn+o/9L8nqskWFgZWoFe2ZOCYpjaKImZN2c9F16uusQjjMHzqsL20vN4T7g2aD l/GrI23le39zTdfU0AK+feM9Xke9LPKU2RvbxJwIj9okKF2tlvs5Ka16yB14TFUkapmY LLd8uQ5SnjHMAurSEkIwnY/GKJWWLNwQm10eCVggOhnmBZRnGLjOVQBaX3RTOdDw6WHB TXCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773659139; x=1774263939; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=35G1xZGf0uqjk0dykU1nJVs0B6K9SxHlDxmUBHf6ahQ=; b=DHXrLkpuXOlQR2VNL+T+kAF3nhjI8rrYrQK3GdC1tw09KtBrRQOixY6cx6manqA1ML kT6wBnxMkrJ44SBGuWA0jtZxBIUcijOC36WVyzdJcuVh1m8/aa/JWyERjdheIPx9rfLi +YlXALWBrPnrwJlphxdERxTPKSVMjJVu5d5gXVHivYcpddtT6iqGPlu9QM10v6arcH+k tyshL2N1bDIFQIrXh9j0IVKPflHrS+bX163kP8CBnhhuVrUfM6Yv3hPWBobayp6+Y1Db BWKAA6LPHhHh029dDX7O9zqunhjV7rwB9O5OQfIOjNCw6dG+Y31rkpIt5BbfzBNym7Lu tWmg== X-Forwarded-Encrypted: i=1; AJvYcCXPT4+T6yMOn/lWo8gLdWkrzib3zNmxSdeGIOAm2rXsNybRcN8zS8Bp+EgE69PPlSpDWVpGYH8t7nF+tiw=@vger.kernel.org X-Gm-Message-State: AOJu0YwgwcxjxjqM+VBt9VzBfjRm4/QZjtFTDs2kU+5/YG5DD7j3hqDb 2BETnr75CJrjGi0shJO57g+wlBevlvWhtBP7MO6zK/cd2sFtKJUMlJPPqBpd/7NddZtAGHTiqpt H3XegvmT7zwgIibyXJnch0NeVdtsXbueSwbzCvUCC8orynKFeHqW+tulasf7XmfEbPw== X-Gm-Gg: ATEYQzwj9073DvzBXta9GJCYENhC2mk8JkHIoxbn72onM/j+8YUZIS2yt9yEKf614h4 g9i6c06xsQQAw7nVjBFAgvSUxaQig9GKGTRcW9kvaBGU9RZFakaJylOo5gbb9989Gyf4UsBVehD Pv+xpnPPk2J3Ifo/H2oiHmwqP/M2v3ttYXpVfsPh7mtCNb9/3uJCRY3swyNdRmCSdlN/q2yN8DI UcAF8n6S83xtBphNBBZbt+xG1rgh7528RlfVRsEG5jI/D4ShSn5U3NIA6fGzJD3+G/U8gexVfni qFNE+Jp0G5oe46CkjqXL+bMhTdh8ABjDQgoRosamHSmAqPSdpUvzADovQjR8Y+E4RuUJQb5QwCJ 0FI8hHrnILGiOz1X1veqZCLfsoWBN8ca6/dSWlGQHk5YnJw6Kxwvzeh9H X-Received: by 2002:ac8:5914:0:b0:509:350e:743e with SMTP id d75a77b69052e-50957cf28eemr172911371cf.22.1773659139203; Mon, 16 Mar 2026 04:05:39 -0700 (PDT) X-Received: by 2002:ac8:5914:0:b0:509:350e:743e with SMTP id d75a77b69052e-50957cf28eemr172911031cf.22.1773659138822; Mon, 16 Mar 2026 04:05:38 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093a14d7a6sm113916121cf.33.2026.03.16.04.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 04:05:38 -0700 (PDT) Date: Mon, 16 Mar 2026 07:05:36 -0400 From: Brian Masney To: Gabriele Paoloni Cc: mani@kernel.org, jassisinghbrar@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mpapini@redhat.com, dnita@qti.qualcomm.com, rballati@qti.qualcomm.com, bijothom@qti.qualcomm.com, wchadwic@redhat.com Subject: Re: [PATCH 2/2] mailbox: qcom-ipcc: amend qcom_ipcc_irq_fn() to report errors Message-ID: References: <20260316102618.7953-1-gpaoloni@redhat.com> <20260316102618.7953-3-gpaoloni@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316102618.7953-3-gpaoloni@redhat.com> User-Agent: Mutt/2.3.0 (2026-01-25) On Mon, Mar 16, 2026 at 11:26:18AM +0100, Gabriele Paoloni wrote: > check the virq value returned by irq_find_mapping(), also > check the return value of generic_handle_irq(); return IRQ_NONE > if either of the checks fails. > > Signed-off-by: Gabriele Paoloni > --- > drivers/mailbox/qcom-ipcc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index c23efaaa64a1..0795184591f0 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -75,7 +75,7 @@ static irqreturn_t qcom_ipcc_irq_fn(int irq, void *data) > { > struct qcom_ipcc *ipcc = data; > u32 hwirq; > - int virq; > + int virq, ret; Put variables in reverse Christmas tree order. Brian > > for (;;) { > hwirq = readl(ipcc->base + IPCC_REG_RECV_ID); > @@ -83,8 +83,14 @@ static irqreturn_t qcom_ipcc_irq_fn(int irq, void *data) > break; > > virq = irq_find_mapping(ipcc->irq_domain, hwirq); > + if (unlikely(!virq)) > + return IRQ_NONE; > + > writel(hwirq, ipcc->base + IPCC_REG_RECV_SIGNAL_CLEAR); > - generic_handle_irq(virq); > + > + ret = generic_handle_irq(virq); > + if (unlikely(ret)) > + return IRQ_NONE; > } > > return IRQ_HANDLED; > -- > 2.48.1 >