public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Conor Dooley <conor@kernel.org>,
	Icenowy Zheng <zhengxingda@iscas.ac.cn>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>, Rahul Tanwar <rtanwar@maxlinear.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	Icenowy Zheng <uwu@icenowy.me>, Han Gao <rabenda.cn@gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
Date: Mon, 16 Mar 2026 07:21:59 -0700	[thread overview]
Message-ID: <abgSB6DBABOtk+tU@x1> (raw)
In-Reply-To: <0f88a17c-7c21-4ae5-b418-dfb4b4ac5d6a@roeck-us.net>

On Mon, Mar 16, 2026 at 07:11:37AM -0700, Guenter Roeck wrote:
> On 3/15/26 05:12, Conor Dooley wrote:
> > On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > > them A and C coefficients and calls H coefficient in the binding as B)
> > > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > > respectively), however the binding currently only allows coefficients as
> > > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > > > 
> > > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > > of milli-Celsius) to satisfy the need of TH1520.
> > > > 
> > > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > > ---
> > > > Changes in v3:
> > > > - Added Drew's R-b.
> > > > - Fixed some typos in the commit message and slightly reworded the
> > > >    precision sentence.
> > > > 
> > > >   Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > index 56db2292f062d..7d57c2934a8a1 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > @@ -105,7 +105,7 @@ properties:
> > > >         G coefficient for temperature equation.
> > > >         Default for series 5 = 60000
> > > >         Default for series 6 = 57400
> > > > -    multipleOf: 100
> > > > +    multipleOf: 10
> > > >       minimum: 1000
> > > >       $ref: /schemas/types.yaml#/definitions/uint32
> > > > @@ -131,7 +131,7 @@ properties:
> > > >         J coefficient for temperature equation.
> > > >         Default for series 5 = -100
> > > >         Default for series 6 = 0
> > > > -    multipleOf: 100
> > > > +    multipleOf: 10
> > > >       maximum: 0
> > > >       $ref: /schemas/types.yaml#/definitions/int32
> > > > -- 
> > > > 2.52.0
> > > > 
> > > 
> > > I have applied this to thead-dt-for-next.
> > 
> > That's odd, why is a hwmon binding in your branch?
> > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> > 
> > I don't see an ack on it from the relevant maintainer either?
> 
> I don't get it either. Normally I am the one to apply hwmon bindings
> through the hwmon branch.

Sorry, I should not have done this. I should only be applying dts/dtsi
patches to my thead dt branch.

Thanks,
Drew

  reply	other threads:[~2026-03-16 14:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 16:24 [PATCH v3 0/2] Add cofficients to the TH1520 PVT Icenowy Zheng
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
2026-03-14 16:56   ` Drew Fustini
2026-03-15 12:12     ` Conor Dooley
2026-03-15 15:44       ` Drew Fustini
2026-03-16 11:09         ` Conor Dooley
2026-03-16 14:13           ` Guenter Roeck
2026-03-16 14:11       ` Guenter Roeck
2026-03-16 14:21         ` Drew Fustini [this message]
2026-03-16 14:34   ` Conor Dooley
2026-03-17 15:55   ` Guenter Roeck
2026-03-19 17:05     ` Drew Fustini
2026-03-19 18:23       ` Guenter Roeck
2026-03-09 16:24 ` [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node Icenowy Zheng
2026-03-14 16:57   ` Drew Fustini
2026-03-20 17:26     ` Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abgSB6DBABOtk+tU@x1 \
    --to=fustini@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guoren@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=rabenda.cn@gmail.com \
    --cc=robh@kernel.org \
    --cc=rtanwar@maxlinear.com \
    --cc=uwu@icenowy.me \
    --cc=wefu@redhat.com \
    --cc=zhengxingda@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox