* [PATCH v3 0/2] Add cofficients to the TH1520 PVT
@ 2026-03-09 16:24 Icenowy Zheng
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
2026-03-09 16:24 ` [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node Icenowy Zheng
0 siblings, 2 replies; 16+ messages in thread
From: Icenowy Zheng @ 2026-03-09 16:24 UTC (permalink / raw)
To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Drew Fustini, Guo Ren, Fu Wei, Rahul Tanwar
Cc: linux-hwmon, devicetree, linux-kernel, linux-riscv, Icenowy Zheng,
Han Gao, Icenowy Zheng
This patchset tries to add PVT coefficients from the T-Head TH1520 user
manual to the corresponding DTSI file.
The v1 revision of this patchset is called "Initial thermal management
for Lichee Pi 4A board", however the thermal zone and cooling related
parts are already added to the DT as part of the TH1520 PWM patchset.
Icenowy Zheng (2):
dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head
TH1520
riscv: dts: thead: th1520: add coefficients to the PVT node
Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
arch/riscv/boot/dts/thead/th1520.dtsi | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
--
2.52.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-09 16:24 [PATCH v3 0/2] Add cofficients to the TH1520 PVT Icenowy Zheng
@ 2026-03-09 16:24 ` Icenowy Zheng
2026-03-14 16:56 ` Drew Fustini
` (2 more replies)
2026-03-09 16:24 ` [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node Icenowy Zheng
1 sibling, 3 replies; 16+ messages in thread
From: Icenowy Zheng @ 2026-03-09 16:24 UTC (permalink / raw)
To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Drew Fustini, Guo Ren, Fu Wei, Rahul Tanwar
Cc: linux-hwmon, devicetree, linux-kernel, linux-riscv, Icenowy Zheng,
Han Gao, Icenowy Zheng
The G and J coefficients provided by T-Head TH1520 manual (which calls
them A and C coefficients and calls H coefficient in the binding as B)
have 1/100 degree Celsius precision (the values are 42.74 and -0.16
respectively), however the binding currently only allows coefficients as
precise as 100 milli-Celsius (1/10 degree Celsius).
Change the multipleOf value of these two coefficients to 10 (in the unit
of milli-Celsius) to satisfy the need of TH1520.
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Reviewed-by: Drew Fustini <fustini@kernel.org>
---
Changes in v3:
- Added Drew's R-b.
- Fixed some typos in the commit message and slightly reworded the
precision sentence.
Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
index 56db2292f062d..7d57c2934a8a1 100644
--- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
+++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
@@ -105,7 +105,7 @@ properties:
G coefficient for temperature equation.
Default for series 5 = 60000
Default for series 6 = 57400
- multipleOf: 100
+ multipleOf: 10
minimum: 1000
$ref: /schemas/types.yaml#/definitions/uint32
@@ -131,7 +131,7 @@ properties:
J coefficient for temperature equation.
Default for series 5 = -100
Default for series 6 = 0
- multipleOf: 100
+ multipleOf: 10
maximum: 0
$ref: /schemas/types.yaml#/definitions/int32
--
2.52.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node
2026-03-09 16:24 [PATCH v3 0/2] Add cofficients to the TH1520 PVT Icenowy Zheng
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
@ 2026-03-09 16:24 ` Icenowy Zheng
2026-03-14 16:57 ` Drew Fustini
1 sibling, 1 reply; 16+ messages in thread
From: Icenowy Zheng @ 2026-03-09 16:24 UTC (permalink / raw)
To: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Drew Fustini, Guo Ren, Fu Wei, Rahul Tanwar
Cc: linux-hwmon, devicetree, linux-kernel, linux-riscv, Icenowy Zheng,
Han Gao, Icenowy Zheng
The manual of TH1520 contains a set of coefficients a little different
to the driver default ones.
Add them to the device tree node of PVT.
Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Reviewed-by: Drew Fustini <fustini@kernel.org>
---
Changes in v3:
- Added Drew's R-b.
No changes in v2.
arch/riscv/boot/dts/thead/th1520.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
index bd5d33840884e..2160c8b6c2261 100644
--- a/arch/riscv/boot/dts/thead/th1520.dtsi
+++ b/arch/riscv/boot/dts/thead/th1520.dtsi
@@ -753,6 +753,10 @@ pvt: pvt@fffff4e000 {
reg-names = "common", "ts", "pd", "vm";
clocks = <&aonsys_clk>;
#thermal-sensor-cells = <1>;
+ moortec,ts-coeff-g = <42740>;
+ moortec,ts-coeff-h = <220500>;
+ moortec,ts-coeff-j = <(-160)>;
+ moortec,ts-coeff-cal5 = <4094>;
};
gpio@fffff52000 {
--
2.52.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
@ 2026-03-14 16:56 ` Drew Fustini
2026-03-15 12:12 ` Conor Dooley
2026-03-16 14:34 ` Conor Dooley
2026-03-17 15:55 ` Guenter Roeck
2 siblings, 1 reply; 16+ messages in thread
From: Drew Fustini @ 2026-03-14 16:56 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> The G and J coefficients provided by T-Head TH1520 manual (which calls
> them A and C coefficients and calls H coefficient in the binding as B)
> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> respectively), however the binding currently only allows coefficients as
> precise as 100 milli-Celsius (1/10 degree Celsius).
>
> Change the multipleOf value of these two coefficients to 10 (in the unit
> of milli-Celsius) to satisfy the need of TH1520.
>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
> ---
> Changes in v3:
> - Added Drew's R-b.
> - Fixed some typos in the commit message and slightly reworded the
> precision sentence.
>
> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 56db2292f062d..7d57c2934a8a1 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -105,7 +105,7 @@ properties:
> G coefficient for temperature equation.
> Default for series 5 = 60000
> Default for series 6 = 57400
> - multipleOf: 100
> + multipleOf: 10
> minimum: 1000
> $ref: /schemas/types.yaml#/definitions/uint32
>
> @@ -131,7 +131,7 @@ properties:
> J coefficient for temperature equation.
> Default for series 5 = -100
> Default for series 6 = 0
> - multipleOf: 100
> + multipleOf: 10
> maximum: 0
> $ref: /schemas/types.yaml#/definitions/int32
>
> --
> 2.52.0
>
I have applied this to thead-dt-for-next.
https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
Thanks,
Drew
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node
2026-03-09 16:24 ` [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node Icenowy Zheng
@ 2026-03-14 16:57 ` Drew Fustini
2026-03-20 17:26 ` Drew Fustini
0 siblings, 1 reply; 16+ messages in thread
From: Drew Fustini @ 2026-03-14 16:57 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On Tue, Mar 10, 2026 at 12:24:57AM +0800, Icenowy Zheng wrote:
> The manual of TH1520 contains a set of coefficients a little different
> to the driver default ones.
>
> Add them to the device tree node of PVT.
>
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
> ---
> Changes in v3:
> - Added Drew's R-b.
> No changes in v2.
>
> arch/riscv/boot/dts/thead/th1520.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index bd5d33840884e..2160c8b6c2261 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -753,6 +753,10 @@ pvt: pvt@fffff4e000 {
> reg-names = "common", "ts", "pd", "vm";
> clocks = <&aonsys_clk>;
> #thermal-sensor-cells = <1>;
> + moortec,ts-coeff-g = <42740>;
> + moortec,ts-coeff-h = <220500>;
> + moortec,ts-coeff-j = <(-160)>;
> + moortec,ts-coeff-cal5 = <4094>;
> };
>
> gpio@fffff52000 {
> --
> 2.52.0
>
I have applied this to thead-dt-for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=2592a7072a816be80337b0a85e6279f75498262b
Thanks,
Drew
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-14 16:56 ` Drew Fustini
@ 2026-03-15 12:12 ` Conor Dooley
2026-03-15 15:44 ` Drew Fustini
2026-03-16 14:11 ` Guenter Roeck
0 siblings, 2 replies; 16+ messages in thread
From: Conor Dooley @ 2026-03-15 12:12 UTC (permalink / raw)
To: Drew Fustini
Cc: Icenowy Zheng, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon,
devicetree, linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]
On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > them A and C coefficients and calls H coefficient in the binding as B)
> > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > respectively), however the binding currently only allows coefficients as
> > precise as 100 milli-Celsius (1/10 degree Celsius).
> >
> > Change the multipleOf value of these two coefficients to 10 (in the unit
> > of milli-Celsius) to satisfy the need of TH1520.
> >
> > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > ---
> > Changes in v3:
> > - Added Drew's R-b.
> > - Fixed some typos in the commit message and slightly reworded the
> > precision sentence.
> >
> > Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > index 56db2292f062d..7d57c2934a8a1 100644
> > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > @@ -105,7 +105,7 @@ properties:
> > G coefficient for temperature equation.
> > Default for series 5 = 60000
> > Default for series 6 = 57400
> > - multipleOf: 100
> > + multipleOf: 10
> > minimum: 1000
> > $ref: /schemas/types.yaml#/definitions/uint32
> >
> > @@ -131,7 +131,7 @@ properties:
> > J coefficient for temperature equation.
> > Default for series 5 = -100
> > Default for series 6 = 0
> > - multipleOf: 100
> > + multipleOf: 10
> > maximum: 0
> > $ref: /schemas/types.yaml#/definitions/int32
> >
> > --
> > 2.52.0
> >
>
> I have applied this to thead-dt-for-next.
That's odd, why is a hwmon binding in your branch?
> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
I don't see an ack on it from the relevant maintainer either?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-15 12:12 ` Conor Dooley
@ 2026-03-15 15:44 ` Drew Fustini
2026-03-16 11:09 ` Conor Dooley
2026-03-16 14:11 ` Guenter Roeck
1 sibling, 1 reply; 16+ messages in thread
From: Drew Fustini @ 2026-03-15 15:44 UTC (permalink / raw)
To: Conor Dooley
Cc: Icenowy Zheng, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon,
devicetree, linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
[-- Attachment #1: Type: text/plain, Size: 2744 bytes --]
On Sun, Mar 15, 2026 at 12:12:13PM +0000, Conor Dooley wrote:
> On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > them A and C coefficients and calls H coefficient in the binding as B)
> > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > respectively), however the binding currently only allows coefficients as
> > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > >
> > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > of milli-Celsius) to satisfy the need of TH1520.
> > >
> > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > ---
> > > Changes in v3:
> > > - Added Drew's R-b.
> > > - Fixed some typos in the commit message and slightly reworded the
> > > precision sentence.
> > >
> > > Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > index 56db2292f062d..7d57c2934a8a1 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > @@ -105,7 +105,7 @@ properties:
> > > G coefficient for temperature equation.
> > > Default for series 5 = 60000
> > > Default for series 6 = 57400
> > > - multipleOf: 100
> > > + multipleOf: 10
> > > minimum: 1000
> > > $ref: /schemas/types.yaml#/definitions/uint32
> > >
> > > @@ -131,7 +131,7 @@ properties:
> > > J coefficient for temperature equation.
> > > Default for series 5 = -100
> > > Default for series 6 = 0
> > > - multipleOf: 100
> > > + multipleOf: 10
> > > maximum: 0
> > > $ref: /schemas/types.yaml#/definitions/int32
> > >
> > > --
> > > 2.52.0
> > >
> >
> > I have applied this to thead-dt-for-next.
>
> That's odd, why is a hwmon binding in your branch?
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
>
> I don't see an ack on it from the relevant maintainer either?
Sorry, my mistake, I should not have applied the binding. And you are
right to point out that there was no ack from Guenter or Rahul Tanwar.
I will drop both patches from thead-dt-for-next and wait for agreement
on the binding.
Thanks,
Drew
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-15 15:44 ` Drew Fustini
@ 2026-03-16 11:09 ` Conor Dooley
2026-03-16 14:13 ` Guenter Roeck
0 siblings, 1 reply; 16+ messages in thread
From: Conor Dooley @ 2026-03-16 11:09 UTC (permalink / raw)
To: Drew Fustini
Cc: Icenowy Zheng, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon,
devicetree, linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
[-- Attachment #1: Type: text/plain, Size: 3037 bytes --]
On Sun, Mar 15, 2026 at 08:44:02AM -0700, Drew Fustini wrote:
> On Sun, Mar 15, 2026 at 12:12:13PM +0000, Conor Dooley wrote:
> > On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > > them A and C coefficients and calls H coefficient in the binding as B)
> > > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > > respectively), however the binding currently only allows coefficients as
> > > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > > >
> > > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > > of milli-Celsius) to satisfy the need of TH1520.
> > > >
> > > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > > ---
> > > > Changes in v3:
> > > > - Added Drew's R-b.
> > > > - Fixed some typos in the commit message and slightly reworded the
> > > > precision sentence.
> > > >
> > > > Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > index 56db2292f062d..7d57c2934a8a1 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > @@ -105,7 +105,7 @@ properties:
> > > > G coefficient for temperature equation.
> > > > Default for series 5 = 60000
> > > > Default for series 6 = 57400
> > > > - multipleOf: 100
> > > > + multipleOf: 10
> > > > minimum: 1000
> > > > $ref: /schemas/types.yaml#/definitions/uint32
> > > >
> > > > @@ -131,7 +131,7 @@ properties:
> > > > J coefficient for temperature equation.
> > > > Default for series 5 = -100
> > > > Default for series 6 = 0
> > > > - multipleOf: 100
> > > > + multipleOf: 10
> > > > maximum: 0
> > > > $ref: /schemas/types.yaml#/definitions/int32
> > > >
> > > > --
> > > > 2.52.0
> > > >
> > >
> > > I have applied this to thead-dt-for-next.
> >
> > That's odd, why is a hwmon binding in your branch?
> >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> >
> > I don't see an ack on it from the relevant maintainer either?
>
> Sorry, my mistake, I should not have applied the binding. And you are
> right to point out that there was no ack from Guenter or Rahul Tanwar.
It was Guenter I was thinking of, but there's not one from myself, Rob
or Krzysztof either.
> I will drop both patches from thead-dt-for-next and wait for agreement
> on the binding.
>
> Thanks,
> Drew
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-15 12:12 ` Conor Dooley
2026-03-15 15:44 ` Drew Fustini
@ 2026-03-16 14:11 ` Guenter Roeck
2026-03-16 14:21 ` Drew Fustini
1 sibling, 1 reply; 16+ messages in thread
From: Guenter Roeck @ 2026-03-16 14:11 UTC (permalink / raw)
To: Conor Dooley, Drew Fustini
Cc: Icenowy Zheng, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On 3/15/26 05:12, Conor Dooley wrote:
> On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
>> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
>>> The G and J coefficients provided by T-Head TH1520 manual (which calls
>>> them A and C coefficients and calls H coefficient in the binding as B)
>>> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
>>> respectively), however the binding currently only allows coefficients as
>>> precise as 100 milli-Celsius (1/10 degree Celsius).
>>>
>>> Change the multipleOf value of these two coefficients to 10 (in the unit
>>> of milli-Celsius) to satisfy the need of TH1520.
>>>
>>> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
>>> Reviewed-by: Drew Fustini <fustini@kernel.org>
>>> ---
>>> Changes in v3:
>>> - Added Drew's R-b.
>>> - Fixed some typos in the commit message and slightly reworded the
>>> precision sentence.
>>>
>>> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>> index 56db2292f062d..7d57c2934a8a1 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>> @@ -105,7 +105,7 @@ properties:
>>> G coefficient for temperature equation.
>>> Default for series 5 = 60000
>>> Default for series 6 = 57400
>>> - multipleOf: 100
>>> + multipleOf: 10
>>> minimum: 1000
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>>
>>> @@ -131,7 +131,7 @@ properties:
>>> J coefficient for temperature equation.
>>> Default for series 5 = -100
>>> Default for series 6 = 0
>>> - multipleOf: 100
>>> + multipleOf: 10
>>> maximum: 0
>>> $ref: /schemas/types.yaml#/definitions/int32
>>>
>>> --
>>> 2.52.0
>>>
>>
>> I have applied this to thead-dt-for-next.
>
> That's odd, why is a hwmon binding in your branch?
>
>> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
>
> I don't see an ack on it from the relevant maintainer either?
I don't get it either. Normally I am the one to apply hwmon bindings
through the hwmon branch.
Guenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-16 11:09 ` Conor Dooley
@ 2026-03-16 14:13 ` Guenter Roeck
0 siblings, 0 replies; 16+ messages in thread
From: Guenter Roeck @ 2026-03-16 14:13 UTC (permalink / raw)
To: Conor Dooley, Drew Fustini
Cc: Icenowy Zheng, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On 3/16/26 04:09, Conor Dooley wrote:
> On Sun, Mar 15, 2026 at 08:44:02AM -0700, Drew Fustini wrote:
>> On Sun, Mar 15, 2026 at 12:12:13PM +0000, Conor Dooley wrote:
>>> On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
>>>> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
>>>>> The G and J coefficients provided by T-Head TH1520 manual (which calls
>>>>> them A and C coefficients and calls H coefficient in the binding as B)
>>>>> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
>>>>> respectively), however the binding currently only allows coefficients as
>>>>> precise as 100 milli-Celsius (1/10 degree Celsius).
>>>>>
>>>>> Change the multipleOf value of these two coefficients to 10 (in the unit
>>>>> of milli-Celsius) to satisfy the need of TH1520.
>>>>>
>>>>> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
>>>>> Reviewed-by: Drew Fustini <fustini@kernel.org>
>>>>> ---
>>>>> Changes in v3:
>>>>> - Added Drew's R-b.
>>>>> - Fixed some typos in the commit message and slightly reworded the
>>>>> precision sentence.
>>>>>
>>>>> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>>>> index 56db2292f062d..7d57c2934a8a1 100644
>>>>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>>>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>>>>> @@ -105,7 +105,7 @@ properties:
>>>>> G coefficient for temperature equation.
>>>>> Default for series 5 = 60000
>>>>> Default for series 6 = 57400
>>>>> - multipleOf: 100
>>>>> + multipleOf: 10
>>>>> minimum: 1000
>>>>> $ref: /schemas/types.yaml#/definitions/uint32
>>>>>
>>>>> @@ -131,7 +131,7 @@ properties:
>>>>> J coefficient for temperature equation.
>>>>> Default for series 5 = -100
>>>>> Default for series 6 = 0
>>>>> - multipleOf: 100
>>>>> + multipleOf: 10
>>>>> maximum: 0
>>>>> $ref: /schemas/types.yaml#/definitions/int32
>>>>>
>>>>> --
>>>>> 2.52.0
>>>>>
>>>>
>>>> I have applied this to thead-dt-for-next.
>>>
>>> That's odd, why is a hwmon binding in your branch?
>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
>>>
>>> I don't see an ack on it from the relevant maintainer either?
>>
>> Sorry, my mistake, I should not have applied the binding. And you are
>> right to point out that there was no ack from Guenter or Rahul Tanwar.
>
> It was Guenter I was thinking of, but there's not one from myself, Rob
> or Krzysztof either.
>
... which is why I didn't apply it yet.
Guenter
>> I will drop both patches from thead-dt-for-next and wait for agreement
>> on the binding.
>>
>> Thanks,
>> Drew
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-16 14:11 ` Guenter Roeck
@ 2026-03-16 14:21 ` Drew Fustini
0 siblings, 0 replies; 16+ messages in thread
From: Drew Fustini @ 2026-03-16 14:21 UTC (permalink / raw)
To: Guenter Roeck
Cc: Conor Dooley, Icenowy Zheng, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon,
devicetree, linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On Mon, Mar 16, 2026 at 07:11:37AM -0700, Guenter Roeck wrote:
> On 3/15/26 05:12, Conor Dooley wrote:
> > On Sat, Mar 14, 2026 at 09:56:27AM -0700, Drew Fustini wrote:
> > > On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > > > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > > > them A and C coefficients and calls H coefficient in the binding as B)
> > > > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > > > respectively), however the binding currently only allows coefficients as
> > > > precise as 100 milli-Celsius (1/10 degree Celsius).
> > > >
> > > > Change the multipleOf value of these two coefficients to 10 (in the unit
> > > > of milli-Celsius) to satisfy the need of TH1520.
> > > >
> > > > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > > > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > > > ---
> > > > Changes in v3:
> > > > - Added Drew's R-b.
> > > > - Fixed some typos in the commit message and slightly reworded the
> > > > precision sentence.
> > > >
> > > > Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > index 56db2292f062d..7d57c2934a8a1 100644
> > > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > > @@ -105,7 +105,7 @@ properties:
> > > > G coefficient for temperature equation.
> > > > Default for series 5 = 60000
> > > > Default for series 6 = 57400
> > > > - multipleOf: 100
> > > > + multipleOf: 10
> > > > minimum: 1000
> > > > $ref: /schemas/types.yaml#/definitions/uint32
> > > > @@ -131,7 +131,7 @@ properties:
> > > > J coefficient for temperature equation.
> > > > Default for series 5 = -100
> > > > Default for series 6 = 0
> > > > - multipleOf: 100
> > > > + multipleOf: 10
> > > > maximum: 0
> > > > $ref: /schemas/types.yaml#/definitions/int32
> > > > --
> > > > 2.52.0
> > > >
> > >
> > > I have applied this to thead-dt-for-next.
> >
> > That's odd, why is a hwmon binding in your branch?
> >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=eb4fd43ff6793681f0a0a8e8ac861142caba2b19
> >
> > I don't see an ack on it from the relevant maintainer either?
>
> I don't get it either. Normally I am the one to apply hwmon bindings
> through the hwmon branch.
Sorry, I should not have done this. I should only be applying dts/dtsi
patches to my thead dt branch.
Thanks,
Drew
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
2026-03-14 16:56 ` Drew Fustini
@ 2026-03-16 14:34 ` Conor Dooley
2026-03-17 15:55 ` Guenter Roeck
2 siblings, 0 replies; 16+ messages in thread
From: Conor Dooley @ 2026-03-16 14:34 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Drew Fustini, Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon,
devicetree, linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> The G and J coefficients provided by T-Head TH1520 manual (which calls
> them A and C coefficients and calls H coefficient in the binding as B)
> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> respectively), however the binding currently only allows coefficients as
> precise as 100 milli-Celsius (1/10 degree Celsius).
>
> Change the multipleOf value of these two coefficients to 10 (in the unit
> of milli-Celsius) to satisfy the need of TH1520.
>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
2026-03-14 16:56 ` Drew Fustini
2026-03-16 14:34 ` Conor Dooley
@ 2026-03-17 15:55 ` Guenter Roeck
2026-03-19 17:05 ` Drew Fustini
2 siblings, 1 reply; 16+ messages in thread
From: Guenter Roeck @ 2026-03-17 15:55 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Drew Fustini,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> The G and J coefficients provided by T-Head TH1520 manual (which calls
> them A and C coefficients and calls H coefficient in the binding as B)
> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> respectively), however the binding currently only allows coefficients as
> precise as 100 milli-Celsius (1/10 degree Celsius).
>
> Change the multipleOf value of these two coefficients to 10 (in the unit
> of milli-Celsius) to satisfy the need of TH1520.
>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Reviewed-by: Drew Fustini <fustini@kernel.org>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-17 15:55 ` Guenter Roeck
@ 2026-03-19 17:05 ` Drew Fustini
2026-03-19 18:23 ` Guenter Roeck
0 siblings, 1 reply; 16+ messages in thread
From: Drew Fustini @ 2026-03-19 17:05 UTC (permalink / raw)
To: Guenter Roeck
Cc: Icenowy Zheng, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On Tue, Mar 17, 2026 at 08:55:05AM -0700, Guenter Roeck wrote:
> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
> > The G and J coefficients provided by T-Head TH1520 manual (which calls
> > them A and C coefficients and calls H coefficient in the binding as B)
> > have 1/100 degree Celsius precision (the values are 42.74 and -0.16
> > respectively), however the binding currently only allows coefficients as
> > precise as 100 milli-Celsius (1/10 degree Celsius).
> >
> > Change the multipleOf value of these two coefficients to 10 (in the unit
> > of milli-Celsius) to satisfy the need of TH1520.
> >
> > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Applied.
>
> Thanks,
> Guenter
Hi, what branch is it applied to? I don't see it in next-20260319, so
I'm thinking I should wait on the dts patch.
Thanks,
Drew
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520
2026-03-19 17:05 ` Drew Fustini
@ 2026-03-19 18:23 ` Guenter Roeck
0 siblings, 0 replies; 16+ messages in thread
From: Guenter Roeck @ 2026-03-19 18:23 UTC (permalink / raw)
To: Drew Fustini
Cc: Icenowy Zheng, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On 3/19/26 10:05, Drew Fustini wrote:
> On Tue, Mar 17, 2026 at 08:55:05AM -0700, Guenter Roeck wrote:
>> On Tue, Mar 10, 2026 at 12:24:56AM +0800, Icenowy Zheng wrote:
>>> The G and J coefficients provided by T-Head TH1520 manual (which calls
>>> them A and C coefficients and calls H coefficient in the binding as B)
>>> have 1/100 degree Celsius precision (the values are 42.74 and -0.16
>>> respectively), however the binding currently only allows coefficients as
>>> precise as 100 milli-Celsius (1/10 degree Celsius).
>>>
>>> Change the multipleOf value of these two coefficients to 10 (in the unit
>>> of milli-Celsius) to satisfy the need of TH1520.
>>>
>>> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
>>> Reviewed-by: Drew Fustini <fustini@kernel.org>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> Applied.
>>
>> Thanks,
>> Guenter
>
> Hi, what branch is it applied to? I don't see it in next-20260319, so
> I'm thinking I should wait on the dts patch.
>
Sorry, I forgot to push. It is now in hwmon-next and should show up in
next- in a couple of days.
Guenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node
2026-03-14 16:57 ` Drew Fustini
@ 2026-03-20 17:26 ` Drew Fustini
0 siblings, 0 replies; 16+ messages in thread
From: Drew Fustini @ 2026-03-20 17:26 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Guo Ren, Fu Wei, Rahul Tanwar, linux-hwmon, devicetree,
linux-kernel, linux-riscv, Icenowy Zheng, Han Gao
On Sat, Mar 14, 2026 at 09:57:43AM -0700, Drew Fustini wrote:
> On Tue, Mar 10, 2026 at 12:24:57AM +0800, Icenowy Zheng wrote:
> > The manual of TH1520 contains a set of coefficients a little different
> > to the driver default ones.
> >
> > Add them to the device tree node of PVT.
> >
> > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > Reviewed-by: Drew Fustini <fustini@kernel.org>
> > ---
> > Changes in v3:
> > - Added Drew's R-b.
> > No changes in v2.
> >
> > arch/riscv/boot/dts/thead/th1520.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > index bd5d33840884e..2160c8b6c2261 100644
> > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > @@ -753,6 +753,10 @@ pvt: pvt@fffff4e000 {
> > reg-names = "common", "ts", "pd", "vm";
> > clocks = <&aonsys_clk>;
> > #thermal-sensor-cells = <1>;
> > + moortec,ts-coeff-g = <42740>;
> > + moortec,ts-coeff-h = <220500>;
> > + moortec,ts-coeff-j = <(-160)>;
> > + moortec,ts-coeff-cal5 = <4094>;
> > };
> >
> > gpio@fffff52000 {
> > --
> > 2.52.0
> >
>
> I have applied this to thead-dt-for-next:
I had removed this due to missing binding in next. However, it is now
again applied to thead-dt-for-next as the binding change is now in
linux-next via the hwmon tree.
https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/commit/?h=thead-dt-for-next&id=a7aa874b69460896349985833059a764e688f1d0
Thanks,
Drew
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2026-03-20 17:26 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 16:24 [PATCH v3 0/2] Add cofficients to the TH1520 PVT Icenowy Zheng
2026-03-09 16:24 ` [PATCH v3 1/2] dt-bindings: hwmon: moortec,mr75203: adapt multipleOf for T-Head TH1520 Icenowy Zheng
2026-03-14 16:56 ` Drew Fustini
2026-03-15 12:12 ` Conor Dooley
2026-03-15 15:44 ` Drew Fustini
2026-03-16 11:09 ` Conor Dooley
2026-03-16 14:13 ` Guenter Roeck
2026-03-16 14:11 ` Guenter Roeck
2026-03-16 14:21 ` Drew Fustini
2026-03-16 14:34 ` Conor Dooley
2026-03-17 15:55 ` Guenter Roeck
2026-03-19 17:05 ` Drew Fustini
2026-03-19 18:23 ` Guenter Roeck
2026-03-09 16:24 ` [PATCH v3 2/2] riscv: dts: thead: th1520: add coefficients to the PVT node Icenowy Zheng
2026-03-14 16:57 ` Drew Fustini
2026-03-20 17:26 ` Drew Fustini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox