From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 679ED39D6D9 for ; Mon, 16 Mar 2026 15:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773673677; cv=none; b=hOYm/IOVNHihz1m2/BCrwLU0AXoar1e9YNv/tyVb5LcW9ZoJBECeUtGY986eceVpMHqKSnEGSgYoUNw1HkLx24mXVahPokQkmWCaA1YmZJrs7Jlo2cAD7SKDUcEk4pYnspScJTxpHioFieVRiG/6pJD9biT89U0GZKBQP4pSY10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773673677; c=relaxed/simple; bh=SFx5Z/wna4xcu75GgBDn3B1RzhlnGEjnrkDyKE4lF20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kBuz4Pja5dU4WWDub6zjFpsfyQNwkWfiRuIuFq2vccfTTIe7qSoGtP+YXzVPXeBsu/7IM63+tIyeGzbnj2dlczECutKWehDuRYrelZzeKbEZMpCmbj3pXsdOfb3Tp/kx6gUmO4Ad6m4Dq3LR88YvAsuuWQKoEYCwsOSB+fzrvWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n/71dJAg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n/71dJAg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5946C19421; Mon, 16 Mar 2026 15:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773673677; bh=SFx5Z/wna4xcu75GgBDn3B1RzhlnGEjnrkDyKE4lF20=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n/71dJAg3PTsVQDyQK41XU4dKdci50IV808kKjc4dbMh4rOOlhlfu3u0JSoFlaYe/ V8V1ktqJdBbfjTc/RG2rn02jK96yT+alvCIOXwXkPhlMaMFNENnD3V+laI5Q6fl4+y rqXP0MnMWsF/723x2nosaqnVS8txN0RPoE3I64Xs2jy8NcTIPV303d/YhTHXOsnatS 2AdlzruJ7OrxZjXk6PNoudrnw8jwmbmP+BZwwbsPNntVnVQC1iFo3VObk92PBh9OTV Adns6HSKoI1/vHqIYvBjoPFIKG39gSAky8PMVapwRiHSb7GAlgWY4ldN7QT/i1Uajx SIQY0BqihKPUQ== Date: Mon, 16 Mar 2026 15:07:55 +0000 From: Yosry Ahmed To: "Kanchana P. Sridhar" Cc: hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, senozhatsky@chromium.org Subject: Re: [PATCH 1/2] mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool. Message-ID: References: <20260314051632.17931-1-kanchanapsridhar2026@gmail.com> <20260314051632.17931-2-kanchanapsridhar2026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260314051632.17931-2-kanchanapsridhar2026@gmail.com> > diff --git a/mm/zswap.c b/mm/zswap.c > index bdd24430f6ff..26de0468e33b 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -242,6 +242,20 @@ static inline struct xarray *swap_zswap_tree(swp_entry_t swp) > **********************************/ > static void __zswap_pool_empty(struct percpu_ref *ref); > > +static void acomp_ctx_dealloc(struct crypto_acomp_ctx *acomp_ctx) Nit: If you respin, please call this acomp_ctx_free(). It's more consistent with other naming in zswap.c