From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FEF3306B08 for ; Mon, 16 Mar 2026 15:18:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773674304; cv=none; b=md6q/RjbWzu43tAEtZ9Dgm/F86EIMthPoh67tioe4xEtgTaCSP0McZuivy2MYfBJPgkKPf1e1aN407qs+baQwA7+LMXuKUZ8Aqbw1qPKS/o9APz4KQkfR5YrHA2okc0dwDExmkBdeyRYgtybpk31569TZiUFZR2USDKe3DpA3x4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773674304; c=relaxed/simple; bh=AUXNQnavfxXMccUUnLjvH4/Lj+Q07siLDoBFezaDSH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mF02dhVPyf3aQD9f5JdU3YXsKXLUJR9ynR5jWCfP7aho6dyK+gKLUuYZd6ZBjJawgkvWLU58Z+fGfxyIdtRTj3cdrELtGLfent9/WQ8SpmInoKrGBYrf+cNANWP2AiZQ84t86vrTGZXCiv8QA/7u9rPRRwP0tPsKpDIW8rp2Gh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z6gHUXxr; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z6gHUXxr" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82989744ee0so4377207b3a.2 for ; Mon, 16 Mar 2026 08:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773674302; x=1774279102; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b1GvdCwkRsJTG3Vc/JK61sCTdqezEQDm65yqVtSqI+g=; b=Z6gHUXxr3tqkvVJ2ZrnociTpWf32/TcJnoOzfGgcq+7C7YOEgP0vsxPrt+pyBeRB7/ Z4dlUG8qLrRxjE5surfFBlZ9dtv2nD2swkYLR8lQs0kLtbVAi9oiNXicqFEsUVzTr9Gz Rmjf/fgVIZCSmmwZljdSDcurGCY4HNY2kgRtcElsF/Kfo84Gs4BMyAjhwvv3WgqDiVMn cSl4WavT3553+QLB3QYnMW5j6lT5NWB7VHoISS6Dit+uEUVv//o9KMmmJnTFs/gXZYrd g1WqD15n04z/OINk0STjXo+eF1u0aMKD8fWzkWbq7aTBHwDAUiJjPgNN5TOWfgt1vBDG q+Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773674302; x=1774279102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b1GvdCwkRsJTG3Vc/JK61sCTdqezEQDm65yqVtSqI+g=; b=ZV21ZrVhl1GfxnLzcqFWrUyGIE6z/IqITn+L7kk6ASJo4OToLFHJ4zPv6j2zpNQSbZ B69QatakcKxb4NMWFr+05AdCwRlsKHeENmyBU8GfcUEUYRU9tF/sutuZNWhBsFvqURcT FgY8o46GtCvErxxNAjCl+mfdcYgNA5wCa4OeNvbMi/jZCkzkZoaiUT58GwXNCw3BPgH9 RKBr1gST+OVWPGTNgDGmJSS+cSnD7ubcCAyyvLIn2pZ6+/S5ViYgAM4QywIBk/vuBWDH YIxIc7nvEHVXqujuJIJOTXTni0oW/6hI8UyT+/Q7Nil2OE0MgQ1vk20cPIb2CfATaisf 9RzA== X-Forwarded-Encrypted: i=1; AJvYcCUrNQCivYcHJD0vagW+171UhMYlNbPLbAu2aT7o0L6BtDp8S+3Jgj/k0r2/l9l3mmsKtIGfFIiAMb/Ub+o=@vger.kernel.org X-Gm-Message-State: AOJu0YyXPq1dQGwFESQ1AIA3umIghJcNBqOnB9OrDQZ9cmK7xr9EbDzA SBAnIoVT6ALhOTl1bjntzAHGdFg7j8eYG64hDaoq+Jp9Iq/aXTmB5tqgqLalCkd3wTRr01xpfVg 0L/XQ X-Gm-Gg: ATEYQzxU9f7a4XZXoq++8F1CGaTSimKiT0rzUuB+ccsVckEpe+SdocbkwxLlPMIVaIe Mcm4PEypC6/PEEC8m6YAQemj1I9+qboKtZvU9WswvXPGNsqBsMjCfKoTnq3tqXUgrev7qaHUjLn aS3VRMIM4TU/jYyXA6tJ4M1+0kksEC0mr1gENISMCpNWMPFSlpmfYdbBo79SoGGnCU1uo5VzxHy yT9i7UWZ8c5GpDIgnXOixBVDC2jOWRbmjzyNsZCUouRqLmTcKo+KChX9zloNmDW0N+h9+hHUIpe rvgZA1hnH/D0pgQJnzx7f/OVlXAqIvXR3TZBdNOAblq138NjkcybXfTJujR2qK7AtvOyFLUQn90 nDHkRKj+QV0gx61VkdIEyT8NH3AyHYHjs05PqQtlI2bqW8DDF1BtYbfybZx4feGiolMY5RkbfOd txcDrGojzi0A7DWAHgDN8Lq/s9fBo= X-Received: by 2002:a05:6a00:14d3:b0:829:883c:1d53 with SMTP id d2e1a72fcca58-82a198ef9f9mr12176466b3a.31.1773674302450; Mon, 16 Mar 2026 08:18:22 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:ca75:c28f:fb21:b50f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07340091sm14040592b3a.35.2026.03.16.08.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 08:18:21 -0700 (PDT) Date: Mon, 16 Mar 2026 09:18:19 -0600 From: Mathieu Poirier To: Tanmay Shah Cc: andersson@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: xlnx: do not send new mailbox notification Message-ID: References: <20260219224329.3475032-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260219224329.3475032-1-tanmay.shah@amd.com> On Thu, Feb 19, 2026 at 02:43:30PM -0800, Tanmay Shah wrote: > Only write a new message to the tx mbox queue if slot is available in > the tx queue. If queue is full, then do not send new mbox notification. > > Signed-off-by: Tanmay Shah > --- > > Depends on: https://lore.kernel.org/linux-remoteproc/20260209234430.512492-1-jassisinghbrar@gmail.com/T/#u > > drivers/remoteproc/xlnx_r5_remoteproc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c > index bd619a6c42aa..622de733c929 100644 > --- a/drivers/remoteproc/xlnx_r5_remoteproc.c > +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > @@ -332,7 +332,10 @@ static void zynqmp_r5_rproc_kick(struct rproc *rproc, int vqid) > int ret; > > ipi = r5_core->ipi; > - if (!ipi) > + if (!ipi || !ipi->tx_chan) > + return; > + > + if (mbox_chan_tx_slots_available(ipi->tx_chan) == 0) > return; > Is see 3 options to handle this situation: (1) I can provide an RB for this patch and Jassi picks it up in his tree. The downside is that if a subsequent submission conflicts with this change, we have to wait for the next cycle. In that case: Reviewed-by: Mathieu Poirier (2) Jassi provides me with a pull request to bring the patch in the rproc-next tree. (3) I pick it up in the rproc-next tree in 5 weeks when v7.1-rc1 comes out. > mb_msg = (struct zynqmp_ipi_message *)ipi->tx_mc_buf; > > base-commit: 462799c088e71b2b8a511c2a9649420fcb569ab7 > -- > 2.34.1 >