From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5AC531A807 for ; Mon, 16 Mar 2026 15:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773674509; cv=none; b=FQ/MlEdOzVXYsMeQdDLY5DKZ9D7ZsmtrvhsUnbGoOCrT7b5jj7QLmlmMpCsmP0xJLgyq+pcCZfK8lq062FSLMUl/UR68a4XhQ1rb9c9JQhBJKte3Y/elU2B7CgoHrtbEQzg5KFzanzwWqTvQGO85ISMElOMfqc0Q9WjlYH9fbf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773674509; c=relaxed/simple; bh=vhNP8HmsxyW5M5tGjX/f5tsE1wBg9gdzVJ7KJklOtDo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hvujC5OFY6LunNt4g5rJdpzSE5Wmj96S1oT+dxDwSQjWP4clOaGZUECnpTy+o8oiZwIwvEEXFwO30f0n0BHUbV8Y8HcJ5saQ2y4ZmYn2Nes+oFj5ocZN12IJ+luWspn8MblY9+UrM4gwGzjwZ1ouSFrGWDz7stZD6wt0jCJvAEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B+zjkyfC; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B+zjkyfC" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48534237460so52071965e9.3 for ; Mon, 16 Mar 2026 08:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773674506; x=1774279306; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cvgWjKp8ls5n9m6jDPlYhRIq3P5n2f0R6p5Ga1jqL68=; b=B+zjkyfCFZfYYLAaNwbPhgcpNEZPOIDISbicjD/UXOgjoIJfY+QOPVhotJBswHoygR lJnQNHanz2oT/loGvcDAuk/8Vd9SnRnvLb4cKdqoDxsyQGwJluZ8AtpXdt65EQVVabku li6RhC4gEtatLidd3ARM9xpcaFRWeRrk8/p1oVQISu1hfuc7y9JUsUvwjMrfwmlPLLOb hqwMIefstB4Blw1XDIYtTZzRtXP6j0H4rE/arDfX3Iw02PewukSIhMkAu/Gy2siZ+td6 76ODog1AOqbStHfjGwg6SEtUV689nHVmp8qf0l72hntaM4acpJSR8RRg+i98FGmXBs46 jB9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773674506; x=1774279306; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cvgWjKp8ls5n9m6jDPlYhRIq3P5n2f0R6p5Ga1jqL68=; b=NmiBmaKrz2H760gD5NppvkoNjydSq7/nD5OYvBJIBo8VntE6rUrcwGZefHIVXuSpn+ mIShxZwPM+oh4057HwAmk3hw4N27acvcLux/YXTMi3Vlv1ur9Wy3MwsRPgSpmkuL20DJ 5C3veir2MCG2WOFv7q0fW2e3c8SgJKH7LoVMXD1ljRtATz94xBw61NI/ZGVmL1TAsUKS 2avQCE83Ic2Qhfc/zeCISSekvBvap6U7NQObeZyw7CrwyZFQqnblaDDFcNKPS491k0iB viuCbZotijoxWM4ep5lzIsg5IDijtmq48dCE0UcYIjrdANhSKcaawUN2a3eQo0qUbzoZ q1pA== X-Forwarded-Encrypted: i=1; AJvYcCXTPlGsO5+GAOghY7QaUb9KosLxz7EYTMmxPS3qcpYtutTXtKz6I+1Ud15Xr4FwMqoIBZcxyTSvQLgI/Uc=@vger.kernel.org X-Gm-Message-State: AOJu0YzjBGbM1V+03xx6ha7olvP1dhyKNIp6tmawb8pjqhAmP1LYAZIE hScBLM5JapDT2Qx8pOPyTwOte6uAdOxazaiOJQ9jTE4Uqi60/uqbC2Ku X-Gm-Gg: ATEYQzz+YytSXc8Wn2mkKKey3aJVNi1hOe8C/GDP6v+T0yx9ShabZ0MB7+zeEwBeQa4 dFXildWSqUqFElE3gxb1kL9hI74l8RU/433vX+wiz6lYFVmf4juMcLpzQEKhqyizTGlzABDNV2G zbjZxj4G0Ace5bighdehXyjlGQgG1P6v+zeAHnxr3elOXopzKObm5Oj1W/Zj8YPZ/fSGKrguPaA d9H0x2aBJceT7uVM6Hba8oYABLlh1ua7MzKUOOflNvM+Hx4OJH2eymcDUkSKCDKBFU9E+kPnjcv RkBI1jarEGuZyiN9n93mfo/jAtngtlupLLT6IWo0O2n4ZPOiFa5Qw/etPI+9YZaGYbnILKdTFLh P0I5HEX/160W+9Hqv4fAvbbd8vg3uvSvzJ4VJU7Cc/cBhWz6CSmbS7rAPhFNcQfOA1dfBB3a28c Uuh52iE9zquW9iL6EaPutWCzRonfPW/r1rojO3Kqd/D4oxqwXjzijKRmYrJWzfJuU= X-Received: by 2002:a05:600c:8b72:b0:485:4328:407a with SMTP id 5b1f17b1804b1-485566f7999mr215633795e9.19.1773674505839; Mon, 16 Mar 2026 08:21:45 -0700 (PDT) Received: from osama ([41.44.7.224]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48556414295sm157885775e9.3.2026.03.16.08.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 08:21:45 -0700 (PDT) Date: Mon, 16 Mar 2026 16:21:41 +0100 From: Osama Abdelkader To: Markus Elfring Cc: linux-riscv@lists.infradead.org, Albert Ou , Alexandre Ghiti , Andrew Morton , Lorenzo Stoakes , Oscar Salvador , Palmer Dabbelt , Paul Walmsley , Qi Zheng , Suren Baghdasaryan , LKML Subject: Re: [PATCH] riscv: mm: add null check for find_vm_area in set_memory Message-ID: References: <20260314222815.153203-1-osama.abdelkader@gmail.com> <71d162ec-8745-4391-a94c-e5b0bacb4fe1@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71d162ec-8745-4391-a94c-e5b0bacb4fe1@web.de> On Mon, Mar 16, 2026 at 11:22:26AM +0100, Markus Elfring wrote: > > find_vm_area() can return NULL. Add a null check to avoid potential > > null pointer dereference, matching the pattern used by other arches. > > 1. Were any source code analysis tools involved here? No, both were found during manual review and compare with arm64. > > 2. How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145 > > 3. Would you like to refer to the function “__set_memory” in the summary phrase? > Done, I just sent v2, appreciate your review. > > Regards, > Markus Thanks, Osama