From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64CF531AA99 for ; Mon, 16 Mar 2026 15:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675252; cv=none; b=PnaJB5WlhKPG9oTrueepmpLH8/NrMpNx75FdzG5qnCTd651LYZRw3wxiAnxbVHzaWxFYZTf9ivFWPvuZJHOCrSXm1shgFnGog8P2P0GTYQQjbBWacXshTxr/2ZRDhPik+2acD/OCIkBkDSetap8SdHrWMjzbJWgi81jtzoJ3x+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675252; c=relaxed/simple; bh=vnAQT9RE+vH5WujAQtXJhjlhKyLBsaJKnKkhLJ+BiJg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rcqSVSfKTD49ifWJFtxyaAoXTu0InnKMyUOQHqCH+Gf9Kvhyim5JrYY0clBQCIO7RVBqliLG3UXhzQR+4fPLD+aoxxwVTdw1yBDbbRlr+xhQsqqNnoZQEXJ2ytPQaNVc+6hbNv8nlWhp/jIX+20RoDVcK6yrDCUfedqY3/CiRWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WAklMzKz; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WAklMzKz" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5a1273de95aso7117567e87.0 for ; Mon, 16 Mar 2026 08:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773675247; x=1774280047; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+fc/Jm5bqQFiVZvJG+lB6MLj64d5j4WudtHzzE+s4ZA=; b=WAklMzKzwG5It+8+iQvW475ZmWDRXTSsWclAInlYxMIyLG0Bd0wWqD25UpVJtJ6+D+ IPsQSEx/KVayhuLqhsOIS/EqMeVfizxWlWDWX0oZO+gFa9sAg4DZDeCQ2LwgeoMku9Bj 1BLD5V3zfo0u46IMVljqL/0OGSgcCtcKHQZyJteABvMfulm2c1V+rG7QC7S/v19/8pOR vowY52CiqrVbCj4aqby6xvPZgTwFQeW0MJV2TWJBVZOeO80xL3LE5sEREsGxf8sH5mjG gt2VImBvZXj5bJUA2sqlhz6F15UcQ/s0yiz6Z625aAq7ZN/c4URTWJaZ+4X3K0Y3dG6t Np5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773675247; x=1774280047; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fc/Jm5bqQFiVZvJG+lB6MLj64d5j4WudtHzzE+s4ZA=; b=WkdCeqa+9GOtSPBQjDlr38mTeU7VUNHbKTc1UJ28Ag1eR+QnYGQwMHT1uUmW+OWXMr wcMYFQZQgK+IaCCgiDl5CjwALF/Y3/slT9qMWDzXazKtFsbuCJS/27efgr6VC6SjwZMl pCRYakAH32C8T07ZXTBEzWjSySn3FBLTddzu9k2ypSdzLFYfe55TrKg2NWbaKNUDMFFf 6yKHH8zXJD6EGDJ1g/AGtyq78sAPEfQytJ9CKI2jXEvhwfCfaYyVDwSvP7MM+lYmUwM3 mwjoc75avdsN5YdFj/WiAkawKOKwKd/ISifHvfgTyOaNWbmapst7qRy+fCLalpV3a8kA rS5g== X-Forwarded-Encrypted: i=1; AJvYcCVq3ECO0aIp80ZnjT4tA5YGQFSMtv+4L0fS2dqlrMyIiFRZgabTmK/+2VUuYvq6sHUM2JVe4VHhVxfCuPc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp6scpTZT1Kf08kjlmHNO/mXA/HmCuZYKZwokIQV9B3+g1ZJpl hQ/JPV5fZtUWEzpVXJcV/BL+Si/PMUdWSM9T9anxY6lrWUdWkgPWFLQRWTbxPHejeOg= X-Gm-Gg: ATEYQzxC+Q76bjM0Sw36eVQtvAmef4OyIO3upkxdCcWyRxAIHBLEukG/0bo0YOhDffp ie3p8AppTY1Pg027D434gWDGXwCIz/O5MBvce6h8zgv8N3zeKa5ykPSgki14JpfWGcPFash+UW/ hNw0gmAYdrPlWtlOp6h4iKYNhJrMeFR1BPelzW2cYXx2IYl0DyjAJ+zYzCceelD54qYm5QIZYN9 3o1OG3vIxCn8rt6atnRIu/pFElrySg9XLyjz3cqelUumPRxVracN90JUJYeYpVP+ppAeJHiC5gn vd8UL9eg6JNO7hpwe45wXdXx2j64QCIlxXUdapESeXkXyS7qVfo3SmzWFotddhBpteZF0Yt2xyK AwsgvxP0JJM2K4979SVQrERUqB7fHVn4vZReTZiWdGEjcE0zYXW3FIX0v56VvMH4vPGyjdoDlau VG3FWNa1pmmxFCL4vBt8nJM7apRGOF X-Received: by 2002:ac2:4428:0:b0:5a1:19fc:4755 with SMTP id 2adb3069b0e04-5a162b44e02mr3452856e87.44.1773675247207; Mon, 16 Mar 2026 08:34:07 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a155f33c0asm3547139e87.18.2026.03.16.08.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 08:34:06 -0700 (PDT) Date: Mon, 16 Mar 2026 18:34:03 +0300 From: Dan Carpenter To: Sudarshan Srinivasan Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: av7110: coding style fixes: too many tabs Message-ID: References: <20260316152340.238100-1-ss22.kern.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316152340.238100-1-ss22.kern.dev@gmail.com> On Mon, Mar 16, 2026 at 08:53:39PM +0530, Sudarshan Srinivasan wrote: > This patch fixes below warning reported by checkpatch.pl > WARNING: Too many leading tabs - consider code refactoring > > Signed-off-by: Sudarshan Srinivasan > --- > drivers/staging/media/av7110/av7110.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c > index 607992100baf..f4709b2c4f41 100644 > --- a/drivers/staging/media/av7110/av7110.c > +++ b/drivers/staging/media/av7110/av7110.c > @@ -958,8 +958,7 @@ static int av7110_start_feed(struct dvb_demux_feed *feed) > dvb_ringbuffer_flush_spinlock_wakeup(&av7110->avout); > dvb_ringbuffer_flush_spinlock_wakeup(&av7110->aout); > ret = av7110_av_start_play(av7110, RP_AV); > - if (!ret) > - demux->playing = 1; > + demux->playing = (ret) ? true : false This isn't an improvement. Sorry. regards, dan carpenter