From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EB523314B7 for ; Mon, 16 Mar 2026 16:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773679258; cv=none; b=hh2N2uu/pdF9boewDTFFxdYY1FVYShm+Zedl9x0/AH707fdFVlP3h6dnPbvX0Zc/egZlgncg60YszDogREDLbYWK7g0Gupx7P/5XI6FakYspz4PJw02YAHyaU8EmT9rBipM8U6PXByZwUOXL608wMT5mgAY/zoDdb2RRkktYvmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773679258; c=relaxed/simple; bh=mGdecA6rfnWqBG9UtiddrNEjv6fjdyrSyqptvstcJJI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N6gfbCc5lw/zlxJn8/3deeOfhR5rmUcMg3y8olwNv7b4QFLvZggfBYsYPWMNuPW3iJupj2uYbF0U0wqFmUmR+vUlelW4GRaZGTfzBVcILURYHZaUzyOK74QO31oCX6huFtZ4oFfeeejD0VbNNWiGHRA7LOcZNT/0pdVUTV6FH+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fW1SKchL; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fW1SKchL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773679257; x=1805215257; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mGdecA6rfnWqBG9UtiddrNEjv6fjdyrSyqptvstcJJI=; b=fW1SKchLh7inSvtPRFTQOubLjOQEpeIzIMgym3gJTSawFwy9NRgVW/Tu I9lV8vs47cWZrqyXCGH3kN7gmlgF0DRbv4bWY6sG1SRowdWeKKlm51w9K uUsxflYAEHv9veDlslP0ilYGUIv4Al+zSpkJ4IJQpDpKzqRBHXxhyfg1I ZTIBMZqW7f2zmdiUoNQJ7H9PEBji/2s9QPe6rH5k1Tg8N9BMSSkom4NZ4 g7EKrbVq7AzGF2wEGfKdAiOME4cF2gglfz7IKjvx0ObYbna81XiUHYFyT 9iPQtYfagsVnnhlBPrRRpH0JhQZLNUNYvnrRQyh+tO9tlQ6FHiEmsadTm A==; X-CSE-ConnectionGUID: tA05mki2R8SilDDVCV/tGA== X-CSE-MsgGUID: +pJ8E1H9SuCn7ppmh3Hybg== X-IronPort-AV: E=McAfee;i="6800,10657,11731"; a="74588650" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="74588650" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 09:40:56 -0700 X-CSE-ConnectionGUID: fIVNs+0dSG2L8I43PcItZw== X-CSE-MsgGUID: y5KXzX0rQfm+89YC4CtZaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="219156047" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa007.fm.intel.com with ESMTP; 16 Mar 2026 09:40:55 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 1D97D98; Mon, 16 Mar 2026 17:40:54 +0100 (CET) Date: Mon, 16 Mar 2026 17:40:54 +0100 From: Andy Shevchenko To: Mark Brown Cc: "Peng Fan (OSS)" , Liam Girdwood , Frieder Schrempf , Joy Zou , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type Message-ID: References: <20260310-pca9450-irq-v1-0-36adf52c2c55@nxp.com> <20260310-pca9450-irq-v1-1-36adf52c2c55@nxp.com> <28dad7ac-3f09-4f0a-a9f9-cfe329f8670a@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Mar 10, 2026 at 03:34:35PM +0000, Mark Brown wrote: > On Tue, Mar 10, 2026 at 01:24:44PM +0000, Peng Fan (OSS) wrote: > > > BTW, I am also thinking whether we need to drop setting > > IRQF_TIRRGER_[X] when calling request irq in this driver. > > I can't remember off hand what the effect of that is TBH. I'm not sure > how it'd interact with incorrectly specified DTs? One may need a quirk for incorrectly specified DTs, basically something like flags = irq_...get flags...(...); if (flags & BAD!) ...issue warning and fix the flags... ret = devm_irq_...(flags) ... Also consider dropping dup error message as devm_*_irq*() already does that for us. -- With Best Regards, Andy Shevchenko