Re: [PATCH 5/8] selftests: livepatch: sysfs: Split tests of replace attribute

Miroslav Benes
2026-03-20T13:03:32Z

On Fri, 13 Mar 2026, Marcos Paulo de Souza wrote:

> In order to run the selftests on older kernels, split the sysfs tests to
> another file, making it able to skip the tests when the attributes
> don't exists.
>
> No functional changes.

The functional change is that the test does not run older kernels now so I
would remove the line.

Anyway, I am not entirely happy with carving all three tests out of
test-sysfs.sh to be honest. Wouldn't it be better to just hide them under
"if check_sysfs_exists" condition and keep them here? You could make it
more compact if you check for the sysfs attribute just before checking
both permissions and values the first time it is accessed.

Miroslav