From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A4E433AD for ; Tue, 17 Mar 2026 00:12:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773706327; cv=none; b=HC8NGiDUrJ7TtN22SnLaFJuT/EeGRrZlSQSnKNgP2UeRn1huNAljCKEVpQSebm8HrYnCE7fJHbxVh1HMM9ouYVRIqpNelT9fOaYGqRpH/7orr4mCxw66JxKmN4/mpy+ko1g54G9W9KzbRUF9Nv3/4YKMe8EMkeJD+EMU0VDhkvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773706327; c=relaxed/simple; bh=KPk0VqEkgTKE5kcP47B9rj9VdP8a5q+dUAXz6Mokabo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u4QXxG9xb00JouLbhW3PVSFkc93ZtJKbng9ixlxKiXM5vkUVJeZ7ZR/iDc7u2WZCpUWURGIdbSu1twwSq8SXTwg60WNZd/nsop6jqnH3L1wo2VF44BeLXvImcWZG/hdE5uFh2Kzi6LnRfWYX9ooLlX+TqDhynTZHeTrKTUYOK64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AZcl+v1e; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AZcl+v1e" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-439c6fc2910so3903775f8f.0 for ; Mon, 16 Mar 2026 17:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773706324; x=1774311124; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LM1H0TkGZQ4/8IPYzTH9t0b7D+QiEfzm8Bsq3kZE6YY=; b=AZcl+v1eOBQDSRhJjEQjJm4Vmwca5tb8OCybg8IdO+qSxk20EWvzWsDyGCPYZYlax1 6jPTHcg2gRXsupyqby2zuODp/5OVc3gxg5jn++XYB61d55mvcdE3K60fH8Oy1xWaGLSx KSh61ZrLbk4JWvAk6ldu/3w2VepDrjENRj9oLuiI08sYdoF5/fMHcJbugWyBooM7ee0L tTQmFm5Kz0g7kwtOdYSMcuFI5a52xxd8axGfAXiJEiFHORaVMe45UaW9zWZaM9PQsdv7 CIpBsGxIVJ11OriYSbjHwhsX2gS4vT6WjzdiRsp/EGsHGvwE8B5EyS22RaZ38CRlTk8w hAUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773706324; x=1774311124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LM1H0TkGZQ4/8IPYzTH9t0b7D+QiEfzm8Bsq3kZE6YY=; b=kTitNi9dABmGaffU2DdBfD8Lzcupl9uK/QS4ehqUQLnAaKfyVOB1uXhfQ+MAfkxl+z 9R8KCmnn5Dmwnt6QtdPAPJYjB6hXGJkis74YenVX2jYH6mBhI+VFc7OZDKBDi9cyiBSz EDe35V7otu+ERlQlAYoXlT0HFCq3rzVj16pdzZrBRlOVe5V89W6Wyc7wXwA4eC9/z79u ZYqFd/d1nca7FkXht6qf3Wme1l6+7nd3VOG+GKfmCskIYZAsGrY3vf2PAlg1Kdb78C7z NtjbDM6JZamGKgGHNaBq7taK0YerabHGJEZERhcMqGmpuAFW7TAoUE5FoRCBMtyGnwnZ Qapw== X-Forwarded-Encrypted: i=1; AJvYcCX0cozOocviQPRU8k4ujY0JW1LzJldXK2sK3/w2bB77vs/oIYkCrZ1Ix+9jpLQ+SbpYcpdpeX6bxTI3/VA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5wUqYB//wPa27G3PTl1XYUMPiYtylmVb68ntbP/gdwbXzY54d BYBjFKSQq5+nZ5mg/SI/Hu9N2iujWHbeD/wpgACGs0BQOLPu2rmHQJ9/ X-Gm-Gg: ATEYQzzaUnf+WofdKbCs0UVrPapuYmr0I6TU6pVFYy2DU00DgyM6x5sVbm33YaS4/J2 zFlx4VS7cruziqqI2vNhyr6ECNoN3P025ejzH/+ZLl5Lwl270/+09i6eeaxXm7jZG6zuaFTPE8f YLZgQB29TKIkMjEjWojmRS0BLKvaGlbjpr5uHgS2Uf9oE9tIBYhfzy8mn+kYjuq3OrdnZYeNmo2 wCDDlvAL0F4wb8oF8uBwXKwTplaFcepIZQcYbb1o+jfidLq8Bvmbt1hROr6Z5e6P2VDEgpoLIb4 U5LIoXo27yXmpVYiGolkgXTndLrdL51eGz/YAxpgp1B9UuxdzkGeiEYdTZX+U36FBufX4sLVTYS Hez+zsxXFCxpnD75SHZT2eL21QeCuZKg8OLAr/t0a7hFdgiUrtIqJ1jTxPB1RfxkScuXAixhzqT Yg/pLs4JPdrbYMpfan+DukuA/s3IqCnkAvNnAjoyOIzji4KqzBdVMzEYxJBu/NVUJ8VL6tj3WOK vddLJaQ3563tHDCkB5gCy+zKYn7WYmfXz9cbYiLgd3pWW2Fc2lF8peEVzmtHRsSL73BOQZNvCau eym7qsUX4w== X-Received: by 2002:a05:6000:4e9:b0:43a:4e5:73b0 with SMTP id ffacd0b85a97d-43a04e585b8mr21072634f8f.17.1773706323812; Mon, 16 Mar 2026 17:12:03 -0700 (PDT) Received: from mail.gmail.com (2a01cb0889497e00ceb2d69518440fd7.ipv6.abo.wanadoo.fr. [2a01:cb08:8949:7e00:ceb2:d695:1844:fd7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b416e3678sm17786534f8f.17.2026.03.16.17.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 17:12:02 -0700 (PDT) Date: Tue, 17 Mar 2026 01:12:00 +0100 From: Paul Chaignon To: Sun Jian Cc: andrii@kernel.org, eddyz87@gmail.com, shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/bpf: trampoline_count: use dedicated target function Message-ID: References: <20260315054227.118344-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260315054227.118344-1-sun.jian.kdev@gmail.com> On Sun, Mar 15, 2026 at 01:42:27PM +0800, Sun Jian wrote: > trampoline_count fills all trampoline attachment slots for a single > target function and verifies that one extra attach fails with -E2BIG. > > It currently targets bpf_modify_return_test, which is also used by > modify_return and get_func_ip_test. When those tests run in parallel, > they can contend for the same per-function trampoline quota and > cause unexpected attach failures. This issue is currently masked by > harness serialization. > > Add a dedicated bpf_trampoline_count_test target and switch > trampoline_count to use it. This keeps the test semantics unchanged > while isolating it from other modify_return-based selftests, so it no > longer needs to run in serial mode. Remove the TODO comment as > well. > > Tested: > ./test_progs -t trampoline_count -vv > ./test_progs -t modify_return -vv > ./test_progs -t get_func_ip_test -vv > ./test_progs -j$(nproc) -t trampoline_count -vv > ./test_progs -j$(nproc) -t > trampoline_count,modify_return,get_func_ip_test -vv I was able to reproduce the issue here then validate the fix. I however had to include several more tests that use bpf_modify_return_test (get_func_args_test, kprobe_multi_test, missed, and bpf_cookie) before I could reliably reproduce (in a loop that runs until it fails with an unexpected E2BIG). Tested-by: Paul Chaignon [...]