From: Dan Carpenter <dan.carpenter@linaro.org>
To: Marco Antonio Solis Segura <mshdevv@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: fix missing blank line after declarations
Date: Tue, 17 Mar 2026 14:41:41 +0300 [thread overview]
Message-ID: <abk99e3UhsuPCwHJ@stanley.mountain> (raw)
In-Reply-To: <20260317095453.54843-1-mshdevv@gmail.com>
On Tue, Mar 17, 2026 at 03:54:53AM -0600, Marco Antonio Solis Segura wrote:
> Add a missing blank line after declarations in struct fake_driver
> to satisfy checkpatch.pl warning.
>
> Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
> ---
> drivers/staging/vme_user/vme_fake.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed..eb918a857 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,6 +67,7 @@ struct fake_driver {
> unsigned long long lm_base;
> u32 lm_aspace;
> u32 lm_cycle;
> +
> void (*lm_callback[4])(void *);
This is also a declaration so checkpatch is just wrong. (Ignore
checkpatch mistakes or maybe try your hand at fixing checkpatch.pl).
regards,
dan carpenter
> void *lm_data[4];
> struct tasklet_struct int_tasklet;
next prev parent reply other threads:[~2026-03-17 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 9:54 [PATCH] staging: vme_user: fix missing blank line after declarations Marco Antonio Solis Segura
2026-03-17 11:41 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-18 16:19 shinsj4653
2026-01-18 19:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abk99e3UhsuPCwHJ@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mshdevv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox