[PATCH] staging: vme_user: fix missing blank line after declarations

[PATCH] staging: vme_user: fix missing blank line after declarations

[Marco Antonio Solis Segura]

Add a missing blank line after declarations in struct fake_driver
to satisfy checkpatch.pl warning.

Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
---
 drivers/staging/vme_user/vme_fake.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index be4ad47ed..eb918a857 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -67,6 +67,7 @@ struct fake_driver {
 	unsigned long long lm_base;
 	u32 lm_aspace;
 	u32 lm_cycle;
+
 	void (*lm_callback[4])(void *);
 	void *lm_data[4];
 	struct tasklet_struct int_tasklet;
-- 
2.53.0

Re: [PATCH] staging: vme_user: fix missing blank line after declarations

[Dan Carpenter]

On Tue, Mar 17, 2026 at 03:54:53AM -0600, Marco Antonio Solis Segura wrote:
> Add a missing blank line after declarations in struct fake_driver
> to satisfy checkpatch.pl warning.
> 
> Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
> ---
>  drivers/staging/vme_user/vme_fake.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed..eb918a857 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,6 +67,7 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +
>  	void (*lm_callback[4])(void *);

This is also a declaration so checkpatch is just wrong.  (Ignore
checkpatch mistakes or maybe try your hand at fixing checkpatch.pl).

regards,
dan carpenter

>  	void *lm_data[4];
>  	struct tasklet_struct int_tasklet;

[PATCH] staging: vme_user: fix missing blank line after declarations

[shinsj4653]

From: shinsj4653 <shinsj4653@gmail.com>

This patch fixes a coding style issue reported by checkpatch.pl:
"WARNING: Missing a blank line after declarations"

A blank line is added to separate the variable declaration from
the code logic, improving readability.

Signed-off-by: shinsj4653 <shinsj4653@gmail.com>
---
 drivers/staging/vme_user/vme_fake.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index 731fbba17dfd..55c00e1d162d 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -67,6 +67,7 @@ struct fake_driver {
 	unsigned long long lm_base;
 	u32 lm_aspace;
 	u32 lm_cycle;
+
 	void (*lm_callback[4])(void *);
 	void *lm_data[4];
 	struct tasklet_struct int_tasklet;
-- 
2.47.3

Re: [PATCH] staging: vme_user: fix missing blank line after declarations

[Dan Carpenter]

On Sun, Jan 18, 2026 at 11:19:54AM -0500, shinsj4653@gmail.com wrote:
> From: shinsj4653 <shinsj4653@gmail.com>
> 
> This patch fixes a coding style issue reported by checkpatch.pl:
> "WARNING: Missing a blank line after declarations"
> 
> A blank line is added to separate the variable declaration from
> the code logic, improving readability.
> 
> Signed-off-by: shinsj4653 <shinsj4653@gmail.com>

Use a real name, please.

> ---
>  drivers/staging/vme_user/vme_fake.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index 731fbba17dfd..55c00e1d162d 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,6 +67,7 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +

This is a bug in checkpatch.pl.  Try to fix checkpatch instead or
otherwise just ignore it when checkpatch is wrong.  The rules is that
when there is a declaration block at the start of a function then there
is a blank line between the declarations and the code.  Here, we're not
inside a function so something went wrong.

regards,
dan carpenter